From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: Error in project-shell? Date: Sat, 19 Mar 2022 04:14:23 +0200 Message-ID: <9c209fe6-da39-4a5c-cadf-f8b5d9bc371e@yandex.ru> References: <86tucj82d0.fsf@csic.es> <865yown5sg.fsf@csic.es> <7fc361d6-2df4-aa2a-4f02-1ae1e03ebb6a@yandex.ru> <861qz2vsh3.fsf@csic.es> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29833"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 To: =?UTF-8?Q?Juan_Jos=c3=a9_Garc=c3=ada-Ripoll?= , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Mar 19 03:15:32 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nVOcs-0007ci-V6 for ged-emacs-devel@m.gmane-mx.org; Sat, 19 Mar 2022 03:15:30 +0100 Original-Received: from localhost ([::1]:39794 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVOcr-0001nn-D1 for ged-emacs-devel@m.gmane-mx.org; Fri, 18 Mar 2022 22:15:29 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:46728) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVObt-00018B-2z for emacs-devel@gnu.org; Fri, 18 Mar 2022 22:14:29 -0400 Original-Received: from [2a00:1450:4864:20::32e] (port=54101 helo=mail-wm1-x32e.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVObr-0004nP-FR for emacs-devel@gnu.org; Fri, 18 Mar 2022 22:14:28 -0400 Original-Received: by mail-wm1-x32e.google.com with SMTP id 185so895719wmc.3 for ; Fri, 18 Mar 2022 19:14:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=9DQbkCi/rFXeDTo8XUMEnk6jnBJUb65orUQMGDW+w9w=; b=Ov5z5FFzpnF643lFJp5yp7bLoDKks8BodAbLflPhVpQMnWceUU5zSelvVcS0MNBlsc txmKKAvm5zBigynlWgCloXajoH7tNh752eNjWyucgDmFhRVNWimIU0xRyClcNJ/kHWcB uPppsQeaJJwIjrG/Um9wNYbAR7c6QDLIps2oR/KDJkexhr4y0sjj6a94gJjJwqcJNlq/ taswKAfJnKcFw2x1uk4Kea5NM2drE0e6Whx0FxAlAXyFCSp8DqxVkK1aWqh9n81R14HG 2ezUPKhb2QlJ8Rgu8YGfZgXNSSrsC4x8HoMTOKLV4sS5aL6wo8aicZmv+oiigrl+sIYl aSTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=9DQbkCi/rFXeDTo8XUMEnk6jnBJUb65orUQMGDW+w9w=; b=8KJN3rV1pl3sjaJiMcIcsaollGwrh6tvATIVKSRMloySJYn44uXFu3R1mAE6dKieeb J28r8H9+DTOHN65Z0UmKS85U+CVJwJNYE6EcwEmK4IIbVlWzXIf8WEJ3PvKD+O7r/VRx aMZzNtE8BiZe0VOXIM2fjXNeOiRkAUiYJu6HpLnsxpfMB8Q9tmRhFu4DijgQzXs4GjeT +bl3bSERoY3twdOyBG4DmG8JeNkZIlWd7CIiaoHaHhKtIvuk3Iil8ymUQ40Cb80l2A4B zg9EJKmWG842gopB1y8sAV2s/NlwdVunHzVWITvljgwzParyepoy3t5tIo+z8urePeEZ CAfQ== X-Gm-Message-State: AOAM532mt5HDQf/4p/sWf5kr9X3uo8QLPcsjDf6Myj9MRRiJWvdXyqWC 2ENacHLrOBMl0TB3B08G5/g= X-Google-Smtp-Source: ABdhPJyWKj9C1gLX4z48IKd19rhNve3340IgcksgmHq+0K1MuuTD4X7CHYneENNQ6jy3dC1R5grvyA== X-Received: by 2002:a05:600c:3595:b0:38c:7398:5570 with SMTP id p21-20020a05600c359500b0038c73985570mr11786758wmq.202.1647656065651; Fri, 18 Mar 2022 19:14:25 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id o19-20020a05600c511300b00389c3a281d7sm16623205wms.0.2022.03.18.19.14.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Mar 2022 19:14:25 -0700 (PDT) Content-Language: en-US In-Reply-To: <861qz2vsh3.fsf@csic.es> X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::32e (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::32e; envelope-from=raaahh@gmail.com; helo=mail-wm1-x32e.google.com X-Spam_score_int: 0 X-Spam_score: -0.1 X-Spam_bar: / X-Spam_report: (-0.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287303 Archived-At: Hi again, On 16.03.2022 17:15, Juan José García-Ripoll wrote: > I have been doing further tests and I think that the actual definition > should read as follows > > (defun project-shell-fix () > "Fixed version for project-shell" > (interactive) > (require 'comint) > (let* ((default-directory (expand-file-name (project-root (project-current t)))) > (default-project-shell-name (project-prefixed-buffer-name "shell")) > (shell-buffer (get-buffer default-project-shell-name))) > (if (comint-check-proc shell-buffer) > (pop-to-buffer shell-buffer (bound-and-true-p display-comint-buffer-action)) > (shell (or shell-buffer default-project-shell-name))))) > > The change in the last line is needed, because otherwise the shell is > created with the wrong name. Could you describe what happens in more detail? Which wrong name? And what about other changes? The version you showed differs from the current code in more than just the last line.