all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Clément Pit--Claudel" <clement.pit@gmail.com>
To: 24660@debbugs.gnu.org
Subject: bug#24660: 24.5; nxml-mode should support shift selection
Date: Mon, 10 Oct 2016 12:57:54 -0400	[thread overview]
Message-ID: <9c174b90-3d89-db23-49c8-7abea05dab55@gmail.com> (raw)
In-Reply-To: <CAP_d_8Xms9mSepSPMViSeJPzAYahBTJd=18ENRw9bz3nFdz96Q@mail.gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 1268 bytes --]

This looks great.  Thanks!

This kind of bugs exists in a bunch of places :/  The other one that I see all the time is modes that break delete-selection-mode by rebinding certain commands.

Cheers,
Clément.

On 2016-10-10 12:41, Yuri Khan wrote:
> Many movement commands, such as forward-word, forward-sexp,
> forward-sentence, next-line, and their backward counterparts, support
> shift selection. That is, holding down Shift along with their bindings
> causes region to be activated and/or extended.
> 
> $ emacs -Q
> 
> C-x C-f /tmp/test.xml
> 
>     <html>|<head></head><body></body></html>
> 
> C-M-S-<right> ;; C-M-<right> (translated) runs forward-sexp
> 
>     <html>[<head>]</head><body></body></html>
> 
> C-M-S-<right> ;; C-M-<right> (translated) runs forward-sexp
> 
>     <html>[<head></head>]<body></body></html>
> 
> 
> However, nxml-mode’s commands do not behave this way.
> 
>     <html>|<head></head><body></body></html>
> 
> C-M-S-n ;; C-M-n (translated) runs nxml-forward-element
> 
> Expected:
> 
>     <html>[<head></head>]<body></body></html>
> 
> Observed:
> 
>     <html><head></head>|<body></body></html>
> 
> 
> The attached patch fixes this for me. It is based on current master (fd45b3f).
> 


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2016-10-10 16:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-10 16:41 bug#24660: 24.5; nxml-mode should support shift selection Yuri Khan
2016-10-10 16:57 ` Clément Pit--Claudel [this message]
2016-10-18  6:46 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9c174b90-3d89-db23-49c8-7abea05dab55@gmail.com \
    --to=clement.pit@gmail.com \
    --cc=24660@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.