From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#43086: [PATCH] Allow tags backend to not query for TAGS file Date: Tue, 10 Sep 2024 16:30:18 +0300 Message-ID: <9bf7fe99-fd16-45ed-9215-a617de76777f@yandex.ru> References: <87k0xjue75.fsf@posteo.net> <87zfoog084.fsf@posteo.net> <86v7z8yojd.fsf@gnu.org> <864j6pvy8y.fsf@gnu.org> <7a242101-0bbb-43f1-846f-9d2a8f9a3990@yandex.ru> <86cylbviq0.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14803"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: philipk@posteo.net, 43086@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 10 15:32:09 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1so0yW-0003gr-Lj for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 10 Sep 2024 15:32:08 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1so0yO-0005pq-5M; Tue, 10 Sep 2024 09:32:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1so0yL-0005pZ-LQ for bug-gnu-emacs@gnu.org; Tue, 10 Sep 2024 09:31:57 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1so0yL-0002gk-Be for bug-gnu-emacs@gnu.org; Tue, 10 Sep 2024 09:31:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=jhVlksp2j1s5eg2Zc4XK/OSlM3JSdyfdF0jhht1IG6c=; b=SFSGz4AiFzQMXgxnSP2NuOZklDJCnRjJP8phBsG03hxETkuoN50xZ5cwv94dIigV7vYhNpiHHCOJFKoaEsWkTjNEHD+SpuTjLzbAx/rNJoGvpkw2hC+6mf8WUWHDTESFUZXLc/4MCIb2gmvlkKO4koMAA8sFmPIQ5ZzrLWcCkLsuNsozOCoRByWGOCPNYGufJ5IorcS9tDYVShcT8afol1EBY1/PTqqtWDa9A5LDUREMcRO8BPPx2nJOpaWRahHXj+evXr9vhzzRnYE22g6OvCBpdHOXCCTYPhAJQgJP9j2LkO+LY3+gybYsn6zIzdZwQk0BmSVn2bKolypwWHwYhQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1so0yQ-0003s5-8S for bug-gnu-emacs@gnu.org; Tue, 10 Sep 2024 09:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 10 Sep 2024 13:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43086 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 43086-submit@debbugs.gnu.org id=B43086.172597506414769 (code B ref 43086); Tue, 10 Sep 2024 13:32:02 +0000 Original-Received: (at 43086) by debbugs.gnu.org; 10 Sep 2024 13:31:04 +0000 Original-Received: from localhost ([127.0.0.1]:35078 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1so0xU-0003q9-14 for submit@debbugs.gnu.org; Tue, 10 Sep 2024 09:31:04 -0400 Original-Received: from forward501d.mail.yandex.net ([178.154.239.209]:44396) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1so0xS-0003pt-7o for 43086@debbugs.gnu.org; Tue, 10 Sep 2024 09:31:03 -0400 Original-Received: from mail-nwsmtp-smtp-production-main-84.klg.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-84.klg.yp-c.yandex.net [IPv6:2a02:6b8:c42:3ca5:0:640:b181:0]) by forward501d.mail.yandex.net (Yandex) with ESMTPS id 1F0E961386; Tue, 10 Sep 2024 16:30:25 +0300 (MSK) Original-Received: by mail-nwsmtp-smtp-production-main-84.klg.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id LUiLYWAoFKo0-WSizmVgc; Tue, 10 Sep 2024 16:30:24 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1725975024; bh=jhVlksp2j1s5eg2Zc4XK/OSlM3JSdyfdF0jhht1IG6c=; h=In-Reply-To:From:Subject:Message-ID:Cc:References:Date:To; b=gqniqLzHMny3vd6OFpfmsvbk97aNTadCDHMSw2kJdjiDFEWlMn0WMSnq6XD0hPFl1 S4TAew8BNxqbcGMPaXmYvKbmkZjUkA8MlwFP9nqc7C8JNRfryr8BxPmAfR7Gz7pZhC nRJW95HSc8CErCzSvLmqTDFeHmgIMD4bh7lKRxVw= Authentication-Results: mail-nwsmtp-smtp-production-main-84.klg.yp-c.yandex.net; dkim=pass header.i=@yandex.ru Original-Received: from phl-compute-10.internal (phl-compute-10.phl.internal [10.202.2.50]) by mailfauth.phl.internal (Postfix) with ESMTP id F378E120008A; Tue, 10 Sep 2024 09:30:20 -0400 (EDT) Original-Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-10.internal (MEProxy); Tue, 10 Sep 2024 09:30:20 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudeiledgheejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtvdej necuhfhrohhmpeffmhhithhrhicuifhuthhovhcuoegughhuthhovheshigrnhguvgigrd hruheqnecuggftrfgrthhtvghrnhepiefhjeeuveetffffvdefteffffekhfeuudejieeh heeiudelgfehgffffeduffdunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe hmrghilhhfrhhomhepughguhhtohhvodhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhi thihqddufeeffeelleehhedvqddvleegjeejjeejiedqughguhhtohhvpeephigrnhguvg igrdhruhesfhgrshhtmhgrihhlrdgtohhmpdhnsggprhgtphhtthhopeefpdhmohguvgep shhmthhpohhuthdprhgtphhtthhopegvlhhiiiesghhnuhdrohhrghdprhgtphhtthhope hphhhilhhiphhksehpohhsthgvohdrnhgvthdprhgtphhtthhopeegfedtkeeiseguvggs sghughhsrdhgnhhurd X-ME-Proxy: Feedback-ID: ib1d9465d:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 10 Sep 2024 09:30:19 -0400 (EDT) Content-Language: en-US In-Reply-To: <86cylbviq0.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:291564 Archived-At: On 10/09/2024 14:41, Eli Zaretskii wrote: >>> But what do you expect from a backend that depends on TAGS to do when >>> TAGS is not there? You yourself just noticed the regression. Why >>> would we want that? >> >> I'm thinking of the xref-find-references case - where the scanner >> doesn't depend on the tags table being available. Just the identifier >> completion step. > > Completion is also important, IMO. Just not always worth the extra query or wait time. >> We have an existing way to enable etags-regen-mode. And it's a global >> mode, so it's not just an issue of using it that one time - the naive >> solution will make stay on until the end of the session. > > We could in this particular case enable it once, then disable it after > regenerating TAGS. I'm not sure I'd want a one-time generation of tags which never gets updated afterward. Not for me, nor for an inexperienced user who would likely get puzzled at some point about why the index not updating. >> Also, if the tags file is not loaded, we're not quite sure whether the >> user wants an auto-generated file, or an existing one. > > The query should allow the user to tell us his/her preference, no? For that we need to decide on the options and the possible lifetimes of the answer in advance. That's all I'm saying: it's not an obvious "just ask the user". >> How do you feel about etags-regen-mode being on by default in some next >> Emacs release? It shouldn't conflict with the manual invocations of 'M-x >> visit-tags-file' - and of course if any cases come up we'll work on >> fixing those. > > As long as there's a way of turning it off, I don't think I will mind > too much. Great! As long as nobody objects in the coming days I'll switch the default value.