From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Daniel Colascione" Newsgroups: gmane.emacs.bugs Subject: bug#38492: 27.0.50; Warn pdumper users when pure space has been overflowed Date: Sun, 15 Dec 2019 12:41:06 -0800 Message-ID: <9bf76c35d7c57f0b181615614147d1f8.squirrel@dancol.org> References: <87o8wnj4nf.fsf@gmail.com> <66439438-e275-49cd-8b84-a70a4d1b2087@email.android.com> Mime-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="133666"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: SquirrelMail/1.4.23 [SVN] Cc: 38492@debbugs.gnu.org, kevin.legouguec@gmail.com To: "Stefan Monnier" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Dec 15 21:42:27 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1igaig-000YcX-2y for geb-bug-gnu-emacs@m.gmane.org; Sun, 15 Dec 2019 21:42:27 +0100 Original-Received: from localhost ([::1]:42752 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1igaie-0004Fd-RA for geb-bug-gnu-emacs@m.gmane.org; Sun, 15 Dec 2019 15:42:25 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38831) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1igaiJ-0004FF-CP for bug-gnu-emacs@gnu.org; Sun, 15 Dec 2019 15:42:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1igaiI-0002bD-AT for bug-gnu-emacs@gnu.org; Sun, 15 Dec 2019 15:42:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59517) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1igaiI-0002av-7S for bug-gnu-emacs@gnu.org; Sun, 15 Dec 2019 15:42:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1igaiI-0006Lo-5i for bug-gnu-emacs@gnu.org; Sun, 15 Dec 2019 15:42:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Daniel Colascione" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 15 Dec 2019 20:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38492 X-GNU-PR-Package: emacs Original-Received: via spool by 38492-submit@debbugs.gnu.org id=B38492.157644247524345 (code B ref 38492); Sun, 15 Dec 2019 20:42:02 +0000 Original-Received: (at 38492) by debbugs.gnu.org; 15 Dec 2019 20:41:15 +0000 Original-Received: from localhost ([127.0.0.1]:37253 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1igahW-0006Ka-VQ for submit@debbugs.gnu.org; Sun, 15 Dec 2019 15:41:15 -0500 Original-Received: from dancol.org ([96.126.100.184]:57098) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1igahV-0006KR-CE for 38492@debbugs.gnu.org; Sun, 15 Dec 2019 15:41:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:To:From: Subject:Date:References:In-Reply-To:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=5s0JjjeeuecM3S8LSDviMoSAdcfdWeulps9HtbKdNNM=; b=HtiPdnWSU0jK2u9TtNB23mtKOT bwl+3Vi/0ps22cEMPO2XZEfbVOMP67Os+w25//YgS0aeAFm6Jw73GGKCbuFLhuj+JlfQg8EchykTi xa5SS/nzPaykiKX3dgotfFdouIUKw4QF/2Jgw26WBpAzj6KDU6sV8KVZIQyLOjmNIKhvG/P7pRnly poUABo22YDS5Hm/2adC2D8uM8bp3fMddq14JcPWCd54dRlX+tC7ygHANDrIJmD5NpjAwVlnMDvdMC ecfKRfZfDvy1wELBT+1ogZW7OnK78VbIT5+etnYrDcGUCE07OqVumnvDtZQeWMIkIQugZtIi81cGD xmW1al/g==; Original-Received: from localhost ([127.0.0.1] helo=dancol.org) by dancol.org with esmtp (Exim 4.89) (envelope-from ) id 1igahO-0006Hs-Gr; Sun, 15 Dec 2019 12:41:06 -0800 Original-Received: from 127.0.0.1 (SquirrelMail authenticated user dancol) by dancol.org with HTTP; Sun, 15 Dec 2019 12:41:06 -0800 In-Reply-To: X-Priority: 3 (Normal) Importance: Normal X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:173396 Archived-At: >>> > We should probably consider just removing the pure space mechanism at >>> > some point. >>> Does this mean you agree with removing the warning in startup.el >>> about overflowed pure space? >> Yes. > > Why? > > This warning was placed because we needed to disable GC in dumps that > had overflown the purespace, so the dumped Emacs was not > fully functional. > > I see that with the current pdump we don't disable GC in dumps that > overflew the purespace. Why is that? > > IIRC, the problem with running GC in an Emacs with overflown purespace > is that overflowing the purespace created pointers from the purespace to > the heap and those aren't traced by the GC so it resulted in core dumps. > > I can't exactly remember the cases where this happened, but I can't see > why the pdumper would be less affected than the unexec code. > > I see that the code has a slightly different explanation: > > /* Can't GC if pure storage overflowed because we can't determine > if something is a pure object or not. */ > garbage_collection_inhibited++; > > but that comment similarly seems to apply to pdump just as much as it > applies to unexec. In a pdumped Emacs, we don't have anything in purespace on pdumper load, so we can GC normally. We do disable GC during dump operation itself if we overflow, true, and we shouldn't do that, but this problem affects only the build. We should just make sure Vpurify_flag is off if we're going to make a pdumper image.