From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#44202: [PATCH] Add variable to control confirmation of help-mode-revert-buffer Date: Sat, 24 Oct 2020 16:40:39 -0700 (PDT) Message-ID: <9b8f80b0-34ec-4ab9-8546-0c1e51da5696@default> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22398"; mail-complaints-to="usenet@ciao.gmane.io" To: Kevin Foley , 44202@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 25 01:41:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kWT9q-0005jb-CD for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 25 Oct 2020 01:41:10 +0200 Original-Received: from localhost ([::1]:35434 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kWT9o-0007qX-Vq for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 24 Oct 2020 19:41:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59190) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kWT9i-0007qN-HF for bug-gnu-emacs@gnu.org; Sat, 24 Oct 2020 19:41:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52146) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kWT9i-00077V-6R for bug-gnu-emacs@gnu.org; Sat, 24 Oct 2020 19:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kWT9i-0001zn-3v for bug-gnu-emacs@gnu.org; Sat, 24 Oct 2020 19:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Oct 2020 23:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44202 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 44202-submit@debbugs.gnu.org id=B44202.16035828507648 (code B ref 44202); Sat, 24 Oct 2020 23:41:02 +0000 Original-Received: (at 44202) by debbugs.gnu.org; 24 Oct 2020 23:40:50 +0000 Original-Received: from localhost ([127.0.0.1]:35459 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWT9W-0001zI-G1 for submit@debbugs.gnu.org; Sat, 24 Oct 2020 19:40:50 -0400 Original-Received: from userp2120.oracle.com ([156.151.31.85]:54726) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWT9T-0001z4-Jy for 44202@debbugs.gnu.org; Sat, 24 Oct 2020 19:40:48 -0400 Original-Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 09ONc4PK026340; Sat, 24 Oct 2020 23:40:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=1KD0E/yNevcb1ugQwzPTIh4eO8Wrfb0z1wnP4Wy6f2U=; b=wOv6fJU9ofkHvOGwjQtz33OgP5/7frVw2TYRl91QzXWFV1r15Bu4Hb8lg3ffuURDbbY0 4oDG1e7fUqaq6Plg/BAi1tLU/NHS8eVFz0dwU/4XbV/8azb6yjRl7rhGxHGJxv1xvxL0 /mc5Mh4sO36DqITlyeRJzWoWMnHGXJzZguI3FgVEEX+I04sBlDTOnGFbonAtamIBfMSa NyM3Mnz5W25T7V/V5lU0GAITbMYUmVufhONKig0IJ+4I1gKOk8RcdDp+169/Gbn6538t keMZNFxWIo4fTkyPn8EeNR3Alx93zIqJE/3Cyrq5KxqB/I637nRfMij4Q5x+4vanG6eI fg== Original-Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2120.oracle.com with ESMTP id 34ccwmh656-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Sat, 24 Oct 2020 23:40:41 +0000 Original-Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 09ONeI5K129101; Sat, 24 Oct 2020 23:40:41 GMT Original-Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3030.oracle.com with ESMTP id 34cwuj86cy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 24 Oct 2020 23:40:41 +0000 Original-Received: from abhmp0007.oracle.com (abhmp0007.oracle.com [141.146.116.13]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 09ONeeXZ013397; Sat, 24 Oct 2020 23:40:40 GMT In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5056.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9784 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxscore=0 bulkscore=0 spamscore=0 adultscore=0 malwarescore=0 mlxlogscore=999 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2010240183 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9784 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxscore=0 adultscore=0 spamscore=0 mlxlogscore=999 clxscore=1011 malwarescore=0 priorityscore=1501 impostorscore=0 bulkscore=0 suspectscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2010240182 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:191460 Archived-At: > +(defcustom help-mode-revert-buffer-noconfirm nil > + "Indicates whether to prompt for confirmation when reverting a > +help buffer." A minor comment (and others may disagree with me). I think the first line of the doc string should say what a true value means, because the option name does that. Or at least the doc string should somehow make clear which Boolean value means which behavior. E.g.: Non-nil means do not prompt for confirmation when reverting a help buffer. If you just say "whether" there's no way to know which value means what, except to guess from the option name, in which case the doc string doesn't add anything.