From: Dmitry Gutov <dmitry@gutov.dev>
To: Po Lu <luangruo@yahoo.com>
Cc: emacs-devel@gnu.org
Subject: Re: master 128ed5c9f17: Add one more mouse-set-point call to functions xref-find-*-at-mouse
Date: Thu, 31 Aug 2023 14:03:29 +0300 [thread overview]
Message-ID: <9aaa2343-3cc6-7089-634f-b30c71e6d550@gutov.dev> (raw)
In-Reply-To: <8734zzudo7.fsf@yahoo.com>
On 31/08/2023 05:51, Po Lu wrote:
> Dmitry Gutov<dmitry@gutov.dev> writes:
>
>> Sorry, I'm still not seeing your point. Especially the last paragraph
>> in my last email seems to remain unaddressed.
>>
>> And both commands take EVENT as an argument already.
>>
>> The problem is not where is searched for an identifier, but *from
>> where* it searched for the identifier's locations. And that position
>> is important only for particular Xref backends (both LSP-based ones,
>> I'm assuming).
> My point is this: xref-find-definitions itself, not its callers, should
> take EVENT, then call (goto-char (posn-point (event-start event)))
> within.
All right, but even that wouldn't save us from having to move to the
position twice (one in the interactive form, and once in the function body).
Otherwise, I see your point and cause of frustration, but extending the
convention to many (every?) interactive function seems difficult.
OTOH, Juri's line of thought with menu-handling code doing the move
sounds feasible. Maybe there would be a new interactive spec for such
commands, to choose which ones would need this specifically.
next prev parent reply other threads:[~2023-08-31 11:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <169344150641.11482.13012085201452768898@vcs2.savannah.gnu.org>
[not found] ` <20230831002506.C0C6DC038B5@vcs2.savannah.gnu.org>
2023-08-31 0:43 ` master 128ed5c9f17: Add one more mouse-set-point call to functions xref-find-*-at-mouse Po Lu
2023-08-31 0:54 ` Dmitry Gutov
2023-08-31 1:10 ` Po Lu
2023-08-31 2:05 ` Dmitry Gutov
2023-08-31 2:51 ` Po Lu
2023-08-31 6:37 ` Juri Linkov
2023-09-01 0:59 ` Po Lu
2023-09-01 6:50 ` Juri Linkov
2023-09-03 17:34 ` Juri Linkov
2023-09-04 16:42 ` Juri Linkov
2023-08-31 11:03 ` Dmitry Gutov [this message]
2023-08-31 11:35 ` Po Lu
2023-08-31 16:38 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9aaa2343-3cc6-7089-634f-b30c71e6d550@gutov.dev \
--to=dmitry@gutov.dev \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.