From: "Drew Adams" <drew.adams@oracle.com>
To: "'Chong Yidong'" <cyd@stupidchicken.com>,
"'martin rudalics'" <rudalics@gmx.at>
Cc: 7533@debbugs.gnu.org
Subject: bug#7533: 24.0.50; `dired-mark-pop-up': delete frame afterwards if `pop-up-frames'
Date: Thu, 16 Dec 2010 10:27:48 -0800 [thread overview]
Message-ID: <9FA3601ABD5C49E79DDAF60EAFFCD7F0@us.oracle.com> (raw)
In-Reply-To: <87zkslw43z.fsf@stupidchicken.com>
> > Meanwhile we should restore the old behavior. Chong could
> > you please apply the attached patch.
>
> Done.
FWIW, I still see the problem in the latest Windows binary:
In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600)
of 2010-12-13 on 3249CTO
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.4) --no-opt --cflags
-Ic:/imagesupport/include'
Martin's patch fixes the problem only for non-nil `pop-up-frames'. (So strictly
speaking it responds to the Subject line of the bug. But it does not respond
fully to what I meant in the bug report.)
It does not fix the problem if the buffer (e.g. `*Marked Files*') is popped up
in a separate frame for some other reason, for example, via
`special-display-popup-frame'.
To reproduce:
emacs -Q
M-x set-variable RET
special-display-regexps RET
("[ ]?[*][^*]+[*]") RET
The bug needs to be fixed so that _whenever_ the buffer is shown in a separate
frame that frame gets deleted when the dialog is finished (e.g. when the Dired
command to copy/delete/... is finished).
If you think a full fix is too complicated for now for some reason, then at
least bind `q' in that popped up buffer so that `q' invokes `quit-window' (_not_
`View-quit'), which will delete the frame. IOW, as a workaround, at least give
it the behavior of *Buffer List*, where hitting `q' deletes the frame,
Obliging the user to hit `q' is not the real solution. It just provides a
temporary workaround and should be considered only if you conclude that
implementing a good solution is too hard for the moment.
Alternatively, restore the behavior in Emacs 22, where even if
`special-display-regexps' would normally cause the buffer to be displayed in a
separate frame it is not: it is popped up in a window of the current frame.
That overrides the user's setting, but at least it is not annoying.
next prev parent reply other threads:[~2010-12-16 18:27 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-02 18:35 bug#7533: 24.0.50; `dired-mark-pop-up': delete frame afterwards if `pop-up-frames' Drew Adams
2010-12-02 19:05 ` martin rudalics
2010-12-02 19:22 ` Drew Adams
2010-12-03 8:17 ` martin rudalics
2010-12-03 16:22 ` Drew Adams
2010-12-03 18:16 ` martin rudalics
2010-12-03 18:33 ` Drew Adams
2010-12-03 18:41 ` martin rudalics
2010-12-04 22:44 ` Chong Yidong
2010-12-16 18:27 ` Drew Adams [this message]
2010-12-17 6:32 ` martin rudalics
2010-12-17 15:32 ` Drew Adams
2010-12-17 16:12 ` martin rudalics
2010-12-17 16:55 ` Drew Adams
2010-12-17 18:09 ` martin rudalics
2010-12-17 18:40 ` Drew Adams
2010-12-21 6:48 ` Chong Yidong
2010-12-03 20:27 ` Stefan Monnier
2012-04-05 20:23 ` Drew Adams
2012-04-06 14:02 ` martin rudalics
2012-04-06 14:44 ` Drew Adams
2012-04-06 14:53 ` martin rudalics
2012-04-06 15:34 ` Drew Adams
2012-04-06 15:47 ` martin rudalics
2012-04-06 16:10 ` Drew Adams
2012-04-06 16:56 ` martin rudalics
2012-04-06 17:08 ` Drew Adams
2012-04-18 14:32 ` Drew Adams
2012-05-25 20:52 ` Drew Adams
2012-05-26 17:55 ` bug#7533: 24.0.50; `dired-mark-pop-up': delete frame afterwards if `pop-up-frames' [PATCH] Drew Adams
2012-05-27 13:21 ` martin rudalics
2012-05-27 14:33 ` Drew Adams
2011-01-18 22:14 ` bug#7533: 24.0.50; `dired-mark-pop-up': delete frame afterwards if `pop-up-frames' Drew Adams
2012-09-05 14:30 ` martin rudalics
2012-09-05 14:33 ` Drew Adams
2012-10-03 9:11 ` martin rudalics
2012-10-03 15:52 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9FA3601ABD5C49E79DDAF60EAFFCD7F0@us.oracle.com \
--to=drew.adams@oracle.com \
--cc=7533@debbugs.gnu.org \
--cc=cyd@stupidchicken.com \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.