From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Paul W. Rankin" via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#72521: [PATCH]: lisp/help-macro.el: remove hard-coded variable-pitch-mode Date: Thu, 8 Aug 2024 12:25:18 +1000 Message-ID: <9EE4E140-25B4-4F0D-BA28-E698BD438CF7@rnkn.xyz> References: <9417FE9A-2B7C-4A23-80DE-1322E0ECB812@rnkn.xyz> Reply-To: "Paul W. Rankin" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.600.62\)) Content-Type: multipart/mixed; boundary="Apple-Mail=_B9ACE9E8-74D4-4700-86D5-B7E2C4E3D4E0" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13769"; mail-complaints-to="usenet@ciao.gmane.io" To: 72521@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 08 09:32:01 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sbxct-0003O7-V5 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 08 Aug 2024 09:32:01 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sbxcY-0007s0-Ln; Thu, 08 Aug 2024 03:31:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sbxcX-0007rR-60 for bug-gnu-emacs@gnu.org; Thu, 08 Aug 2024 03:31:37 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sbxcW-0004Qz-TS for bug-gnu-emacs@gnu.org; Thu, 08 Aug 2024 03:31:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:References:Date:Mime-Version:From:To:Subject; bh=lR06ZeUh5yAe3WaEv0aZAad+ZqSvMNIqN3KgpiwWF5s=; b=sZxs2Zov+bLCU4uZ5TYgMgrPRwVqTixT9b4LuOKb1XqSKHiFbkzAv1RcpzNL5Ka4yXfEVK5CyrNaJCWrAigvjHojH1ET+Y5C+sMObuz4HbCVWOn8n8nOQzoc9JgaN72rCc36s1Pow6bYOZwnrKCD4yTDd3zBTFY6ZI4ONTUHd+vVrvRzHk6Vcd+E428hrB3hDZ4JxxasL/H1369eMyP1EA9uyaDDDqTdgX/VUKoivS/RVWxbrxC0zG+JlSh8pnfmI4SVIVkv4LDaDVhu4PZBxkZtSW1M+XQd9s63pGpUBCLPu33UYIFnwPou9Sgugpr9rig2uJIvF7noUWDP+c/piw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sbxcw-0001so-28 for bug-gnu-emacs@gnu.org; Thu, 08 Aug 2024 03:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Paul W. Rankin" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Aug 2024 07:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 72521 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.17231022697176 (code B ref -1); Thu, 08 Aug 2024 07:32:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 8 Aug 2024 07:31:09 +0000 Original-Received: from localhost ([127.0.0.1]:35434 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sbxc4-0001rf-Qr for submit@debbugs.gnu.org; Thu, 08 Aug 2024 03:31:09 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:35040) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sbssz-0001wM-88 for submit@debbugs.gnu.org; Wed, 07 Aug 2024 22:28:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sbsqS-0003SX-7Y for bug-gnu-emacs@gnu.org; Wed, 07 Aug 2024 22:25:40 -0400 Original-Received: from mr85p00im-zteg06022001.me.com ([17.58.23.193]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sbsqQ-0005ZT-H8 for bug-gnu-emacs@gnu.org; Wed, 07 Aug 2024 22:25:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rnkn.xyz; s=sig1; t=1723083934; bh=lR06ZeUh5yAe3WaEv0aZAad+ZqSvMNIqN3KgpiwWF5s=; h=From:Content-Type:Mime-Version:Subject:Date:To:Message-Id; b=VSrzWTLgmpX5qSMzPWNSBmDZ4qV4ETjqseIfy2Qe/ZxFQYuVYHzvEmgwScDBEfVCF tnW+n5liTPkhRyxQUYoY4MLKrS656RMAx1cFvY5F7wvVU8L3n/ORfLIez+0twGo9EA 57VNJ1PqUE3Bbfe2HeeiiN+C0jMiXN2jOJdK0A8ZeuZrOrf/11RsaETZjEHwjucQ66 ryY2GaRh5sI2i9lUsqXtB+89mKvnCGKPwkXZxZtPiDVDK3bRH1bXdYt7IdegZGUSuc r5udcu4gAwiWdaWX133+ewFYtIix+hTUQqTsLbflsgpMHy0ZYmeEoDSb+YE4CpDtIt Nai7M8xhs+cTg== Original-Received: from smtpclient.apple (mr38p00im-dlb-asmtp-mailmevip.me.com [17.57.152.18]) by mr85p00im-zteg06022001.me.com (Postfix) with ESMTPSA id 627D28002D4 for ; Thu, 8 Aug 2024 02:25:31 +0000 (UTC) In-Reply-To: <9417FE9A-2B7C-4A23-80DE-1322E0ECB812@rnkn.xyz> X-Mailer: Apple Mail (2.3774.600.62) X-Proofpoint-ORIG-GUID: LwfcUEuBYo_TmvoVvqrI0YfzzetV6A57 X-Proofpoint-GUID: LwfcUEuBYo_TmvoVvqrI0YfzzetV6A57 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-08-08_02,2024-08-07_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=4 mlxscore=4 suspectscore=0 adultscore=0 spamscore=4 bulkscore=0 clxscore=1030 mlxlogscore=144 phishscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2308100000 definitions=main-2408080015 Received-SPF: pass client-ip=17.58.23.193; envelope-from=rnkn@rnkn.xyz; helo=mr85p00im-zteg06022001.me.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Thu, 08 Aug 2024 03:31:07 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289922 Archived-At: --Apple-Mail=_B9ACE9E8-74D4-4700-86D5-B7E2C4E3D4E0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii > On 8 Aug 2024, at 12:18, Paul W. Rankin wrote: > > This is currently hard-coded and should instead be implemented as a > user option, probably a hook, but this is outside the scope of this > patch. > > <0001-lisp-help-macro.el-remove-hard-coded-variable-pitch-.patch> Patched instead against current master. --Apple-Mail=_B9ACE9E8-74D4-4700-86D5-B7E2C4E3D4E0 Content-Disposition: attachment; filename=0001-lisp-help-macro.el-remove-hard-coded-variable-pitch-.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-lisp-help-macro.el-remove-hard-coded-variable-pitch-.patch" Content-Transfer-Encoding: quoted-printable =46rom=20f981194cd124871d1bb8cbec21812abe057577af=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20"Paul=20W.=20Rankin"=20=0ADate:=20= Thu,=208=20Aug=202024=2012:23:55=20+1000=0ASubject:=20[PATCH]=20*=20= lisp/help-macro.el:=20remove=20hard-coded=20variable-pitch-mode=0A=0A= This=20should=20be=20implemented=20as=20a=20user=20option=20hook=0A---=0A= =20lisp/help-macro.el=20|=201=20-=0A=201=20file=20changed,=201=20= deletion(-)=0A=0Adiff=20--git=20a/lisp/help-macro.el=20= b/lisp/help-macro.el=0Aindex=208a16e85a329..5b941c0433b=20100644=0A---=20= a/lisp/help-macro.el=0A+++=20b/lisp/help-macro.el=0A@@=20-146,7=20+146,6=20= @@=20help--help-screen=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20(insert=20(substitute-command-keys=20help-screen)))=0A=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20(let=20((minor-mode-map-alist=20= new-minor-mode-map-alist))=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20(help-mode)=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (variable-pitch-mode)=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (setq=20new-minor-mode-map-alist=20minor-mode-map-alist))=0A=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20(goto-char=20(point-min))=0A=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20(while=20(or=20(memq=20char=20(append=20= help-event-list=0A--=20=0A2.39.3=20(Apple=20Git-146)=0A=0A= --Apple-Mail=_B9ACE9E8-74D4-4700-86D5-B7E2C4E3D4E0--