all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Paul W. Rankin" via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: 72521@debbugs.gnu.org
Subject: bug#72521: [PATCH]: lisp/help-macro.el: remove hard-coded variable-pitch-mode
Date: Thu, 8 Aug 2024 12:25:18 +1000	[thread overview]
Message-ID: <9EE4E140-25B4-4F0D-BA28-E698BD438CF7@rnkn.xyz> (raw)
In-Reply-To: <9417FE9A-2B7C-4A23-80DE-1322E0ECB812@rnkn.xyz>

[-- Attachment #1: Type: text/plain, Size: 332 bytes --]

> On 8 Aug 2024, at 12:18, Paul W. Rankin <rnkn@rnkn.xyz> wrote:
> 
> This is currently hard-coded and should instead be implemented as a 
> user option, probably a hook, but this is outside the scope of this 
> patch.
> 
> <0001-lisp-help-macro.el-remove-hard-coded-variable-pitch-.patch>

Patched instead against current master.


[-- Attachment #2: 0001-lisp-help-macro.el-remove-hard-coded-variable-pitch-.patch --]
[-- Type: application/octet-stream, Size: 942 bytes --]

From f981194cd124871d1bb8cbec21812abe057577af Mon Sep 17 00:00:00 2001
From: "Paul W. Rankin" <rnkn@rnkn.xyz>
Date: Thu, 8 Aug 2024 12:23:55 +1000
Subject: [PATCH] * lisp/help-macro.el: remove hard-coded variable-pitch-mode

This should be implemented as a user option hook
---
 lisp/help-macro.el | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lisp/help-macro.el b/lisp/help-macro.el
index 8a16e85a329..5b941c0433b 100644
--- a/lisp/help-macro.el
+++ b/lisp/help-macro.el
@@ -146,7 +146,6 @@ help--help-screen
                 (insert (substitute-command-keys help-screen)))
               (let ((minor-mode-map-alist new-minor-mode-map-alist))
                 (help-mode)
-                (variable-pitch-mode)
                 (setq new-minor-mode-map-alist minor-mode-map-alist))
               (goto-char (point-min))
               (while (or (memq char (append help-event-list
-- 
2.39.3 (Apple Git-146)


       reply	other threads:[~2024-08-08  2:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <9417FE9A-2B7C-4A23-80DE-1322E0ECB812@rnkn.xyz>
2024-08-08  2:25 ` Paul W. Rankin via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-08-08  8:58   ` bug#72521: [PATCH]: lisp/help-macro.el: remove hard-coded variable-pitch-mode Eli Zaretskii
2024-08-08  9:37     ` Paul W. Rankin via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-08  9:37     ` Paul W. Rankin via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-08  9:45       ` Eli Zaretskii
2024-08-08  9:57         ` Paul W. Rankin via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-08 10:34           ` Eli Zaretskii
2024-08-08 10:34             ` Paul W. Rankin via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9EE4E140-25B4-4F0D-BA28-E698BD438CF7@rnkn.xyz \
    --to=bug-gnu-emacs@gnu.org \
    --cc=72521@debbugs.gnu.org \
    --cc=rnkn@rnkn.xyz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.