From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#59888: [PATCH] Add 'grep-heading-mode' Date: Thu, 8 Dec 2022 10:57:59 +0100 Message-ID: <9DED6125-13ED-4BF6-83A1-E1B2C4249F24@acm.org> References: <87v8mndrla.fsf@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28911"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59888@debbugs.gnu.org To: Augusto Stoffel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 08 10:59:15 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p3DgR-0007JC-Hs for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 08 Dec 2022 10:59:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p3DgG-0000v3-Vk; Thu, 08 Dec 2022 04:59:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3DgF-0000up-Ja for bug-gnu-emacs@gnu.org; Thu, 08 Dec 2022 04:59:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p3DgE-0001Eq-AJ for bug-gnu-emacs@gnu.org; Thu, 08 Dec 2022 04:59:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p3DgE-00084Q-0c for bug-gnu-emacs@gnu.org; Thu, 08 Dec 2022 04:59:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <87v8mndrla.fsf@gmail.com> Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Dec 2022 09:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59888 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59888-submit@debbugs.gnu.org id=B59888.167049349431003 (code B ref 59888); Thu, 08 Dec 2022 09:59:01 +0000 Original-Received: (at 59888) by debbugs.gnu.org; 8 Dec 2022 09:58:14 +0000 Original-Received: from localhost ([127.0.0.1]:55712 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3DfS-00083z-28 for submit@debbugs.gnu.org; Thu, 08 Dec 2022 04:58:14 -0500 Original-Received: from mail1443c50.megamailservers.eu ([91.136.14.43]:50956 helo=mail264c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3DfO-00083r-3d for 59888@debbugs.gnu.org; Thu, 08 Dec 2022 04:58:12 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1670493483; bh=rkcdFcUpqgpDCvmjn7gu0F7CZA2T1S7DGne+CV7CJY8=; h=From:Subject:Date:Cc:To:From; b=sxeSImFfvE/Tuoe42MaLxg71dGJrTuz4GbI8cJXyaRMkhO0qq9hCLUVCGBNNnSRJf dX9gC9u/V3erTkdsyqg+1Os4e7mWiJEFs5Ych2IWALsrTvWveUt7QXDwtUxSoJbEq1 45uWAyNqqS5ZsUrKY2UrUoro5unO0ScHzyf2P6bY= Feedback-ID: mattiase@acm.or Original-Received: from smtpclient.apple (c188-150-171-209.bredband.tele2.se [188.150.171.209]) (authenticated bits=0) by mail264c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 2B89w0d9071551; Thu, 8 Dec 2022 09:58:01 +0000 X-Mailer: Apple Mail (2.3654.120.0.1.13) X-CTCH-RefID: str=0001.0A782F27.6391B52B.0010, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-Origin-Country: SE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250259 Archived-At: No argument about the idea (good to me) or implementation but minor = points regarding the regexp: > + (group-n 1 (+? any)) Very much prefer `nonl` or `not-newline` to `any`, which is only there = for compatibility (shouldn't have been included in the first place). > + (any "\0-:=3D")) Is the range (ASCII 00..1A) intended here, or should that be a literal = hyphen? If the former, it should probably be made more explicit since that range = includes all sorts of numbers, symbols and control chars and it kind of = looks like it may be a mistake.