From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#35869: [PATCH] `cl-member' and `cl-assoc' do not work for bignums Date: Thu, 23 May 2019 18:01:05 +0200 Message-ID: <9DDA083E-C47B-42F4-96A8-BDF8FB08E5EC@acm.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Content-Type: multipart/mixed; boundary="Apple-Mail=_22773808-41CA-49E0-A2BF-C47642F79FDF" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="262679"; mail-complaints-to="usenet@blaine.gmane.org" To: 35869@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu May 23 18:16:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hTqO0-0016A5-UZ for geb-bug-gnu-emacs@m.gmane.org; Thu, 23 May 2019 18:16:09 +0200 Original-Received: from localhost ([127.0.0.1]:40160 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTqNz-0000dZ-Nt for geb-bug-gnu-emacs@m.gmane.org; Thu, 23 May 2019 12:16:07 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60514) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTqAR-0004ec-J7 for bug-gnu-emacs@gnu.org; Thu, 23 May 2019 12:02:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hTqAP-0002Ca-L1 for bug-gnu-emacs@gnu.org; Thu, 23 May 2019 12:02:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59780) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hTqAM-0002Ax-N9 for bug-gnu-emacs@gnu.org; Thu, 23 May 2019 12:02:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hTqAM-0007jF-Ju for bug-gnu-emacs@gnu.org; Thu, 23 May 2019 12:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 23 May 2019 16:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 35869 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.155862728329659 (code B ref -1); Thu, 23 May 2019 16:02:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 23 May 2019 16:01:23 +0000 Original-Received: from localhost ([127.0.0.1]:45091 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hTq9j-0007iJ-5K for submit@debbugs.gnu.org; Thu, 23 May 2019 12:01:23 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45486) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hTq9f-0007i3-SA for submit@debbugs.gnu.org; Thu, 23 May 2019 12:01:20 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:54589) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hTq9a-0001bF-M9 for submit@debbugs.gnu.org; Thu, 23 May 2019 12:01:14 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59836) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTq9X-0003t4-36 for bug-gnu-emacs@gnu.org; Thu, 23 May 2019 12:01:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hTq9W-0001YK-5X for bug-gnu-emacs@gnu.org; Thu, 23 May 2019 12:01:11 -0400 Original-Received: from mail80c50.megamailservers.eu ([91.136.10.90]:41832 helo=mail70c50.megamailservers.eu) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hTq9V-0001Wq-C6 for bug-gnu-emacs@gnu.org; Thu, 23 May 2019 12:01:10 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1558627267; bh=Ci1k+iyY/SzH7EAyCu5eZz9Z/8aWlwLG/OFFJO4qnzM=; h=From:Subject:Date:To:From; b=gUyt+8t0Cu1KXGGxFg/k69ApKFBQj5Hl2zhipaPxnRGmm9I3It4Q3ceyETsNC82fv XPZxOnKhwJpiQw0oplufkClpTbzE9UfaEDkWq1Q7oBfwJGg3zqJwnrSAAD+yNTu86f SOg0PHEokoMh3D2jcmSAfsD5xYFqec93lEVKTp3Y= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.0.4] ([188.150.171.71]) (authenticated bits=0) by mail70c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x4NG15Zr006875 for ; Thu, 23 May 2019 16:01:07 +0000 X-Mailer: Apple Mail (2.3445.104.11) X-CTCH-RefID: str=0001.0A0B020A.5CE6C3C3.001F, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=epTxMLhX c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=Ctdqq3ap4IKs8NbUZ34A:9 a=CjuIK1q_8ugA:10 a=5zPVfcQKmIbxVPxZhCEA:9 a=B2y7HmGcmWMA:10 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159683 Archived-At: --Apple-Mail=_22773808-41CA-49E0-A2BF-C47642F79FDF Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii (cl-member (ash 1 100) (list (ash 1 100))) => nil (cl-assoc (ash 1 100) (list (cons (ash 1 100) t))) => nil Suggested patch attached. --Apple-Mail=_22773808-41CA-49E0-A2BF-C47642F79FDF Content-Disposition: attachment; filename=0001-Fix-cl-member-and-cl-assoc-for-bignums.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Fix-cl-member-and-cl-assoc-for-bignums.patch" Content-Transfer-Encoding: quoted-printable =46rom=206313fdb00b13246305be0218452afefe9e05432c=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Mattias=3D20Engdeg=3DC3=3DA5rd?=3D=20= =0ADate:=20Thu,=2023=20May=202019=2017:54:58=20+0200=0A= Subject:=20[PATCH]=20Fix=20`cl-member'=20and=20`cl-assoc'=20for=20= bignums=0A=0A*=20lisp/emacs-lisp/cl-seq.el=20(cl-member,=20cl-assoc):=20= Work=20with=20bignums.=0A*=20test/lisp/emacs-lisp/cl-seq-tests.el=20= (cl-seq-bignum-eql):=20New.=0A---=0A=20lisp/emacs-lisp/cl-seq.el=20=20=20= =20=20=20=20=20=20=20=20=20|=206=20++----=0A=20= test/lisp/emacs-lisp/cl-seq-tests.el=20|=208=20++++++++=0A=202=20files=20= changed,=2010=20insertions(+),=204=20deletions(-)=0A=0Adiff=20--git=20= a/lisp/emacs-lisp/cl-seq.el=20b/lisp/emacs-lisp/cl-seq.el=0Aindex=20= 3eb6ea16da..86a73e1997=20100644=0A---=20a/lisp/emacs-lisp/cl-seq.el=0A= +++=20b/lisp/emacs-lisp/cl-seq.el=0A@@=20-703,9=20+703,7=20@@=20= cl-member=0A=20=09(while=20(and=20cl-list=20(not=20(cl--check-test=20= cl-item=20(car=20cl-list))))=0A=20=09=20=20(setq=20cl-list=20(cdr=20= cl-list)))=0A=20=09cl-list)=0A-=20=20=20=20(if=20(and=20(numberp=20= cl-item)=20(not=20(integerp=20cl-item)))=0A-=09(member=20cl-item=20= cl-list)=0A-=20=20=20=20=20=20(memq=20cl-item=20cl-list))))=0A+=20=20=20=20= (memql=20cl-item=20cl-list)))=0A=20(autoload=20= 'cl--compiler-macro-member=20"cl-macs")=0A=20=0A=20;;;###autoload=0A@@=20= -744,7=20+742,7=20@@=20cl-assoc=0A=20=09=09=09(not=20(cl--check-test=20= cl-item=20(car=20(car=20cl-alist))))))=0A=20=09=20=20(setq=20cl-alist=20= (cdr=20cl-alist)))=0A=20=09(and=20cl-alist=20(car=20cl-alist)))=0A-=20=20= =20=20(if=20(and=20(numberp=20cl-item)=20(not=20(integerp=20cl-item)))=0A= +=20=20=20=20(if=20(numberp=20cl-item)=0A=20=09(assoc=20cl-item=20= cl-alist)=0A=20=20=20=20=20=20=20(assq=20cl-item=20cl-alist))))=0A=20= (autoload=20'cl--compiler-macro-assoc=20"cl-macs")=0Adiff=20--git=20= a/test/lisp/emacs-lisp/cl-seq-tests.el=20= b/test/lisp/emacs-lisp/cl-seq-tests.el=0Aindex=2086288e99ca..6515eee9f2=20= 100644=0A---=20a/test/lisp/emacs-lisp/cl-seq-tests.el=0A+++=20= b/test/lisp/emacs-lisp/cl-seq-tests.el=0A@@=20-302,6=20+302,14=20@@=20= cl-seq--with-side-effects=0A=20=20=20=20=20(should=20(equal=20'(2=208)=20= (last=20(cl-replace=20list=20list2)=202)))=0A=20=20=20=20=20(should=20= (equal=20'(1=201)=20(last=20(cl-fill=20list=201)=202)))))=0A=20=0A= +(ert-deftest=20cl-seq-bignum-eql=20()=0A+=20=20(let=20((x=20(+=20= most-positive-fixnum=201))=0A+=20=20=20=20=20=20=20=20(y=20(+=20= most-positive-fixnum=201)))=0A+=20=20=20=20(let=20((l=20(list=20y)))=0A+=20= =20=20=20=20=20(should=20(eq=20(cl-member=20x=20l)=20l)))=0A+=20=20=20=20= (let=20((a=20(list=20(cons=20y=201)=20(cons=202=20y))))=0A+=20=20=20=20=20= =20(should=20(eq=20(cl-assoc=20x=20a)=20(car=20a)))=0A+=20=20=20=20=20=20= (should=20(eq=20(cl-rassoc=20x=20a)=20(cadr=20a))))))=0A=20=0A=20= (provide=20'cl-seq-tests)=0A=20;;;=20cl-seq-tests.el=20ends=20here=0A--=20= =0A2.20.1=20(Apple=20Git-117)=0A=0A= --Apple-Mail=_22773808-41CA-49E0-A2BF-C47642F79FDF--