From: David Reitter <david.reitter@gmail.com>
To: "Jose Figueroa-O'Farrill" <j.m.figueroa@ed.ac.uk>
Cc: 527@emacsbugs.donarmstrong.com
Subject: bug#527: input-input-method / Many crashes / Japanese input
Date: Fri, 4 Jul 2008 08:18:39 +0100 [thread overview]
Message-ID: <9DD90769-D7D0-4EE6-A4F1-09DAD0AB9DA9@gmail.com> (raw)
In-Reply-To: <wlprpus4wl.wl%mituharu@math.s.chiba-u.ac.jp>
[-- Attachment #1: Type: text/plain, Size: 3952 bytes --]
José,
I've added this patch and started a new build; please download at
nightly build from about 12 noon Edinburgh time.
- David
On 4 Jul 2008, at 04:29, YAMAMOTO Mitsuharu wrote:
>>>>>> On Thu, 3 Jul 2008 11:45:07 +0100, David Reitter <david.reitter@gmail.com
>>>>>> > said:
>
>> Begin forwarded message:
>
>>> From: "Jose Figueroa-O'Farrill" <j.m.figueroa@ed.ac.uk>
>>> Date: 3 July 2008 10:52:27 BST
>>> To: aquamacs-bugs@aquamacs.org
>>> Subject: [Aquamacs-bugs] Many crashes in 1.4
>>> Reply-To: j.m.figueroa@ed.ac.uk
>>>
>>>
>>> Hi,
>>>
>>> It's the third time that Aquamacs 1.4 crashes while typing. This
>>> had not happened in a looooong time. This time I managed to save
>>> the
>>> crash report which I include below. I'm afraid that I don't know
>>> how
>>> to reproduce it.
>>>
>>> Cheers, José
>>>
>>>
>>> Date/Time: 2008-07-02 23:06:09.682 +0200
>>> OS Version: 10.4.11 (Build 8S165)
>>> Report Version: 4
>>>
>>> Command: Aquamacs Emacs
>>> Path: /Applications/Aquamacs Emacs.app/Contents/MacOS/Aquamacs
>>> Emacs
>>> Parent: WindowServer [62]
>>>
>>> Version: Aquamacs 1.4, GNU Emacs 22 ()
>>>
>>> PID: 14598
>>> Thread: 0
>>>
>>> Exception: EXC_BAD_ACCESS (0x0001)
>>> Codes: KERN_PROTECTION_FAILURE (0x0002) at 0x00000008
>>>
>>> Thread 0 Crashed:
>>> 0 org.gnu.AquamacsEmacs 0x00175138
>>> mac_handle_text_input_event + 1720
> (snip)
>>> Thread 0 crashed with PPC Thread State 64:
>>> r4: 0x0000000000000000 r5: 0x00000000081f0800 r6:
>>> 0x0000000000000000 r7: 0x0000000000000059
>
> If your object file is not much different from mine, the crash seems
> to happen just before a call to Long2Fix.
>
> _mac_handle_text_input_event:
>
> +1708 00000a6c 81230008 lwz r9,0x8(r3)
> +1712 00000a70 5402103a rlwinm r2,r0,2,0,29
> +1716 00000a74 7cc2482e lwzx r6,r2,r9
> +1720 00000a78 83a60008 lwz r29,0x8(r6)
> +1724 00000a7c 2f9d0000 cmpwi cr7,r29,0x0
> +1728 00000a80 419efe88 beq cr7,0x908
> +1732 00000a84 807d0008 lwz r3,0x8(r29)
> +1736 00000a88 48008959 bl 0x93e0 _Long2Fix
>
> Could you try the patch below?
>
> YAMAMOTO Mitsuharu
> mituharu@math.s.chiba-u.ac.jp
>
> Index: src/mactoolbox.c
> ===================================================================
> RCS file: /cvsroot/emacs/emacs/src/mactoolbox.c,v
> retrieving revision 1.1.2.4
> diff -c -p -r1.1.2.4 mactoolbox.c
> *** src/mactoolbox.c 23 Apr 2008 08:56:20 -0000 1.1.2.4
> --- src/mactoolbox.c 4 Jul 2008 03:20:27 -0000
> *************** mac_handle_text_input_event (next_handle
> *** 575,581 ****
> int hpos, vpos, x, y;
> struct glyph_row *row;
> struct glyph *glyph;
> ! XFontStruct *font;
>
> f = mac_focus_frame (&one_mac_display_info);
> w = XWINDOW (f->selected_window);
> --- 575,581 ----
> int hpos, vpos, x, y;
> struct glyph_row *row;
> struct glyph *glyph;
> ! struct face *face;
>
> f = mac_focus_frame (&one_mac_display_info);
> w = XWINDOW (f->selected_window);
> *************** mac_handle_text_input_event (next_handle
> *** 600,608 ****
> + row->visible_height
> + f->top_pos + FRAME_OUTER_TO_INNER_DIFF_Y (f));
>
> ! font = FACE_FROM_ID (f, glyph->face_id)->font;
> ! if (font)
> {
> Fixed point_size = Long2Fix (font->mac_fontsize);
> short height = row->visible_height;
> short ascent = row->ascent;
> --- 600,609 ----
> + row->visible_height
> + f->top_pos + FRAME_OUTER_TO_INNER_DIFF_Y (f));
>
> ! face = FACE_FROM_ID (f, glyph->face_id);
> ! if (face && face->font)
> {
> + XFontStruct *font = face->font;
> Fixed point_size = Long2Fix (font->mac_fontsize);
> short height = row->visible_height;
> short ascent = row->ascent;
>
[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 2193 bytes --]
prev parent reply other threads:[~2008-07-04 7:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <18540.41308.57261.183352@castalia.local>
2008-07-03 10:45 ` bug#527: input-input-method / Many crashes / Japanese input David Reitter
[not found] ` <307A5450-EC7A-487D-8DD1-4C14BF746E47@gmail.com>
2008-07-04 3:29 ` YAMAMOTO Mitsuharu
2008-07-04 7:18 ` David Reitter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9DD90769-D7D0-4EE6-A4F1-09DAD0AB9DA9@gmail.com \
--to=david.reitter@gmail.com \
--cc=527@emacsbugs.donarmstrong.com \
--cc=j.m.figueroa@ed.ac.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.