From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#63103: 30.0.50; nconc compiler optimization breaks user packages Date: Thu, 27 Apr 2023 11:47:13 +0200 Message-ID: <9DCB2C69-7C1E-48A0-8AE2-BD8B1C0E3A80@acm.org> References: <877cty45rx.fsf@gmail.com> <871qk5516v.fsf@posteo.net> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39853"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Philip Kaludercic , Stefan Monnier , 63103@debbugs.gnu.org To: Daniel Mendler Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 27 11:48:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pryEc-000A9h-0H for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 27 Apr 2023 11:48:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pryEO-0003zy-6g; Thu, 27 Apr 2023 05:48:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pryEN-0003zq-1a for bug-gnu-emacs@gnu.org; Thu, 27 Apr 2023 05:48:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pryEM-0007eE-PL for bug-gnu-emacs@gnu.org; Thu, 27 Apr 2023 05:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pryEM-00006q-3h for bug-gnu-emacs@gnu.org; Thu, 27 Apr 2023 05:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Apr 2023 09:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63103 X-GNU-PR-Package: emacs Original-Received: via spool by 63103-submit@debbugs.gnu.org id=B63103.168258884532702 (code B ref 63103); Thu, 27 Apr 2023 09:48:02 +0000 Original-Received: (at 63103) by debbugs.gnu.org; 27 Apr 2023 09:47:25 +0000 Original-Received: from localhost ([127.0.0.1]:57595 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pryDk-0008VO-RV for submit@debbugs.gnu.org; Thu, 27 Apr 2023 05:47:25 -0400 Original-Received: from mail229c50.megamailservers.eu ([91.136.10.239]:54572 helo=mail36c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pryDi-0008VE-Lf for 63103@debbugs.gnu.org; Thu, 27 Apr 2023 05:47:24 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1682588837; bh=sf4zJOf3YOdDzOovifpUuRJ31LssX6tjLloL+7PNhV4=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=G4WhFv+eh3Jbhz61xuSnh6sPXc5K1HMCBLh+W4t2/Pe6PDBDS/zWKkBYVqEkyQ2Rs CnJP3UneFJizDfbNuAT6RAQxF94/I2CvxQRCZ5RRwXyuSifhvtfUJvs6B9QVqh4Wyk e4ONH1Gug5wAuuo5zltrSaVlhCkVxAKFbSexwXEs= Feedback-ID: mattiase@acm.or Original-Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se [188.150.165.235]) (authenticated bits=0) by mail36c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 33R9lEkS123048; Thu, 27 Apr 2023 09:47:16 +0000 In-Reply-To: X-Mailer: Apple Mail (2.3654.120.0.1.15) X-VADE-SPAMSTATE: clean X-VADE-SPAMSCORE: -100 X-VADE-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvhedrfeduiedgvddtucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecujffquffvqffrkfetpdfqfgfvpdfgpfggqdevhedtnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpegtggfuhfgjffevgffkfhfvofesthhqmhdthhdtvdenucfhrhhomhepofgrthhtihgrshcugfhnghguvghgnohrugcuoehmrghtthhirghsvgesrggtmhdrohhrgheqnecuggftrfgrthhtvghrnhepveekffdujefhkeehvdfgffeikefghfefvdekueffleegfeekueelhfejieefkefgnecukfhppedukeekrdduhedtrdduieehrddvfeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepudekkedrudehtddrudeihedrvdefhedphhgvlhhopehsmhhtphgtlhhivghnthdrrghpphhlvgdpmhgrihhlfhhrohhmpehmrghtthhirghsvgesrggtmhdrohhrghdpnhgspghrtghpthhtohepgedprhgtphhtthhopehmrghilhesuggrnhhivghlqdhmvghnughlvghrrdguvgdprhgtphhtthhopehphhhilhhiphhksehpohhsthgvohdrnh gvthdprhgtphhtthhopeeifedutdefseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepmhhonhhnihgvrhesihhr X-Origin-Country: SE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260711 Archived-At: 27 apr. 2023 kl. 08.37 skrev Daniel Mendler : > This behavior is not documented explicitly. However the docstring = states > that "Only the last argument is not altered, and need not be a list". Indeed. It's clear that this behaviour was never really intended, but = also that it was a natural consequence of most Lisp implementations. For = instance, Common Lisp specifies this behaviour but only did so after = errata. Although the utility of accepting dotted lists is very slight and = requiring proper list for all but the last argument would have made it = easier for us, this obviously needs to be a well-reasoned change if made = at all. I'll remove the troublesome compiler transform right away. > Due to symmetry reasons it is not far-fetched to assume that when > `nconc' can be used to turn a proper list into an improper list, that > the inverse works too. I don't think that's a valid assumption -- when the documentation says = that arguments are lists, then they should be proper lists. The = behaviour for improper lists needs to be specified explicitly, in = particular in this case when the function actually overwrites arbitrary = information in the input, not just a terminating nil. Thank you very much for finding this bug!