From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#11328: 24.1.50; Comment in `dired-copy-file-recursive' code Date: Tue, 24 Apr 2012 10:49:50 -0700 Message-ID: <9DC04CC6E710430F90675022247AF8C1@us.oracle.com> References: <0CC212AF2EA740A0B8FE5EEF91077A2D@us.oracle.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1335289825 3297 80.91.229.3 (24 Apr 2012 17:50:25 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 24 Apr 2012 17:50:25 +0000 (UTC) To: <11328@debbugs.gnu.org> Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Apr 24 19:50:24 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SMjsc-0002op-OY for geb-bug-gnu-emacs@m.gmane.org; Tue, 24 Apr 2012 19:50:22 +0200 Original-Received: from localhost ([::1]:47881 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SMjsc-00044D-39 for geb-bug-gnu-emacs@m.gmane.org; Tue, 24 Apr 2012 13:50:22 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:56429) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SMjsW-00043u-3l for bug-gnu-emacs@gnu.org; Tue, 24 Apr 2012 13:50:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SMjsU-0006u2-Co for bug-gnu-emacs@gnu.org; Tue, 24 Apr 2012 13:50:15 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:50013) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SMjsU-0006tt-9F for bug-gnu-emacs@gnu.org; Tue, 24 Apr 2012 13:50:14 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SMjtG-0003ST-11 for bug-gnu-emacs@gnu.org; Tue, 24 Apr 2012 13:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 24 Apr 2012 17:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11328 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11328-submit@debbugs.gnu.org id=B11328.133528985313279 (code B ref 11328); Tue, 24 Apr 2012 17:51:01 +0000 Original-Received: (at 11328) by debbugs.gnu.org; 24 Apr 2012 17:50:53 +0000 Original-Received: from localhost ([127.0.0.1]:51047 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SMjt6-0003S7-O9 for submit@debbugs.gnu.org; Tue, 24 Apr 2012 13:50:52 -0400 Original-Received: from rcsinet15.oracle.com ([148.87.113.117]:49169) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SMjt4-0003Rw-SY for 11328@debbugs.gnu.org; Tue, 24 Apr 2012 13:50:52 -0400 Original-Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by rcsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q3OHnuDE030023 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for <11328@debbugs.gnu.org>; Tue, 24 Apr 2012 17:49:57 GMT Original-Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q3OHntRR020106 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for <11328@debbugs.gnu.org>; Tue, 24 Apr 2012 17:49:56 GMT Original-Received: from abhmt107.oracle.com (abhmt107.oracle.com [141.146.116.59]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q3OHntcA006049 for <11328@debbugs.gnu.org>; Tue, 24 Apr 2012 12:49:55 -0500 Original-Received: from dradamslap1 (/10.159.223.238) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 24 Apr 2012 10:49:55 -0700 X-Mailer: Microsoft Office Outlook 11 Thread-Index: Ac0iQOAt/BRD/wxORmS0/5S+X00AdgAAJgHQ In-Reply-To: <0CC212AF2EA740A0B8FE5EEF91077A2D@us.oracle.com> X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:59458 Archived-At: Oh, and since there is no doc string it might be a good idea to use better parameter names. There is a reason that for `copy-file' and `make-symbolic-link' the parameter is called OK-IF-ALREADY-EXISTS and not simply OK-FLAG. (Same problem for `dired-copy-file'.) You can guess the meaning from OK-IF-ALREADY-EXISTS. You are not helping readers of the code if they need to examine it all closely to determine what a given parameter does. In that case, you might as well name the parameters X1, X2, X3, X4, X5, and X6. And it's generally a good idea to use the same parameter names when you just pass the arguments to another function and they have the same meaning. If you just pass PRESERVE-TIME to `copy-directory' and `copy-file', then use the same name they use: KEEP-TIME. (Or change all three and any other functions related so they use the same names.)