From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?iso-8859-1?Q?Jan_Dj=E4rv?= Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Re: About the :distant-foreground face attribute Date: Mon, 13 Jan 2014 22:29:59 +0100 Message-ID: <9BD01B88-AF13-44DD-8DBE-4598BAC136DD@swipnet.se> References: <87bnzo9cja.fsf@gnu.org> <59B7E7FC-48D0-4737-B1BB-FFAC5BA9E07A@swipnet.se> <874n5f3162.fsf@gnu.org> <83fvozf86g.fsf@gnu.org> <87r48javwe.fsf@gnu.org> <83bnzmfjxe.fsf@gnu.org> <52D3E689.6050902@dancol.org> <8E16225F-53EF-498A-AB35-66EB9B33B859@swipnet.se> <52D43360.6050605@dancol.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 (Mac OS X Mail 7.1 \(1827\)) Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1389648633 29718 80.91.229.3 (13 Jan 2014 21:30:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 13 Jan 2014 21:30:33 +0000 (UTC) Cc: Eli Zaretskii , Chong Yidong , emacs-devel To: Daniel Colascione Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jan 13 22:30:39 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1W2p5h-0002ra-M8 for ged-emacs-devel@m.gmane.org; Mon, 13 Jan 2014 22:30:37 +0100 Original-Received: from localhost ([::1]:45130 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2p5h-00051v-9k for ged-emacs-devel@m.gmane.org; Mon, 13 Jan 2014 16:30:37 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43583) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2p5V-0004zr-Qk for emacs-devel@gnu.org; Mon, 13 Jan 2014 16:30:32 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W2p5P-00068A-C3 for emacs-devel@gnu.org; Mon, 13 Jan 2014 16:30:25 -0500 Original-Received: from mailfe08.swip.net ([212.247.154.225]:38107 helo=swip.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2p5B-0005yf-UV; Mon, 13 Jan 2014 16:30:06 -0500 X-T2-Spam-Status: No, hits=0.0 required=5.0 Original-Received: from hosdjarv.se (account mj138573@tele2.se [46.59.42.57] verified) by mailfe08.swip.net (CommuniGate Pro SMTP 5.4.4) with ESMTPA id 469425173; Mon, 13 Jan 2014 22:30:00 +0100 In-Reply-To: <52D43360.6050605@dancol.org> X-Mailer: Apple Mail (2.1827) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 212.247.154.225 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:168316 Archived-At: Hello. 13 jan 2014 kl. 19:41 skrev Daniel Colascione : > On 01/13/2014 08:33 AM, Jan Dj=E4rv wrote: >> 13 jan 2014 kl. 14:13 skrev Daniel Colascione : >>> The patch uses the CIE L*A*B colorspace algorithm by default. >>=20 >> Do not change the defaults please. Reinstate the >> *_selection_fg_color. >> They are system defined and should be honored. >=20 > There are two sane defaults: the 24.3 behavior, where we always use = the system selection foreground and background, and my proposed = behavior, where we use the fontified foreground and automatically adjust = it so that it's legible. The current behavior is worse because it uses = the system selection foreground only sometimes and doesn't preserve = theme hues when possible. What theme hues? The default theme is not really a theme as selection = colors are taken from system settings. And this is correct IMHO, any = application that doesn't do so by default (i.e. no user configuration = has been set in the application) is seriously broken. If you talk about other themes, they can set :distant-foreground to a = real color of their choosing and not rely on some automatically = generated one which most probably don't fit the theme anyway. = Automatically generated colors are a crutch which should be avoided if = possible, certainly not recommended. Of course the 24.3 has been changed, that default is no longer valid due = to bug #15668 and it is pointless to use that as an argument unless you = mean that the bug fix should be reverted. Jan D.