all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* Re: master 8dc36cc53b: * src/lread.c (syms_of_lread): Drop unused capture group.
       [not found] ` <20221109105808.15704C0E4BC@vcs2.savannah.gnu.org>
@ 2022-11-09 12:19   ` Po Lu
  2022-11-10  9:40     ` Mattias Engdegård
  0 siblings, 1 reply; 2+ messages in thread
From: Po Lu @ 2022-11-09 12:19 UTC (permalink / raw)
  To: emacs-devel; +Cc: Mattias Engdegård

Mattias Engdegård <mattiase@acm.org> writes:

> branch: master
> commit 8dc36cc53b7c2b66ca06ca4db84209bc492ea665
> Author: Mattias Engdegård <mattiase@acm.org>
> Commit: Mattias Engdegård <mattiase@acm.org>
>
>     * src/lread.c (syms_of_lread): Drop unused capture group.
> ---
>  src/lread.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/lread.c b/src/lread.c
> index 957bc6895e..c28324dc35 100644
> --- a/src/lread.c
> +++ b/src/lread.c
> @@ -5620,7 +5620,8 @@ from the file, and matches them against this regular expression.
>  When the regular expression matches, the file is considered to be safe
>  to load.  */);
>    Vbytecomp_version_regexp
> -    = build_pure_c_string ("^;;;.\\(in Emacs version\\|bytecomp version FSF\\)");
> +    = build_pure_c_string
> +        ("^;;;.\\(?:in Emacs version\\|bytecomp version FSF\\)");

Isn't it not our style to put the only line of parameter to a function
call on a new line?  Here, I would split the string in two, like so,
instead:

  build_pure_c_string ("long string here"
  		       " next part of string here");



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: master 8dc36cc53b: * src/lread.c (syms_of_lread): Drop unused capture group.
  2022-11-09 12:19   ` master 8dc36cc53b: * src/lread.c (syms_of_lread): Drop unused capture group Po Lu
@ 2022-11-10  9:40     ` Mattias Engdegård
  0 siblings, 0 replies; 2+ messages in thread
From: Mattias Engdegård @ 2022-11-10  9:40 UTC (permalink / raw)
  To: Po Lu; +Cc: emacs-devel

9 nov. 2022 kl. 13.19 skrev Po Lu <luangruo@yahoo.com>:

> I would split the string in two, like so,
> instead:
> 
>  build_pure_c_string ("long string here"
>  		       " next part of string here");

Yes, that would be fine too. As so often when it comes to code layout, neither alternative dominates the other.




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-11-10  9:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <166799148774.22940.7210019393237115012@vcs2.savannah.gnu.org>
     [not found] ` <20221109105808.15704C0E4BC@vcs2.savannah.gnu.org>
2022-11-09 12:19   ` master 8dc36cc53b: * src/lread.c (syms_of_lread): Drop unused capture group Po Lu
2022-11-10  9:40     ` Mattias Engdegård

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.