From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#64329: 29.0.92; treesit/fill-paragraph syntax highlighting problem Date: Thu, 29 Jun 2023 11:17:26 -0700 Message-ID: <9B70253C-512B-463D-B04C-CC33D486FFE0@gmail.com> References: <3031A934-37EC-497D-8A48-ECE7FD703B31@gmail.com> <14493480-9226-4AB1-A313-E4E2D61AB0BD@gmail.com> <83r0puu9jq.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.600.7\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16420"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Troy Brown , 64329-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 29 20:18:34 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qEwDx-00043t-9C for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 29 Jun 2023 20:18:33 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qEwDU-0007yd-9l; Thu, 29 Jun 2023 14:18:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qEwDS-0007y4-LV for bug-gnu-emacs@gnu.org; Thu, 29 Jun 2023 14:18:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qEwDS-0001mq-Cj for bug-gnu-emacs@gnu.org; Thu, 29 Jun 2023 14:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qEwDS-0002Qv-0j for bug-gnu-emacs@gnu.org; Thu, 29 Jun 2023 14:18:02 -0400 Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Thu, 29 Jun 2023 18:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 64329 X-GNU-PR-Package: emacs Mail-Followup-To: 64329@debbugs.gnu.org, casouri@gmail.com, brownts@troybrown.dev Original-Received: via spool by 64329-done@debbugs.gnu.org id=D64329.16880626669328 (code D ref 64329); Thu, 29 Jun 2023 18:18:01 +0000 Original-Received: (at 64329-done) by debbugs.gnu.org; 29 Jun 2023 18:17:46 +0000 Original-Received: from localhost ([127.0.0.1]:53994 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qEwDC-0002QO-Hq for submit@debbugs.gnu.org; Thu, 29 Jun 2023 14:17:46 -0400 Original-Received: from mail-pl1-f180.google.com ([209.85.214.180]:59574) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qEwD9-0002Q7-St for 64329-done@debbugs.gnu.org; Thu, 29 Jun 2023 14:17:44 -0400 Original-Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1b8171718a1so8059615ad.2 for <64329-done@debbugs.gnu.org>; Thu, 29 Jun 2023 11:17:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688062658; x=1690654658; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Tma/Oq+zPAZ3R4fBHNqE8uY3a2xP+mmFWarg17yhv50=; b=ftC9Rntw+JLMW0rfM/1wYNyilLd1vBhUi/ceaMH//nVTEIyIUkFI271ZB4STBiuo6W sZfksEDg+gabqtLXSevlE6mZx6sVgwQyZ/7f54yB40JoxqiF88Wi+kxv5WF3zWrz1yiZ 2l2tYMmQk84gGvh0Y1Ks2r3Y3pbxwXC4yMH7mReiGyWQeuRbntU62d/FZGKNBn7qYXV0 dOaEUNH+zUHdJeETAt6xL4tZs4Gz6s8t7z6kHMPN4pG1AxzLU9MiQTi9vqumqwJFp/xd vRsXzGRpO0cWQYfha4OmIwvIJtUof0AQgD/oh/eGGkk/IwoiMDAKOmaupcM9kLmpYhEe 46OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688062658; x=1690654658; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Tma/Oq+zPAZ3R4fBHNqE8uY3a2xP+mmFWarg17yhv50=; b=TfIH4hB9MBtattVvSP1lP7gm5CTbuB2Ji7GgV0Y0tMgvv4w+SI8hAQJ5GWJg4VntsZ Be2qsoun+A0lSPmhdaCw0unDUxhNU4NxXf5a/ulePkBwD7yHsOqa7LD4HJ9orJWPK3Pv VJ6+HT7ySPvQwU1s1C2X1TM8XaUPDy0OUVJisoUKJOJBryvdxn2vQZh5zRCk85zIiweA euxqcL1ZRyNpJtWXnH/dh1QuGYVDT2hKqKZaBHAgOQsRnczhJ+Rrtm/3KI9N9UalvfJB gamrU95Bc+QJG1w9W/TAwwr9tdRJWwUJLS6E11KDju2wLf/VnfMMerKHhspfhBXh2vLh wsCw== X-Gm-Message-State: AC+VfDz0nWAJOmwaoDgyP2tMaAdL4r+2Ts52p03RDMpakIxvKNeWwT4B t13v0RQ6ugS8UMNLh6+zc9A= X-Google-Smtp-Source: ACHHUZ7HsdEM1mjfGNKD5CdvXBEFBQ88ae6nQY5YolsrHodM0KFE/OTzvRCYRgHZhj2Vrq2/5wxfeA== X-Received: by 2002:a17:902:bb89:b0:1ac:7345:f254 with SMTP id m9-20020a170902bb8900b001ac7345f254mr16332325pls.33.1688062657846; Thu, 29 Jun 2023 11:17:37 -0700 (PDT) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id b21-20020a170902d31500b001b85bd8fb3csm1102328plc.77.2023.06.29.11.17.36 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Jun 2023 11:17:37 -0700 (PDT) In-Reply-To: <83r0puu9jq.fsf@gnu.org> X-Mailer: Apple Mail (2.3731.600.7) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264287 Archived-At: > On Jun 28, 2023, at 10:22 PM, Eli Zaretskii wrote: >=20 >> From: Yuan Fu >> Date: Wed, 28 Jun 2023 17:17:14 -0700 >> Cc: 64329@debbugs.gnu.org, >> Eli Zaretskii >>=20 >> Prompted by this, I went over all the functions that calls = signal_after_change again, and found two other editfns.c functions that = are missing calls to treesit_record_change. Please see the attached = patches that follows the previous one. Sorry for the overlook. I believe = I=E2=80=99ve found all places that needs to call treesit_record_change = now. >>=20 >>> Please see the attached patch. Eli, is it more preferable to add a = subroutine in insdel.c that does what "for (i =3D 0; i < len; i++) *p++ = =3D tostr[I];=E2=80=9D does, plus calling treesit_record_change, and = make subst-char-in-region call that subroutine? (This way editfns.c = don=E2=80=99t need to include treesit.h and call treesit_record_change = itself.) >>=20 >> Since now there are three functions in editfns.c that needs to call = treesit_record_change, we might as well just include treesit.h and call = treesit_record_change directly. >=20 > Right. Ok, I've pushed the changes. Yuan=