Re: Links and visual-line-mode

[Carsten Dominik <carsten.dominik@gmail.com>]

On 2.6.2011, at 17:51, Nick Dokos wrote:

> Carsten Dominik <carsten.dominik@gmail.com> wrote:
> 
>>> Yes, with pop-up-windows set to nil, I can reproduce it too.
>>> The problem is that truncate-lines is set to t inside org-insert-link.
>> 
>> Yes, but only after the focus was switched to the *Org Link* buffer which is
>> shown in order to select a link.  truncate-lines is automatically buffer-local,
>> so it should not effect its value in other buffers.  Is truncate-lines modified after inserting a link????
>> 
> 
> Here's what I see with a minimal .emacs and a simple org file (both of them appended):
> 
> - emacs -Q -l minimal.emacs
> - check truncate-lines: it is nil in the foo.org buffer
> - TAB to expand the heading - I get a wrapped line as expected
> - go to the end, C-c C-l foo <RET> bar <RET>
> - by the time of the first <RET> I am back at the foo.org buffer and the line is truncated;
>  checking truncate-lines shows it to be t.

Thanks Nick.  Seems like Emacs is not sure in which
buffer it is at that moment, because it has not yet been displayed.
Could you please try to following paranoid patch?

Thanks.

- Carsten

diff --git a/lisp/org.el b/lisp/org.el
index 1ca03f4..b43a877 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -8889,7 +8889,8 @@ Use TAB to complete link prefixes, then RET for type-specific completion support
 		  (reverse org-stored-links) "\n"))))
       (let ((cw (selected-window)))
 	(select-window (get-buffer-window "*Org Links*" 'visible))
-	(setq truncate-lines t)
+	(with-current-buffer "*Org Links*"
+	  (set (make-local-variable 'truncate-lines) t))
 	(unless (pos-visible-in-window-p (point-max))
 	  (org-fit-window-to-buffer))
 	(and (window-live-p cw) (select-window cw)))



> 
> Nick
> 
> GNU Emacs 24.0.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.22.0) of 2011-04-13
> Org-mode version 7.5 (baseline.261.g3433)
> 
> minimal.emacs:
> --8<---------------cut here---------------start------------->8---
> ;;; -*- mode: emacs-lisp -*-
> ;;; constant part
> (add-to-list 'load-path (expand-file-name "~/src/emacs/org/org-mode/lisp"))
> (add-to-list 'auto-mode-alist '("\\.\\(org\\|org_archive\\|txt\\)$" . org-mode))
> (require 'org-install)
> (global-set-key "\C-cl" 'org-store-link)
> (global-set-key "\C-ca" 'org-agenda)
> 
> (setq org-startup-truncated nil)
> (setq pop-up-windows nil)
> (setq-default truncate-lines nil)
> (find-file "~/src/org/visual/scott-randby/foo.org")
> (visual-line-mode 1)
> --8<---------------cut here---------------end--------------->8---
> 
> 
> foo.org:
> --8<---------------cut here---------------start------------->8---
> 
> * foo
> 
> [[foo][bar]]
> bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar 
> 
> [[foo][bar]] [[foo][bar]]
> --8<---------------cut here---------------end--------------->8---
> 
>