Automatically checking parentheses before a global save not working.

Automatically checking parentheses before a global save not working.

[Elena]

Hello,

I've written a function to check parentheses of Lisp buffers during a
global save - after being added to `before-save-hook' - so that
whenever it spots an unbalanced parentheses, it offers the user a
chance to fix it. However, it seems I can't switch to the offending
buffer. Maybe I just don't understand the way `condition-case' works.

Here is my code:

(defun fix-parens-or-save-anyway ()
	"Check for unbalanced parentheses before saving. To be used with
`before-save-hook'.

If parentheses are balanced, do nothing. Otherwise let the user know
and ask for confirmation before saving. If user confirms, do nothing;
otherwise switch to such buffer and let the user fix the error.
"
	(condition-case nil
		(check-parens)
		(error
		 (unless (yes-or-no-p (format "%s: Unbalanced parentheses. Save
anyway?" (buffer-name)))
			 (switch-to-buffer (buffer-name))
			 (check-parens)))))

(defun my-emacs-lisp-save-hook()
	(add-hook 'before-save-hook
			  'fix-parens-or-save-anyway
			  nil ; Prepend this hook (default).
			  t ; This is a local hook.
			  ))

(add-hook 'emacs-lisp-mode-hook 'my-emacs-lisp-save-hook)

Thanks for your help.

Re: Automatically checking parentheses before a global save not working.

[Uday S Reddy]

Elena wrote:
> On 1 Lug, 18:16, Andreas Politz <poli...@fh-trier.de> wrote:
>>>                     (switch-to-buffer (buffer-name))
>> There is no user interaction at this point.
> 
> What do you mean, please? Can't I call `switch-to-buffer' there?
> However, `yes-or-no-p' (which interacts with the user) works, and the
> buffer to fix is being correctly identified by name.

All that is fine.  But you can't expect to be able to edit the buffer in the 
midst of a save-buffer action.  The best thing to would be to signal an error 
again, so that the save-buffer is aborted.

> 
> If I can't switch buffer right away, maybe an alternative and safe
> approach would be to set a delayed switch, which would run after
> termination of `condition-case'.
> 
>> Also, I suppose running the hook is wrapped in some
>> current-buffer-saving-macro.

Andreas is wondering if save-buffer calls the before-save-hook inside a 
save-current-buffer macro, so that save-buffer finishes in the same buffer it 
started.  If so, running switch-to-buffer in the middle of the hook will have 
no effect.

You might try printing an error message, e.g.,

   (error "Unbalanced parentheses in %s" (current-buffer))

Cheers,
Uday

Re: Automatically checking parentheses before a global save not working.

[Elena]

On 1 Lug, 19:16, Andreas Politz <poli...@fh-trier.de> wrote:
> (condition-case nil
>     (check-parens)
>   (error
>    (when (yes-or-no-p (format "Fix parens in buffer %s ?" (buffer-name)))
>      (switch-to-buffer (current-buffer))
>      (recursive-edit) ;;Edit and press C-M-c
>      (check-parens))))

Thanks Andreas. This works even better than what I was trying to
achieve (I would have just aborted saving before leaving the user into
the offending buffer).

Re: Automatically checking parentheses before a global save not working.

[Johan Bockgård]

Uday S Reddy <uDOTsDOTreddy@cs.bham.ac.uk> writes:

> Andreas is wondering if save-buffer calls the before-save-hook inside
> a save-current-buffer macro, so that save-buffer finishes in the same
> buffer it started.  If so, running switch-to-buffer in the middle of
> the hook will have no effect.

Yes it will.