From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#45502: [PATCH] Prettier key bindings in NS menu entries Date: Tue, 29 Dec 2020 23:53:59 +0100 Message-ID: <99CD03DA-DF1F-4C2C-A2FA-DFD7DF3B2750@acm.org> References: <02937096-EAF5-4B74-A1C7-CCE6E64C67E3@acm.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.17\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12814"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 45502@debbugs.gnu.org, Daniel =?UTF-8?Q?Mart=C3=ADn?= To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 29 23:55:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kuNtX-0003EZ-W2 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 29 Dec 2020 23:55:12 +0100 Original-Received: from localhost ([::1]:36336 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kuNtX-0006vU-1D for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 29 Dec 2020 17:55:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51238) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kuNtO-0006tB-R7 for bug-gnu-emacs@gnu.org; Tue, 29 Dec 2020 17:55:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57170) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kuNtO-0001lP-K8 for bug-gnu-emacs@gnu.org; Tue, 29 Dec 2020 17:55:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kuNtO-0007hQ-J5 for bug-gnu-emacs@gnu.org; Tue, 29 Dec 2020 17:55:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 29 Dec 2020 22:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45502 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 45502-submit@debbugs.gnu.org id=B45502.160928245829491 (code B ref 45502); Tue, 29 Dec 2020 22:55:02 +0000 Original-Received: (at 45502) by debbugs.gnu.org; 29 Dec 2020 22:54:18 +0000 Original-Received: from localhost ([127.0.0.1]:40478 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kuNsZ-0007fQ-Ry for submit@debbugs.gnu.org; Tue, 29 Dec 2020 17:54:18 -0500 Original-Received: from mail1479c50.megamailservers.eu ([91.136.14.79]:44352 helo=mail118c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kuNsW-0007f8-NQ for 45502@debbugs.gnu.org; Tue, 29 Dec 2020 17:54:10 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1609282442; bh=KrSnJlKjBfue2aWONnEEci2UY58LLz/3Hwuuab5co0c=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=oJGlRD8HoxUle0ZZL/cOHyR3Kx37H1GmqF95MVWhc9AnNQNP2VRgnf1S7Ri/tqIZ5 HHnBV+47UvO1zbAMpHQxnUxU2NeCWByhU/SO2QDbsOXiz9nAg1JJ9TSon7vx+XBE4N ROXF6tVXzocYN6k9dPwshpC2tty4+JfJ9ywf6nvw= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.0.4] (c188-150-171-71.bredband.comhem.se [188.150.171.71]) (authenticated bits=0) by mail118c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 0BTMrxla012881; Tue, 29 Dec 2020 22:54:01 +0000 In-Reply-To: X-Mailer: Apple Mail (2.3445.104.17) X-CTCH-RefID: str=0001.0A742F19.5FEBB38A.0003, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=HYRqsRM8 c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=IkcTkHD0fZMA:10 a=M51BFTxLslgA:10 a=hIj89exaAAAA:8 a=vQQvgaqYLQnsI-mX4AsA:9 a=QEXdDO2ut3YA:10 a=lS9wXHQM5UdnNJ4u63Ry:22 X-Origin-Country: SE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:196986 Archived-At: 29 dec. 2020 kl. 22.24 skrev Alan Third : > I've pushed a small change. I also set the alloc'd objects to > autorelease. We need to do that because when they're assigned to the > NSMenuItem it will retain them, and because we alloc'd them we already > have them retained once. >=20 > At least I hope that's right. For some reason I've found the > retain/release cycle really hard to understand, but I think I'm > getting there now. Thanks! Is this the standard way of doing it? The objects that you = marked autorelease (tab and pstyle) are only used for the extent of that = method; I take it you prefer autorelease to sending them 'release' at = the end of the method? Presumably 'atitle' should be sent autorelease (or release) as well? > I have no opinion on this, really. Although that is some ugly code! ;) Oh yes, it should at least be table-driven in some way.=20 > I think that might be confusing. It doesn't matter with most macOS > apps because they don't differentiate between shortcuts with upper and > lower case characters, but we do, and I feel as a seasoned Emacs user > I'd see C-A and think that was actually C-S-a when it might be C-a. Agreed. If we were to follow the macOS conventions fully then it would = make sense to use =E2=8C=98K for M-k (if Command is Meta), but otherwise = it's more likely to be confusing.