all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Bob Nnamtrop <bobnnamtrop@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: mouse-yank-at-point in Comint modes
Date: Tue, 1 Dec 2009 17:30:42 -0700	[thread overview]
Message-ID: <99750f710912011630t7a6e5edaifc980498d2ddaaca@mail.gmail.com> (raw)
In-Reply-To: <jwvbpiibflk.fsf-monnier+emacs@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1470 bytes --]

On Tue, Dec 1, 2009 at 1:34 PM, Stefan Monnier <monnier@iro.umontreal.ca>wrote:

> > --- emacs-23.0.93/lisp/comint.el    2009-01-06 13:29:03.000000000 -0700
> > +++ emacs/lisp/comint.el    2009-05-14 17:31:05.000000000 -0600
> > @@ -816,7 +816,7 @@
> >  If there is no previous input at point, run the command specified
> >  by the global keymap (usually `mouse-yank-at-point')."
> >    (interactive "e")
> > -  (mouse-set-point event)
> > +  (unless mouse-yank-at-point (mouse-set-point event))
> >    (let ((pos (posn-point (event-end event)))
> >      field input)
> >      (with-selected-window (posn-window (event-end event))
>
> Thanks.  This has been fixed by never calling mouse-set-point here.
>
> >  (defun field-at-pos (pos)
> >    "Return the field at position POS, taking stickiness etc into
> account."
> > -  (let ((raw-field (get-char-property (field-beginning pos) 'field)))
> > -    (if (eq raw-field 'boundary)
> > -    (get-char-property (1- (field-end pos)) 'field)
> > -      raw-field)))
> > +  (if (< pos (field-end pos))
> > +      (let ((raw-field (get-char-property (field-beginning pos)
> 'field)))
> > +        (if (eq raw-field 'boundary)
> > +            (get-char-property (1- (field-end pos)) 'field)
> > +          raw-field))))
>
> I'm not sure fixing it in field-at-pos is right, so I fixed it in
> a similar way in cominut-insert-input.  Thank you for your help,
>
>
Thanks for the fixes.  I just tried them and they work fine.

Bob

[-- Attachment #2: Type: text/html, Size: 2034 bytes --]

  reply	other threads:[~2009-12-02  0:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-14 23:59 mouse-yank-at-point in Comint modes Bob Nnamtrop
2009-12-01 20:34 ` Stefan Monnier
2009-12-02  0:30   ` Bob Nnamtrop [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-09-11 21:37 Bob
2006-12-07  1:16 JD Smith
2006-12-09 18:22 ` Chong Yidong
2007-01-24 18:32 ` Bob Portmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=99750f710912011630t7a6e5edaifc980498d2ddaaca@mail.gmail.com \
    --to=bobnnamtrop@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.