all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Bob Nnamtrop <bobnnamtrop@gmail.com>
To: emacs-devel@gnu.org
Subject: mouse-yank-at-point in Comint modes
Date: Thu, 14 May 2009 17:59:45 -0600	[thread overview]
Message-ID: <99750f710905141659j7b4e30e6idbceb8dab8bd9ab7@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 2140 bytes --]

Comint mode does not honor mouse-yank-at-point.  This has been mentioned in
2006 and 2008 in these posts:

http://www.nabble.com/mouse-yank-at-point-in-Comint-modes-to19445336.html

http://www.nabble.com/mouse-yank-at-point-in-Comint-modes-to7731895.html

Here is an updated patch of the simple one-line fix (which works great in my
usage).  Could it get applied before the release?

--- emacs-23.0.93/lisp/comint.el    2009-01-06 13:29:03.000000000 -0700
+++ emacs/lisp/comint.el    2009-05-14 17:31:05.000000000 -0600
@@ -816,7 +816,7 @@
 If there is no previous input at point, run the command specified
 by the global keymap (usually `mouse-yank-at-point')."
   (interactive "e")
-  (mouse-set-point event)
+  (unless mouse-yank-at-point (mouse-set-point event))
   (let ((pos (posn-point (event-end event)))
     field input)
     (with-selected-window (posn-window (event-end event))

<http://www.nabble.com/mouse-yank-at-point-in-Comint-modes-td7731895.html>Here
is another simple patch which fixes another annoyance.  When the mouse is
over an old input in comint mode, that input is highlighted and a mouse-2
click will yank it to the command line.  This is fine except that it still
happens if the mouse is beyond the end of the old input and the old input is
not highlighted.  This simple patch fixes this.  Could it also get applied
before the release?

diff -r -u emacs-23.0.93/lisp/subr.el emacs/lisp/subr.el
--- emacs-23.0.93/lisp/subr.el    2009-04-28 22:45:17.000000000 -0600
+++ emacs/lisp/subr.el    2009-05-14 17:52:33.000000000 -0600
@@ -2319,10 +2319,11 @@

 (defun field-at-pos (pos)
   "Return the field at position POS, taking stickiness etc into account."
-  (let ((raw-field (get-char-property (field-beginning pos) 'field)))
-    (if (eq raw-field 'boundary)
-    (get-char-property (1- (field-end pos)) 'field)
-      raw-field)))
+  (if (< pos (field-end pos))
+      (let ((raw-field (get-char-property (field-beginning pos) 'field)))
+        (if (eq raw-field 'boundary)
+            (get-char-property (1- (field-end pos)) 'field)
+          raw-field))))



 ;;;; Support for yanking and text properties.

[-- Attachment #2: Type: text/html, Size: 2562 bytes --]

             reply	other threads:[~2009-05-14 23:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-14 23:59 Bob Nnamtrop [this message]
2009-12-01 20:34 ` mouse-yank-at-point in Comint modes Stefan Monnier
2009-12-02  0:30   ` Bob Nnamtrop
  -- strict thread matches above, loose matches on Subject: below --
2008-09-11 21:37 Bob
2006-12-07  1:16 JD Smith
2006-12-09 18:22 ` Chong Yidong
2007-01-24 18:32 ` Bob Portmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=99750f710905141659j7b4e30e6idbceb8dab8bd9ab7@mail.gmail.com \
    --to=bobnnamtrop@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.