From: Dmitry Gutov <dgutov@yandex.ru>
To: npostavs@users.sourceforge.net, Paul Pogonyshev <pogonyshev@gmail.com>
Cc: 23648@debbugs.gnu.org
Subject: bug#23648: [PATCH] `defun-declarations-alist' can be unintentionally modified
Date: Mon, 18 Jul 2016 22:17:56 +0300 [thread overview]
Message-ID: <995c1f7f-a0fa-a0bf-60f5-41a0a201fe75@yandex.ru> (raw)
In-Reply-To: <87twfnd50u.fsf@users.sourceforge.net>
On 07/18/2016 06:00 AM, npostavs@users.sourceforge.net wrote:
>> Here `delete-dups' destructively modifies a list that includes
>> `defun-declarations-alist' as its tail verbatim, not as a copy.
>> Attached patch should fix that.
>
> I agree with analysis and patch here.
I like the patch as well. Maybe it would be better to use
cl-remove-duplicates with nconc instead (the use of nil is a little
non-obvious), but that would require having cl-lib loaded at runtime,
and elisp-mode depending on it.
In any case, the proposed patch looks safe.
prev parent reply other threads:[~2016-07-18 19:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-29 14:11 bug#23648: [PATCH] `defun-declarations-alist' can be unintentionally modified Paul Pogonyshev
2016-07-18 3:00 ` npostavs
2016-07-18 14:33 ` Eli Zaretskii
2016-07-18 15:53 ` Noam Postavsky
2016-07-18 18:16 ` Eli Zaretskii
2016-07-18 18:58 ` Noam Postavsky
2016-07-18 19:08 ` Eli Zaretskii
2016-07-18 21:28 ` Michael Heerdegen
2016-07-19 2:40 ` Eli Zaretskii
2016-07-21 1:09 ` npostavs
2016-07-21 14:22 ` Eli Zaretskii
2016-07-21 21:27 ` Noam Postavsky
2016-07-23 8:54 ` Eli Zaretskii
2016-07-23 14:18 ` npostavs
2016-07-24 17:07 ` Paul Pogonyshev
2016-07-24 17:31 ` Eli Zaretskii
2016-07-18 19:17 ` Dmitry Gutov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=995c1f7f-a0fa-a0bf-60f5-41a0a201fe75@yandex.ru \
--to=dgutov@yandex.ru \
--cc=23648@debbugs.gnu.org \
--cc=npostavs@users.sourceforge.net \
--cc=pogonyshev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.