From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#52507: [PATCH] Option for vc-delete-file to keep file on disk Date: Thu, 16 Dec 2021 14:27:00 +0300 Message-ID: <992c1811-d85f-0d54-6e5c-d19da41bc996@yandex.ru> References: <20211215095324.18195-1-ashwin@ashwink.com.np> <85pmpxvx8z.fsf@ashwink.com.np> <817fe109-8afe-62fc-e80e-f3d0ef4e4889@yandex.ru> <85lf0kdc3v.fsf@ashwink.com.np> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4234"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 Cc: 52507@debbugs.gnu.org To: Ashwin Kafle Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 16 12:30:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mxoxe-0000qq-TB for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 16 Dec 2021 12:30:10 +0100 Original-Received: from localhost ([::1]:54512 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mxoxd-00042L-SE for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 16 Dec 2021 06:30:09 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:33772) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mxowY-0002ez-EN for bug-gnu-emacs@gnu.org; Thu, 16 Dec 2021 06:29:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51537) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mxowY-0004yN-5d for bug-gnu-emacs@gnu.org; Thu, 16 Dec 2021 06:29:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mxowX-0001i1-UV for bug-gnu-emacs@gnu.org; Thu, 16 Dec 2021 06:29:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Dec 2021 11:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52507 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 52507-submit@debbugs.gnu.org id=B52507.16396540886502 (code B ref 52507); Thu, 16 Dec 2021 11:29:01 +0000 Original-Received: (at 52507) by debbugs.gnu.org; 16 Dec 2021 11:28:08 +0000 Original-Received: from localhost ([127.0.0.1]:34850 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxovg-0001go-BD for submit@debbugs.gnu.org; Thu, 16 Dec 2021 06:28:08 -0500 Original-Received: from mail-lj1-f174.google.com ([209.85.208.174]:37852) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxovd-0001gD-5O for 52507@debbugs.gnu.org; Thu, 16 Dec 2021 06:28:07 -0500 Original-Received: by mail-lj1-f174.google.com with SMTP id k2so38001201lji.4 for <52507@debbugs.gnu.org>; Thu, 16 Dec 2021 03:28:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=FiieLnelA/DLExoU75i2vlx1DPUpObEwo+EMtrM9hIY=; b=aL80yW174fTL/P+najP6t9zSEg5CLRoCJwuBo9oWJRWFIy6VnVWSu9RFgFnNs3PP++ nk1YnCmAB5D1urfJ/pXpkgfkZsi9oJ1euPWQ/iaMFEDnjlXffhb0ob1TaPCY98FlglJ6 8+apThuSsoy7jsFw1GJ4Ck4UoI8K6BMHO33S9VLCyYkEAq5dHjebtCe0cnKucgtkP0Ng ultLLWBcG5Hjh4L1XaL+kZwdJmggTH2Cu38yp5EzOgpQgobrFS4rYvWS2rKpyvvk0dXU fiPXUQK7Da0dL9SxF9vQB9WJmT+9iqLW202xak53BVX6VCKmTLvTLOZDauA6xz6FArWz yegw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=FiieLnelA/DLExoU75i2vlx1DPUpObEwo+EMtrM9hIY=; b=Hd8OgfecKBq9ptTfUYy9gL3kqj49+NM8bS9Sup4UoOcnkbqMFa69jbpz39PY2gfQ+e 6om9I0m4wS6whC4Ru3ecelTf9fS7jxbeRpGPPNJ7Hu+Zqcnp5dSDgrVDDfz9C0/3LpXU eMUklf9QOGppVHr8sV8BjTx/x0PWozJSsxi6cyg+/VSiW/uQ+SlNVpab/3QPYIXpE0oG 03EyaK7J1mNpZ3k+XXJyFStXQ6yjgd+7E6I8p8UAUIeyR7tcmCM9Tj1Mj+w+lhn055IM pDwFuUwk4tQ5v8aA/ZaH+aE+J2FovEsnG6E7FtblsH1BPFIzWgEttiW5wFYq0d0Ju7p7 lkeQ== X-Gm-Message-State: AOAM533hJfei6KdhqeAOYroZWvyX8FJlWhF00TTm/6HvOIPZqXlbsMMY Orcm/xrvVGPVG0LKjORzyJHZl4qaiWT1Fg== X-Google-Smtp-Source: ABdhPJyFhvMqfOUI6UT8UMgZo0RTkA9vHT/2q3TmKUuJx/cTWG8nrpY9VzBxZR7P4yNLyOBzyHuRTA== X-Received: by 2002:a05:651c:b0e:: with SMTP id b14mr14924736ljr.38.1639654079136; Thu, 16 Dec 2021 03:27:59 -0800 (PST) Original-Received: from [192.168.0.103] ([5.18.233.185]) by smtp.googlemail.com with ESMTPSA id i17sm821489lfe.281.2021.12.16.03.27.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Dec 2021 03:27:58 -0800 (PST) In-Reply-To: <85lf0kdc3v.fsf@ashwink.com.np> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:222481 Archived-At: On 16.12.2021 14:26, Ashwin Kafle wrote: > Dmitry Gutov writes: > >> On 16.12.2021 10:12, Ashwin Kafle wrote: >>> But this would mean that every vc-backend will have to be changed, >>> immediately. >> >> Not really: since the arg is optional, we can make sure to only add it >> when it's non-nil, and otherwise call the backends with 1 argument. > > But then the user will get error about wrong number of arguments if the > backend doesn't support it. That's better than having the file deleted, I think. And our implementation can catch this particular error and show a more humane message, too. >> >>> Also, having every vc-backend accept and check keep-on-disk will result >>> on a lot of duplicate code that can simply be avoided. >> >> That's a valid argument, I suppose. Depends on whether many other >> backends (VCSes) know how to delete files without deleting them on >> disk. >> >> OTOH, it would be handy to let those that don't declare explicitly >> their inability to do that (by not supporting the second argument). > > I think it would be better to check if the file exists after calling vc > backends. If it doesn't and keep-files is non-nil, we can restore from the > backup(which is always happening). Couldn't backups be disabled?