From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.devel Subject: Re: Scan of regexp mistakes Date: Tue, 5 Mar 2019 17:12:41 +0100 Message-ID: <991CBED5-BD8E-4120-AB0A-57E371B97854@acm.org> References: <20190305112504.D97DD1EC@emma.svaha.wsnyder.org> <9d00360ef83ad72c6c3fe3457f2d3ab1.squirrel@mail.wsnyder.org> Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="206248"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Paul Eggert , emacs-devel@gnu.org To: Wilson Snyder Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 05 17:13:30 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h1Ch8-000rXJ-EK for ged-emacs-devel@m.gmane.org; Tue, 05 Mar 2019 17:13:30 +0100 Original-Received: from localhost ([127.0.0.1]:45193 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1Ch7-0001Vm-DN for ged-emacs-devel@m.gmane.org; Tue, 05 Mar 2019 11:13:29 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45237) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1Cgu-0001Ro-42 for emacs-devel@gnu.org; Tue, 05 Mar 2019 11:13:21 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h1Cgn-0004FK-Du for emacs-devel@gnu.org; Tue, 05 Mar 2019 11:13:11 -0500 Original-Received: from mail226c50.megamailservers.eu ([91.136.10.236]:37938 helo=mail36c50.megamailservers.eu) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h1Cgj-0003uc-K1 for emacs-devel@gnu.org; Tue, 05 Mar 2019 11:13:06 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1551802364; bh=PZgKIvjFel5Rkqfqu/7mQtZSnACHou+rBSpIYewb/ps=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=W2QZZK+CFY9KeE35mChN43sqLYhOUzEkFNJl1ACeoV2GbJEL5R5djY69Kl10IcllB kuNPn1TJx1zOWnQX0aYIrnaxX2i1rZ/sW+V14Ct16+U8JuCaKKgwgRuwXlubO9hy6Q 1Zo3QoaAUQ1Yc/cxr62OxPI0uisH08X11OFZcqKI= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.0.4] (c83-251-8-17.bredband.comhem.se [83.251.8.17]) (authenticated bits=0) by mail36c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x25GCfcj014486; Tue, 5 Mar 2019 16:12:43 +0000 X-Priority: 3 (Normal) In-Reply-To: <9d00360ef83ad72c6c3fe3457f2d3ab1.squirrel@mail.wsnyder.org> X-Mailer: Apple Mail (2.3445.102.3) X-CTCH-RefID: str=0001.0A0B0208.5C7E9FFC.0042, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=XOQetzpE c=1 sm=1 tr=0 a=NAHmi3I8mP0S/Y8gRKeQyA==:117 a=NAHmi3I8mP0S/Y8gRKeQyA==:17 a=kj9zAlcOel0A:10 a=mSlQYClzAAAA:8 a=RZvdro4uZuK9oG-wU9gA:9 a=CjuIK1q_8ugA:10 a=9FG54FvgbEs2wXAPWhWi:22 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] X-Received-From: 91.136.10.236 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:233850 Archived-At: 5 mars 2019 kl. 16.35 skrev Wilson Snyder : >=20 > Paul et al, thanks for this cleanup: >=20 >> * commit 3c94c7bc02fcacb4a101188dddb0c44d53444178 >> Author: Paul Eggert >> Fix regular-expression glitches and typos >=20 > This though failed the verilog-mode.el internal tests due to this: >=20 >> - = "\\s-*\\.\\(\\([a-zA-Z0-9`_$+@^.*?|---]\\|[][]\\|\\\\[()|]\\)+\\)\\s-*(\\(= .*\\))\\s-*\\(,\\|)\\s-*;\\)") >> + = "\\s-*\\.\\(\\([-a-zA-Z0-9`_$+@^.*?]\\|[][]\\|\\\\[()|]\\)+\\)\\s-*(\\(.*\= \))\\s-*\\(,\\|)\\s-*;\\)") >=20 > Which removed | from the character class. I committed a fix for this, = but > you may want to check the other files patched. -(defconst verilog-coverpoint-re = "\\w+\\s-*:\\s-*\\(coverpoint\\|cross\\constraint\\)" ) +(defconst verilog-coverpoint-re = "\\w+\\s*:\\s*\\(coverpoint\\|cross\\|constraint\\)") I don't think "\\s*" matches anything, since * is not a syntax class = character. The regexp engine doesn't complain, but it probably should. = What do you want it to match?