From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.devel Subject: Re: code review request for saveplace with dired buffer Date: Mon, 10 Jun 2013 12:35:27 -0400 Message-ID: <98mwqx9b5c.fsf@fencepost.gnu.org> References: <87ppvy4e0m.fsf@kanis.fr> <87bo7f70k5.fsf@kanis.fr> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1370882147 17875 80.91.229.3 (10 Jun 2013 16:35:47 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 10 Jun 2013 16:35:47 +0000 (UTC) Cc: kfogel@red-bean.com, Stefan Monnier , Emacs Development List To: Ivan Kanis Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 10 18:35:47 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Um54N-0000Lf-Ku for ged-emacs-devel@m.gmane.org; Mon, 10 Jun 2013 18:35:47 +0200 Original-Received: from localhost ([::1]:33131 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Um54N-0006fX-0x for ged-emacs-devel@m.gmane.org; Mon, 10 Jun 2013 12:35:47 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40309) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Um54G-0006ey-G5 for emacs-devel@gnu.org; Mon, 10 Jun 2013 12:35:42 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Um545-0001xs-J4 for emacs-devel@gnu.org; Mon, 10 Jun 2013 12:35:40 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33556) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Um545-0001xo-DN for emacs-devel@gnu.org; Mon, 10 Jun 2013 12:35:29 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Um543-0006AG-N7; Mon, 10 Jun 2013 12:35:27 -0400 X-Spook: MIT-LL passwd Ceridian Compsec Aladdin JUWTF jihad infowar X-Ran: w:*3se>;y5YjUV#Pw&BhPk)hp(&L0az,ztIS.hG:Oc524V%#s=V92yTpUZe/^(Hb"Zq (Ivan Kanis's message of "Sun, 09 Jun 2013 17:42:34 +0200") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:160316 Archived-At: Ivan Kanis wrote: > +2013-06-99 Ivan Kanis > + Add support for dired in saveplace. > + * dired.el (dired-initial-position-hook): New variable. Add blank line before "Add support". > + (save-place-position-dired-cursor): Move cursor in dired from previous position. You can simply say "New function". "New function to move..." if you prefer. As has been pointed out, "point" is better than "cursor", in function names as well as doc. > +(defcustom dired-initial-position-hook nil > + "This hook is used to position the cursor position." > + :group 'dired > + :type 'hook) Add :version "24.4". I'd find a comment in the doc "Run by the function `dired-initial-position'." helpful. And likewise in the doc of `dired-initial-position': "Runs the hook `dired-initial-position-hook'."