From: Glenn Morris <rgm@gnu.org>
To: Ivan Kanis <ivan@kanis.fr>
Cc: kfogel@red-bean.com, Stefan Monnier <monnier@IRO.UMontreal.CA>,
Emacs Development List <emacs-devel@gnu.org>
Subject: Re: code review request for saveplace with dired buffer
Date: Mon, 10 Jun 2013 12:35:27 -0400 [thread overview]
Message-ID: <98mwqx9b5c.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <87bo7f70k5.fsf@kanis.fr> (Ivan Kanis's message of "Sun, 09 Jun 2013 17:42:34 +0200")
Ivan Kanis wrote:
> +2013-06-99 Ivan Kanis <ivan@kanis.fr>
> + Add support for dired in saveplace.
> + * dired.el (dired-initial-position-hook): New variable.
Add blank line before "Add support".
> + (save-place-position-dired-cursor): Move cursor in dired from previous position.
You can simply say "New function". "New function to move..." if you prefer.
As has been pointed out, "point" is better than "cursor", in function
names as well as doc.
> +(defcustom dired-initial-position-hook nil
> + "This hook is used to position the cursor position."
> + :group 'dired
> + :type 'hook)
Add :version "24.4".
I'd find a comment in the doc "Run by the function `dired-initial-position'."
helpful. And likewise in the doc of `dired-initial-position': "Runs the
hook `dired-initial-position-hook'."
prev parent reply other threads:[~2013-06-10 16:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-07 6:43 code review request for saveplace with dired buffer Ivan Kanis
2013-06-07 15:59 ` Karl Fogel
2013-06-07 17:25 ` Glenn Morris
2013-06-07 20:08 ` Drew Adams
2013-06-07 22:20 ` Karl Fogel
2013-06-08 5:09 ` Drew Adams
2013-06-07 19:12 ` Stefan Monnier
2013-06-09 15:42 ` Ivan Kanis
2013-06-09 16:20 ` Karl Fogel
2013-06-10 7:42 ` Ivan Kanis
2013-06-10 14:00 ` Karl Fogel
2013-06-10 16:35 ` Glenn Morris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98mwqx9b5c.fsf@fencepost.gnu.org \
--to=rgm@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=ivan@kanis.fr \
--cc=kfogel@red-bean.com \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.