From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Glenn Morris <rgm@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: master 72ec233: Ignore pending_signals when checking for quits.
Date: Mon, 25 Feb 2019 17:05:20 -0500
Message-ID: <98bm2z7cdb.fsf@fencepost.gnu.org>
References: <20190224215115.3364.94205@vcs0.savannah.gnu.org>
	<20190224215116.2B65D209A5@vcs0.savannah.gnu.org>
Mime-Version: 1.0
Content-Type: text/plain
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="225420"; mail-complaints-to="usenet@blaine.gmane.org"
User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/)
Cc: Philipp Stephani <phst@google.com>
To: emacs-devel@gnu.org
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 25 23:05:29 2019
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1gyONN-000wW0-4K
	for ged-emacs-devel@m.gmane.org; Mon, 25 Feb 2019 23:05:29 +0100
Original-Received: from localhost ([127.0.0.1]:44846 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1gyONM-0001wT-1w
	for ged-emacs-devel@m.gmane.org; Mon, 25 Feb 2019 17:05:28 -0500
Original-Received: from eggs.gnu.org ([209.51.188.92]:45621)
	by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <rgm@gnu.org>)
	id 1gyONG-0001wM-DQ
	for emacs-devel@gnu.org; Mon, 25 Feb 2019 17:05:23 -0500
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:47762)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <rgm@gnu.org>)
	id 1gyONF-0002rd-Ed; Mon, 25 Feb 2019 17:05:22 -0500
Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.82)
	(envelope-from <rgm@gnu.org>)
	id 1gyONE-0007Gj-9h; Mon, 25 Feb 2019 17:05:20 -0500
X-Spook: bullion Sinaloa UFO Abu Ghraib Rubin Becker Gulf
X-Ran: L9Nk[kO-rY;b_al/K~Wo<8f!1yG6lkF;=hQn7W2|QF%xX/)Vx{.)p#U8w$U<Oj(No~[qvl
X-Hue: red
X-Attribution: GM
In-Reply-To: <20190224215116.2B65D209A5@vcs0.savannah.gnu.org> (Philipp
	Stephani's message of "Sun, 24 Feb 2019 16:51:15 -0500 (EST)")
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel/>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:233616
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/233616>


> branch: master
> commit 72ec233f2a1b8a6a9574e61588d0467caf41755c
[...]
>     Ignore pending_signals when checking for quits.

Hi,

This causes a test failure on hydra.nixos.org, and also for me on RHEL 7.6:

Ref: https://hydra.nixos.org/build/89511758

  data/emacs-module/mod-test.c:32:22: fatal error: timespec.h: No such
     file or directory #include "timespec.h"

Does test/Makefile.in need -I$(srcdir)/../lib adding to MODULE_CFLAGS?
Even after such a change, I get

  ../src/emacs: symbol lookup error:
  /path/to/test/data/emacs-module/mod-test.so: undefined symbol: dtotimespec