From: Drew Adams <drew.adams@oracle.com>
To: martin rudalics <rudalics@gmx.at>, 28947@debbugs.gnu.org
Subject: bug#28947: 26.0; doc string of `window-normalize-buffer' and similar
Date: Mon, 23 Oct 2017 06:16:31 -0700 (PDT) [thread overview]
Message-ID: <98a3ef2e-10ec-4c7e-b089-c75008ac1fdb@default> (raw)
In-Reply-To: <59EDA2E9.902@gmx.at>
> I rewrote the doc-string as follows:
>
> Return buffer specified by BUFFER-OR-NAME.
> BUFFER-OR-NAME must be a live buffer, a string naming a live
> buffer or nil which means to return the current buffer.
>
> This function is commonly used to process the (usually optional)
> "BUFFER-OR-NAME" argument of window related functions where nil
> stands for the current buffer.
> ...
> Right. This should have been fixed in the release version.
> ...
> Done.
> ...
> These three functions did not have the `window-' prefix initially. The
> prefix was requested by a maintainer and added later.
Thanks for the quick fix. Too bad about the function names.
I don't really see them as normalizing anything. And yes,
they are used by window-related functions. But they are
general utilities, not really having anything to do with
windows.
It's a bit like having a general function such as
`get-buffer' defined in a Lisp library `foo.el',
which is about using foos, and naming it
`foo-get-buffer'. If the function is usable and
useful outside foo.el then its definition belongs
outside foo.el, and it shouldn't have the
misleading prefix `foo-'.
This (the name) is all the more important for a library
named `window.el', as a window is an important, basic
Emacs thingie, and functions with `window' in their
name should be about Emacs windows.
Perhaps our maintainer could consider changing his
mind about this one? Perhaps we could move these
functions out of `window.el' and rename them without
prefix `window-'?
next prev parent reply other threads:[~2017-10-23 13:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-22 20:21 bug#28947: 26.0; doc string of `window-normalize-buffer' and similar Drew Adams
2017-10-23 8:06 ` martin rudalics
2017-10-23 13:16 ` Drew Adams [this message]
2017-10-31 8:41 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98a3ef2e-10ec-4c7e-b089-c75008ac1fdb@default \
--to=drew.adams@oracle.com \
--cc=28947@debbugs.gnu.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.