bug#8757: 24.0.50; `find-grep-options' - fn name doesn't fit doc string

bug#8757: 24.0.50; `find-grep-options' - fn name doesn't fit doc string

[Drew Adams]

Maybe the function should be called `find-grep-silence-options' or
`find-grep-quiet-options'.  If the value is supposed to represent the
switches that make `grep' as silent as possible, then this is about
silence or quiet - it is not about options in general.  Also, in Emacs
we don't usually call these "options" - we call them "switches":
`find-grep-quiet-switches'.

Besides, the Emacs option just above this one is called
`find-ls-subdir-switches' - switches, not options.
 

In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600)
 of 2011-05-23 on 3249CTO
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.5) --no-opt --cflags
-Ic:/build/include'
 

bug#8757: 24.0.50; `find-grep-options' - fn name doesn't fit doc string

[Lars Magne Ingebrigtsen]

"Drew Adams" <drew.adams@oracle.com> writes:

> Maybe the function should be called `find-grep-silence-options' or
> `find-grep-quiet-options'.  If the value is supposed to represent the
> switches that make `grep' as silent as possible, then this is about
> silence or quiet - it is not about options in general.  Also, in Emacs
> we don't usually call these "options" - we call them "switches":
> `find-grep-quiet-switches'.
>
> Besides, the Emacs option just above this one is called
> `find-ls-subdir-switches' - switches, not options.

I agree that the variable name is not optimal, but it's not actively
misleading, and changing it would be of little benefit.  I'm closing
this report.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

bug#8757: 24.0.50; `find-grep-options' - fn name doesn't fit doc string

[Drew Adams]

> I agree that the variable name is not optimal, but it's not actively
> misleading, and changing it would be of little benefit.  I'm closing
> this report.

You apparently don't agree to changing _any_ names - at least so far.

That's silly.  Of course it would benefit users to give this a better name.  And
yes, Emacs does not call switches "options".  This is clearly a bug on at least
two levels.

bug#8757: 24.0.50; `find-grep-options' - fn name doesn't fit doc string

[Lars Magne Ingebrigtsen]

"Drew Adams" <drew.adams@oracle.com> writes:

> You apparently don't agree to changing _any_ names - at least so far.

I'm all for changing names if there's a compelling reason to do so.
`find-grep-options' doesn't seem like a compelling case, when weighed
against the problems associated with changing the name of a
user-customisable variable.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/