bug#56765: 28.1.90; recenter-top-bottom in the minibuffer freezes Emacs

bug#56765: 28.1.90; recenter-top-bottom in the minibuffer freezes Emacs

[Daniel Mendler]

Minimal recipe:

1. Start emacs -Q
2. Enable fido-vertical-mode
3. Invoke M-x
4. Press C-l C-l C-l inside the minibuffer -> Emacs freezes

(Original report https://github.com/minad/vertico/issues/256)

In GNU Emacs 28.1.90 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo
version 1.16.0, Xaw scroll bars)
 of 2022-06-30 built on projects
Repository revision: f5421104e9753a2d3ead19ba31ac5ed1f3a5c03a
Repository branch: emacs-28
Windowing system distributor 'The X.Org Foundation', version 11.0.12004000
System Description: Debian GNU/Linux 10 (buster)

bug#56765: 28.1.90; recenter-top-bottom in the minibuffer freezes Emacs

[Eli Zaretskii]

> Date: Mon, 25 Jul 2022 20:36:13 +0200
> From: Daniel Mendler <mail@daniel-mendler.de>
> 
> Minimal recipe:
> 
> 1. Start emacs -Q
> 2. Enable fido-vertical-mode
> 3. Invoke M-x
> 4. Press C-l C-l C-l inside the minibuffer -> Emacs freezes

Thanks, should be fixed now on the release branch.

> (Original report https://github.com/minad/vertico/issues/256)

Could you see if this is also fixed?

bug#56765: 28.1.90; recenter-top-bottom in the minibuffer freezes Emacs

[Daniel Mendler]

On 7/25/22 21:01, Eli Zaretskii wrote:
>> Date: Mon, 25 Jul 2022 20:36:13 +0200
>> From: Daniel Mendler <mail@daniel-mendler.de>
>>
>> Minimal recipe:
>>
>> 1. Start emacs -Q
>> 2. Enable fido-vertical-mode
>> 3. Invoke M-x
>> 4. Press C-l C-l C-l inside the minibuffer -> Emacs freezes
> 
> Thanks, should be fixed now on the release branch.

You mean the Emacs 28 release branch? Could you please point me to the
commit which fixed the issue?

>> (Original report https://github.com/minad/vertico/issues/256)
> 
> Could you see if this is also fixed?

I am pretty sure that this one is fixed as well, but I will give it a
check the next time I recompile Emacs.

Thanks!

bug#56765: 28.1.90; recenter-top-bottom in the minibuffer freezes Emacs

[Eli Zaretskii]

> Date: Mon, 25 Jul 2022 21:10:54 +0200
> Cc: 56765@debbugs.gnu.org
> From: Daniel Mendler <mail@daniel-mendler.de>
> 
> On 7/25/22 21:01, Eli Zaretskii wrote:
> >> Date: Mon, 25 Jul 2022 20:36:13 +0200
> >> From: Daniel Mendler <mail@daniel-mendler.de>
> >>
> >> Minimal recipe:
> >>
> >> 1. Start emacs -Q
> >> 2. Enable fido-vertical-mode
> >> 3. Invoke M-x
> >> 4. Press C-l C-l C-l inside the minibuffer -> Emacs freezes
> > 
> > Thanks, should be fixed now on the release branch.
> 
> You mean the Emacs 28 release branch? Could you please point me to the
> commit which fixed the issue?

Commit 970190b on the emacs-28 branch.

bug#56765: 28.1.90; recenter-top-bottom in the minibuffer freezes Emacs

[Daniel Mendler]

On 7/26/22 04:24, Eli Zaretskii wrote:
>> Date: Mon, 25 Jul 2022 21:10:54 +0200
>> Cc: 56765@debbugs.gnu.org
>> From: Daniel Mendler <mail@daniel-mendler.de>
>>
>> On 7/25/22 21:01, Eli Zaretskii wrote:
>>>> Date: Mon, 25 Jul 2022 20:36:13 +0200
>>>> From: Daniel Mendler <mail@daniel-mendler.de>
>>>>
>>>> Minimal recipe:
>>>>
>>>> 1. Start emacs -Q
>>>> 2. Enable fido-vertical-mode
>>>> 3. Invoke M-x
>>>> 4. Press C-l C-l C-l inside the minibuffer -> Emacs freezes
>>>
>>> Thanks, should be fixed now on the release branch.
>>
>> You mean the Emacs 28 release branch? Could you please point me to the
>> commit which fixed the issue?
> 
> Commit 970190b on the emacs-28 branch.

Thanks, I can confirm that the bug has been fixed for fido-vertical-mode
and vertico-mode.

Daniel

bug#56765: 28.1.90; recenter-top-bottom in the minibuffer freezes Emacs

[Eli Zaretskii]

> Date: Tue, 26 Jul 2022 19:52:38 +0200
> Cc: 56765@debbugs.gnu.org
> From: Daniel Mendler <mail@daniel-mendler.de>
> 
> On 7/26/22 04:24, Eli Zaretskii wrote:
> >> Date: Mon, 25 Jul 2022 21:10:54 +0200
> >> Cc: 56765@debbugs.gnu.org
> >> From: Daniel Mendler <mail@daniel-mendler.de>
> >>
> >>> Thanks, should be fixed now on the release branch.
> >>
> >> You mean the Emacs 28 release branch? Could you please point me to the
> >> commit which fixed the issue?
> > 
> > Commit 970190b on the emacs-28 branch.
> 
> Thanks, I can confirm that the bug has been fixed for fido-vertical-mode
> and vertico-mode.

Great, thanks for testing.  I'm therefore closing this bug.