all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Paul Eggert <eggert@cs.ucla.edu>
To: "Michał Kondraciuk" <k.michal@zoho.com>
Cc: 30931@debbugs.gnu.org, Noam Postavsky <npostavs@gmail.com>
Subject: bug#30931: abort() due to CHECK_ALLOCATED_AND_LIVE failure during GC
Date: Thu, 29 Mar 2018 23:19:56 -0700	[thread overview]
Message-ID: <9829542a-15bb-6a83-20b0-2fd4dc42b8d4@cs.ucla.edu> (raw)
In-Reply-To: <0eb14aa5-8110-8336-5d3d-fac46ccc23f3@zoho.com>

[-- Attachment #1: Type: text/plain, Size: 273 bytes --]

Thanks for reporting that. I installed into master the attached patch, which 
fixed the crash for me, for the test case in Bug#30931#37.

This patch puts more pressure on the GC. Although it might be nice to relieve 
the pressure, I'm not sure it's worth the trouble.

[-- Attachment #2: 0001-Fix-CHECK_ALLOCATED_AND_LIVE-abort-during-GC.txt --]
[-- Type: text/plain, Size: 1094 bytes --]

From 670f2ffae718046c0fb37313965a51c040ed096f Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Thu, 29 Mar 2018 23:00:23 -0700
Subject: [PATCH] Fix CHECK_ALLOCATED_AND_LIVE abort during GC

* src/editfns.c (save_restriction_restore):
Wait for the GC to free the temporary markers (Bug#30931).
---
 src/editfns.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/editfns.c b/src/editfns.c
index 7e35fe8..727f2d0 100644
--- a/src/editfns.c
+++ b/src/editfns.c
@@ -3899,9 +3899,10 @@ save_restriction_restore (Lisp_Object data)
 
 	  buf->clip_changed = 1; /* Remember that the narrowing changed. */
 	}
-      /* These aren't needed anymore, so don't wait for GC.  */
-      free_marker (XCAR (data));
-      free_marker (XCDR (data));
+      /* This isn’t needed anymore, so don’t wait for GC.
+         Do not call free_marker on XCAR (data) or XCDR (data),
+         though, since record_marker_adjustments may have put
+         them on the buffer’s undo list (Bug#30931).  */
       free_cons (XCONS (data));
     }
   else
-- 
2.7.4


  parent reply	other threads:[~2018-03-30  6:19 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-24 20:30 bug#30931: 27.0.50; Crash in "Automatic GC" Michał Kondraciuk
2018-03-25  2:33 ` Eli Zaretskii
2018-03-28 21:02   ` Michał Kondraciuk
2018-03-29 23:47     ` Noam Postavsky
2018-03-30  5:39       ` Noam Postavsky
2018-03-30  8:16         ` Eli Zaretskii
2018-03-29 15:52   ` Michał Kondraciuk
2018-03-30  6:19 ` Paul Eggert [this message]
2018-03-30 12:56   ` bug#30931: abort() due to CHECK_ALLOCATED_AND_LIVE failure during GC Noam Postavsky
2018-03-30 16:23     ` Paul Eggert
2018-03-30 20:50       ` Noam Postavsky
2018-03-30 21:29         ` Paul Eggert
2018-03-31  7:42           ` Eli Zaretskii
2018-04-19 23:42 ` bug#30931: 27.0.50; Crash in "Automatic GC" Noam Postavsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9829542a-15bb-6a83-20b0-2fd4dc42b8d4@cs.ucla.edu \
    --to=eggert@cs.ucla.edu \
    --cc=30931@debbugs.gnu.org \
    --cc=k.michal@zoho.com \
    --cc=npostavs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.