From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kevin Layer Newsgroups: gmane.emacs.bugs Subject: Re: huge files in ~/.emacs.d/auto-save-list/ Date: Tue, 22 May 2007 16:26:26 -0700 Message-ID: <9829.1179876386@gemini.franz.com> References: <17763.1179779953@gemini.franz.com> <20566.1179846367@gemini.franz.com> NNTP-Posting-Host: lo.gmane.org X-Trace: sea.gmane.org 1179876485 10866 80.91.229.12 (22 May 2007 23:28:05 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 22 May 2007 23:28:05 +0000 (UTC) Cc: bug-gnu-emacs@gnu.org To: rms@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 23 01:28:02 2007 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Hqdlp-0005tr-AE for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 May 2007 01:28:01 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Hqdlq-0002ph-Q3 for geb-bug-gnu-emacs@m.gmane.org; Tue, 22 May 2007 19:28:02 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HqdkN-0002Gu-FI for bug-gnu-emacs@gnu.org; Tue, 22 May 2007 19:26:31 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HqdkM-0002Gd-U0 for bug-gnu-emacs@gnu.org; Tue, 22 May 2007 19:26:31 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HqdkM-0002GU-N1 for bug-gnu-emacs@gnu.org; Tue, 22 May 2007 19:26:30 -0400 Original-Received: from fw1.franz.com ([206.169.112.54] helo=gemini.franz.com) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1HqdkJ-0005ZU-P3; Tue, 22 May 2007 19:26:28 -0400 Original-Received: from gemini.franz.com (localhost [127.0.0.1]) by gemini.franz.com (8.13.8/8.13.7) with ESMTP id l4MNQQsO009830; Tue, 22 May 2007 16:26:26 -0700 In-reply-to: Comments: In-reply-to Richard Stallman message dated "Tue, 22 May 2007 19:10:08 -0400." X-Mailer: MH-E 8.0.3; nmh 1.1; GNU Emacs 22.0.96 X-detected-kernel: Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:15736 Archived-At: Richard Stallman wrote: >> Could you look at the directory once each week to see >> if more such failures have happened? Maybe then you would >> still remember whether Emacs had crashed. I was thinking the same thing. >> I wonder, is the file ALL junk after a certain point? >> Or is the junk inserted in the middle? I think I saw occasional lines that looked ok, but they were few and far between the junk. >> The existing code relies on an unwind-protect to close the stream. >> Maybe something fails to run the unwind-protect. Could you try >> running with this change, and tell us if it prevents the problem? I'm going to run for a while to see if the problem reoccurs with emacs 22. If it does, I'll add the following change and test it. >> *** fileio.c 22 Mar 2007 08:15:04 -0400 1.580 >> --- fileio.c 22 May 2007 14:23:20 -0400 >> *************** >> *** 6021,6026 **** >> --- 6021,6027 ---- >> >> /* Prevent another auto save till enough input events come in. */ >> record_auto_save (); >> + fclose (stream); >> >> if (auto_saved && NILP (no_message)) >> {