From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.devel Subject: Re: Adding battery support on Cygwin Date: Sat, 13 Jan 2018 13:19:40 -0500 Message-ID: <97e872b3-e6d2-ec01-80e9-abec35a85c58@cornell.edu> References: <302136d9-0b2e-222e-502d-2db8f7de5992@cornell.edu> <83tvvq18lx.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1515867517 32317 195.159.176.226 (13 Jan 2018 18:18:37 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 13 Jan 2018 18:18:37 +0000 (UTC) User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jan 13 19:18:33 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eaQNy-000847-L9 for ged-emacs-devel@m.gmane.org; Sat, 13 Jan 2018 19:18:30 +0100 Original-Received: from localhost ([::1]:54918 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eaQPy-0002pR-GB for ged-emacs-devel@m.gmane.org; Sat, 13 Jan 2018 13:20:34 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60819) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eaQPD-0002pD-HS for emacs-devel@gnu.org; Sat, 13 Jan 2018 13:19:48 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eaQPA-0005g2-Co for emacs-devel@gnu.org; Sat, 13 Jan 2018 13:19:47 -0500 Original-Received: from limerock03.mail.cornell.edu ([128.84.13.243]:45764) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eaQPA-0005fi-8M; Sat, 13 Jan 2018 13:19:44 -0500 X-CornellRouted: This message has been Routed already. Original-Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limerock03.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id w0DIJhej006351; Sat, 13 Jan 2018 13:19:43 -0500 Original-Received: from [10.13.22.4] (65-112-130-194.dia.static.qwest.net [65.112.130.194]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id w0DIJfLj009826 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Sat, 13 Jan 2018 13:19:42 -0500 In-Reply-To: <83tvvq18lx.fsf@gnu.org> Content-Language: en-US X-PMX-Cornell-Gauge: Gauge=X X-PMX-CORNELL-AUTH-RESULTS: dkim-out=none; X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 128.84.13.243 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:221931 Archived-At: On 1/13/2018 3:11 AM, Eli Zaretskii wrote: >> From: Ken Brown >> Date: Fri, 12 Jan 2018 21:33:33 -0500 >> >> The Cygwin-w32 currently supports battery status via the function >> w32fns.c:Fw32_battery_status. The X11 and nox builds don't have this >> support, and Cygwin lacks the facilities used on unix-like systems to >> provide it (/proc/apm, etc.). But it turns out to be easy to compile >> and use Fw32_battery_status on all Cygwin builds, simply by pulling it >> out of w32fns.c into a new file. >> >> The attached patch does this. OK to push? > > Yes, but see some comments below. Thanks for the review. I've pushed it to master with the changes you suggested. Ken