all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Philipp Stephani <p.stephani2@gmail.com>,
	Jordon Biondo <jordonbiondo@gmail.com>,
	Emacs development discussions <emacs-devel@gnu.org>
Subject: RE: Revisiting `setq-local`s signature
Date: Tue, 31 Jan 2017 10:57:39 -0800 (PST)	[thread overview]
Message-ID: <97d4f384-5126-4fc4-8902-0bdb59fa5ae4@default> (raw)
In-Reply-To: <CAArVCkRG=0xsHRN=6UMwAm6RNcSGUw3vuXvES-LvOROOOd105w@mail.gmail.com>

> As a user, I'm still opposed to this change. I don't think
> consistency is important enough in this case to justify the
> "worse" signature.

You don't say what is "worse" about it.

> Consistency is not a goal in itself, but should serve the
> goal to increase readability and lower the barriers for new
> contributors.

Yes, consistency is not a goal in itself.  But you do not say
how the suggested inconsistency here increases readability or
lowers the barriers for new contributors.

> I don't think that the simpler signature of setq-local is in
> any way confusing because of this inconsistency.

How is it simpler?  What _prevents_ a user from setting only
a single variable value each time s?he uses `setq-local'?

Additional assignments would be optional.  In fact, even the
first assignment would be optional, if we follow the `setq'
model.

Is your statement about readability based on your feeling
that the first of these two sexps is more readable than the 
second?  If so, there are at least some people who don't feel 
that way.

(progn
 (setq-local foo 1)
 (setq-local bar 2)
 (setq-local fot 8)
 (setq-local tof 3)
 (setq-local baz 2)
 (setq-local zab 4)
 (setq-local flt 6))

(setq-local foo 1
            bar 2
            fot 8
            tof 3
            baz 2
            zab 4
            flt 6)

I don't see an argument that points to a downside to _allowing_
a variable number of assignments.



  parent reply	other threads:[~2017-01-31 18:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-30 18:37 Revisiting `setq-local`s signature Jordon Biondo
2017-01-31  3:47 ` Tino Calancha
2017-01-31 18:13 ` Philipp Stephani
2017-01-31 18:48   ` Tom Tromey
2017-01-31 18:57   ` Drew Adams [this message]
2017-01-31 19:13     ` Jordon Biondo
2017-02-01  5:55   ` Tino Calancha
2017-02-02  3:01 ` John Wiegley
2017-02-02  3:34   ` Eli Zaretskii
2017-02-02 14:28     ` Jordon Biondo
2017-02-02 17:35       ` Eli Zaretskii
2017-02-02 17:43         ` Jordon Biondo
2017-02-02 20:31           ` Eli Zaretskii
2017-02-08 15:59             ` Jordon Biondo
2017-02-10  8:33               ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=97d4f384-5126-4fc4-8902-0bdb59fa5ae4@default \
    --to=drew.adams@oracle.com \
    --cc=emacs-devel@gnu.org \
    --cc=jordonbiondo@gmail.com \
    --cc=p.stephani2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.