From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: [PATCH] Allow regexps in org-file-apps to capture link parameters using groups Date: Sun, 21 Mar 2010 18:13:10 +0100 Message-ID: <9771A876-82D8-4755-9EC4-F951EA9FE6E6@gmail.com> References: <4B600794.4010008@jboecker.de> <4BA630AD.1080901@jboecker.de> Mime-Version: 1.0 (Apple Message framework v936) Content-Type: text/plain; charset=ISO-8859-1; format=flowed; delsp=yes Content-Transfer-Encoding: quoted-printable Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NtcM9-0007pv-LR for emacs-orgmode@gnu.org; Mon, 22 Mar 2010 03:47:25 -0400 Received: from [140.186.70.92] (port=43643 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NtcLz-0007Pt-TB for emacs-orgmode@gnu.org; Mon, 22 Mar 2010 03:47:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NtcLL-0002Eg-Sa for emacs-orgmode@gnu.org; Mon, 22 Mar 2010 03:46:36 -0400 Received: from mail-fx0-f220.google.com ([209.85.220.220]:47762) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NtcLL-0002EW-NF for emacs-orgmode@gnu.org; Mon, 22 Mar 2010 03:46:35 -0400 Received: by fxm20 with SMTP id 20so5957263fxm.32 for ; Mon, 22 Mar 2010 00:46:33 -0700 (PDT) In-Reply-To: <4BA630AD.1080901@jboecker.de> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: =?ISO-8859-1?Q?Jan_B=F6cker?= Cc: org-mode Mode Hi Jan, I have now applied this patch. Hi everyone, I am not sure if I completely understood every part of it, so if anyone finds strange behavior of links, make sure to report it so that we (Jan, that is :-) gets a chance to fix it. Thanks! - Carsten On Mar 21, 2010, at 3:43 PM, Jan B=F6cker wrote: > On 20.03.2010 16:07, Carsten Dominik wrote: >> Hi Jan, >> >> I forgot what the last status of this thread was. Could you please >> remind me? >> >> Thanks. >> >> - Carsten >> > > Hi Carsten, > > The patch is ready to be applied. I have been using it since January =20= > 16 > without any problems. > As mentioned in the description, it does introduce a > backwards-incompatible change, but I know of no existing code which > depends on the old behavior. > > However, I noticed an error in the docstrings and commit message: in > several places where it says "(string-match n link)", it should say > "(match-string n link)". > I have attached a fixed version, which is also available via: > git pull http://github.com/jboecker/org-mode.git for-carsten > > The motivation for this patch went something like this: > - I wanted to link to PDFs, so I wrote org-docview.el > - Someone pointed out that docview links did not respect > org-link-file-path-type, which I fixed > - Daniel M. German started integrating evince and xournal with > org-protocol and asked if there was a link syntax to link to a =20 > specific > page of a PDF (there were docview: links, but these are hard-coded to > open within emacs) > - I realized that docview: links are/should be a special case of file: > links, so I wrote this patch > >> On Jan 27, 2010, at 10:29 AM, Jan B=F6cker wrote: >>> >>> Btw, since posting the patch I stumbled upon another disadvantage: >>> 'extended' link types defined this way will only support =20 >>> autocompletion >>> for the file name, i.e. you will not be prompted for a page number =20= >>> when >>> entering a link using C-c C-l file , then specifying the path =20= >>> to >>> some PDF file. > > I do no longer count this as a reason against this patch, because =20 > normal > file: links do not prompt you for a line number, either, and you =20 > should > not be typing in links by hand anyway most of the time. > >>> A better way to extend file links might be to make it easy to =20 >>> create new >>> links with "file" behaviour, instead of applying this patch (so a =20= >>> pdf >>> link would look like file+pdf:/document.pdf::4, and because the link >>> type starts with "file+", it will e.g. respect org-link-file-path-=20= >>> type >>> automatically). >>> What do you think? > > Because I no longer care about prompting for a page number, I no =20 > longer > care about this crazy idea of mine, too. Please go ahead and apply the > patch in its current state. > >>> Unfortunately, I won't have much time for programming for about a =20= >>> month >>> due to exams. > > This has also changed, I passed all three :) > Now that I again have time to code and Daniel M German's patches to > xournal and evince are functional, my next steps will be the two =20 > things > mentioned under "What's next?" in the initial patch description. > > If you have any further questions, just ask! > - Jan > > > PS: > On 27.01.2010 11:53, Carsten Dominik wrote: >> It is in my list, and I will get to it.... > When the author of org-mode says it's on his list, you know he will =20= > come > back to it and you don't have to add it to yours :) > <0001-Allow-regexps-in-org-file-apps-to-capture-link-param.patch> - Carsten