From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Christian Johansson Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: phps-mode Date: Wed, 17 Jul 2019 22:27:29 +0200 Message-ID: <976309cb-f452-2932-f3fa-4f569a8f547c@cvj.se> References: <713AB63A-5E2C-4D07-9D96-AFB7DD1ADEDA@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="269245"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 Cc: Emacs developers To: =?UTF-8?Q?Mattias_Engdeg=c3=a5rd?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 17 22:28:43 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hnqXb-0017w6-6N for ged-emacs-devel@m.gmane.org; Wed, 17 Jul 2019 22:28:43 +0200 Original-Received: from localhost ([::1]:60332 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hnqXa-0000mL-73 for ged-emacs-devel@m.gmane.org; Wed, 17 Jul 2019 16:28:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35233) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hnqXX-0000mF-Qj for emacs-devel@gnu.org; Wed, 17 Jul 2019 16:28:40 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hnqXW-0002jv-VZ for emacs-devel@gnu.org; Wed, 17 Jul 2019 16:28:39 -0400 Original-Received: from cvj.se ([31.192.230.63]:42229) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hnqXW-0002iJ-D4 for emacs-devel@gnu.org; Wed, 17 Jul 2019 16:28:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=cvj.se; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=sGlwv+zOHZDeLSj5iWdvyT4imBU/Ai8BQWObymUjTOc=; b=qS/4/vMuhQBengxIMMVqMZZ+JpK1FJ7BkGgAdIhAQ8cwkSdGPY9uKT3cdXrDuJTtgJTzjeZRGEHGBBGTFmPBxUMPsakbase4ppsiLs5pHpYaJo4B2vN5nbo2B/yL7sbJPTUUneNNwbqSfpsFtIaxcDKsrRqtWfQrD0M6k2PL1Ec=; Original-Received: from c-2f5ee255.011-155-65736b4.bbcust.telenor.se ([85.226.94.47] helo=Christians-MacBook-Air.local) by cvj.se with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1hnqWS-0006V6-HC; Wed, 17 Jul 2019 22:27:32 +0200 In-Reply-To: Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 31.192.230.63 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:238622 Archived-At: Hi again! Thanks, I have updated the regex, labels with UTF-8 are now supported just like in PHP 7 Best Regards Christian On 2019-07-17 10:44, Mattias Engdegård wrote: > 17 juli 2019 kl. 07.43 skrev Christian Johansson : >> Thanks for your review, I should have fixed all those items now and pushed them to ELPA >> (defvar phps-mode-lexer-LABEL >> "[a-zA-Z_\u0080-\u00FF][a-zA-Z0-9_\x80-\xff]*" > Unfinished? > > It looks like PHP accepts any Unicode character above and including U+0080 in labels implicitly, by including 80-ff at the byte level and the implicit fact that most PHP code is in UTF-8. So your regexp would probably be something like > > "[A-Za-z_[:nonascii:]][0-9A-Za-z_[:nonascii:]]*" > > You could always try and see if your code correctly treats $γνῶσις, say. >