From: Dmitry Gutov <dgutov@yandex.ru>
To: Stephen Leake <stephen_leake@stephe-leake.org>,
emacs-devel <emacs-devel@gnu.org>
Subject: Re: new elpa packages for ada-mode project related stuff
Date: Thu, 17 Jan 2019 05:31:41 +0300 [thread overview]
Message-ID: <9728209b-89a7-12f8-8cd6-18b630caa01b@yandex.ru> (raw)
In-Reply-To: <86zhs0o2g0.fsf@stephe-leake.org>
On 16.01.2019 21:57, Stephen Leake wrote:
> I'd like to create one or more new ELPA packages to support the ada-mode
> project code.
>
> The new files are:
>
> env-project.el -- 70 lines
> Adds three new project defgenerics:
> project-refresh
> project-select
> project-deselect
>
> These should be in project.el in some future version of emacs.
I don't think so.
project-refresh is debatable, but when would the user want to call it?
There's no way for them to know. It'd be much better to use caches with
proper automatic invalidation, e.g. with filenotify. IOW, I'd like to
see the feature in the wild, in different project backends, and then we
can incorporate it.
But project-select and project-deselect, as previously discussed, can be
implemented in terms of project-find-functions. If you and some other
users find it handy to have an Emacs-wide global project and select it
manually, be my guest, but please make it a globalized minor mode, and
add a project-find-functions entry for it. The said minor mode can have
its own commands to -select and -deselect.
> Then defines a project defstruct that declares/undeclares
> environment variables when it is selected/deselected. ada-mode project
> inherits this.
Err, I'd rather have it user explicitly in certain functions like Stefan
discussed, rather than invisibly change env variables in the whole session.
> path-iterator.el -- 243 lines
> Provides an iterator for directory paths; returns one file at a
> time. Handles a mix of flat and recursive directories.
> Probably should be rewritten to use generator.el.
Why an iterator, though? And not just a list?
If it's used in a completion table, surely the whole sequence will have
to be realized anyway the first time user types TAB.
> uniquify-files.el -- 687 lines
> Provides a completion style and completion table that presents
> uniquified file names to the user for completion.
> Uses path-iterator.el
> ada-mode project-file-completion-table uses this.
I wrote my feelings on that subject in a separate email. A neat feature,
I'm sure, but I'd prefer if it were implemented in a radically different
way.
prev parent reply other threads:[~2019-01-17 2:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-16 18:57 new elpa packages for ada-mode project related stuff Stephen Leake
2019-01-16 19:18 ` Stefan Monnier
2019-01-16 21:43 ` Stephen Leake
2019-01-17 1:41 ` Stefan Monnier
2019-01-17 13:22 ` Michael Heerdegen
2019-01-17 2:31 ` Dmitry Gutov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9728209b-89a7-12f8-8cd6-18b630caa01b@yandex.ru \
--to=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=stephen_leake@stephe-leake.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.