From: Gregory Heytings <gregory@heytings.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 21695@debbugs.gnu.org, hmelman@gmail.com, rms@gnu.org
Subject: bug#21695: 25.0.50; Change most occurrences of `setq' in Emacs manual to `customize-set-variable'? Really?
Date: Mon, 13 Sep 2021 09:11:11 +0000 [thread overview]
Message-ID: <97113ce8badac94c846f@heytings.org> (raw)
In-Reply-To: <87a6khj6s5.fsf@gnus.org>
>> + if (!EQ (plist, Qnil) && !NILP (Fplist_get (plist, Qcustom_set)))
>> + safe_call2 (Qdisplay_warning, Qsetq,
>> + CALLN (Fformat,
>> + build_string
>> + ("`%s' should be set with `customize-set-variable'"),
>> + sym));
>
> I haven't tried the patch, but won't this be triggered by the code
> that's handling the variables? For instance, `latin1-display' has a
> :set, but the file itself does `(setq latin1-display t)' etc. (This is
> a very common pattern.)
>
No, (latin1-display 'latin-2) does not raise a warning with the patch,
because latin1-disp.el is bytecompiled, and Fsetq is not used when
bytecompiled code is executed (bytecompiled code only uses Fset).
That being said, I would say that using (setq latin1-display t) when
latin1-display has a :set is always a bug, in the init file,
interactively, or in built-in code (bytecompiled or not), and that (set
'latin1-display t) should be used instead. WDYT?
next prev parent reply other threads:[~2021-09-13 9:11 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-16 21:50 bug#21695: 25.0.50; Change most occurrences of `setq' in Emacs manual to `customize-set-variable' Drew Adams
2015-10-16 23:57 ` Drew Adams
2021-05-26 22:30 ` Lars Ingebrigtsen
2021-08-29 19:05 ` Drew Adams
2021-08-29 22:36 ` Drew Adams
2021-08-29 22:52 ` Drew Adams
2021-08-29 22:58 ` Drew Adams
2021-08-31 3:06 ` bug#21695: 25.0.50; Change most occurrences of `setq' in Emacs manual to `customize-set-variable'? Really? Richard Stallman
2021-08-31 3:43 ` Arthur Miller
2021-08-31 16:15 ` bug#21695: [External] : " Drew Adams
2021-08-31 16:15 ` Drew Adams
2021-09-02 6:53 ` Kevin Vigouroux via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-02 17:08 ` Drew Adams
2021-09-03 9:54 ` bug#21695: 25.0.50; Change most occurrences of `setq' in Emacs manual to `customize-set-variable' Kevin Vigouroux via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-01 3:07 ` bug#21695: 25.0.50; Change most occurrences of `setq' in Emacs manual to `customize-set-variable'? Really? Howard Melman
2021-09-02 3:42 ` Richard Stallman
2021-09-02 6:53 ` Eli Zaretskii
2021-09-02 17:08 ` bug#21695: [External] : " Drew Adams
2021-09-02 17:17 ` Eli Zaretskii
2021-09-05 3:42 ` Richard Stallman
2021-09-05 3:43 ` Richard Stallman
2021-09-06 17:43 ` Eli Zaretskii
2021-09-08 3:23 ` Richard Stallman
2021-09-08 7:03 ` Eli Zaretskii
2021-09-09 3:11 ` Richard Stallman
2021-09-09 6:52 ` Eli Zaretskii
2021-09-09 7:43 ` Gregory Heytings
2021-09-09 11:44 ` Gregory Heytings
2021-09-09 12:07 ` Lars Ingebrigtsen
2021-09-09 12:12 ` Gregory Heytings
2021-09-09 12:15 ` Lars Ingebrigtsen
2021-09-09 12:40 ` Gregory Heytings
2021-09-09 12:47 ` Lars Ingebrigtsen
2021-09-09 13:04 ` Gregory Heytings
2021-09-09 13:10 ` Lars Ingebrigtsen
2021-09-09 14:27 ` Gregory Heytings
2021-09-10 10:15 ` Lars Ingebrigtsen
2021-09-10 14:26 ` Gregory Heytings
2021-09-12 8:23 ` Gregory Heytings
2021-09-12 8:57 ` Eli Zaretskii
2021-09-12 9:30 ` Gregory Heytings
2021-09-12 9:37 ` Eli Zaretskii
2021-09-12 9:54 ` Gregory Heytings
2021-09-12 10:11 ` Eli Zaretskii
2021-09-12 10:21 ` Eli Zaretskii
2021-09-12 21:26 ` Gregory Heytings
2021-09-12 22:11 ` Gregory Heytings
2021-09-13 7:04 ` Lars Ingebrigtsen
2021-09-13 9:11 ` Gregory Heytings [this message]
2021-09-13 9:18 ` Lars Ingebrigtsen
2021-09-13 13:00 ` Gregory Heytings
2021-09-13 13:56 ` Eli Zaretskii
2021-09-13 12:17 ` Eli Zaretskii
2021-09-13 11:31 ` Eli Zaretskii
2021-09-13 8:03 ` martin rudalics
2021-09-13 9:14 ` Gregory Heytings
2021-09-13 12:36 ` martin rudalics
2021-09-13 12:52 ` Gregory Heytings
2021-09-15 9:27 ` martin rudalics
2021-09-15 10:00 ` Gregory Heytings
2021-09-15 20:13 ` Richard Stallman
2021-09-16 6:56 ` martin rudalics
2021-09-18 0:30 ` Richard Stallman
2021-09-18 7:34 ` martin rudalics
2021-09-18 9:20 ` Gregory Heytings
2021-09-13 1:17 ` Richard Stallman
2021-09-10 3:41 ` Richard Stallman
2021-09-10 13:49 ` Gregory Heytings
2021-09-13 1:17 ` Richard Stallman
2021-09-02 17:08 ` bug#21695: [External] : " Drew Adams
2021-09-05 3:42 ` Richard Stallman
2021-09-04 3:38 ` Richard Stallman
2021-09-01 12:48 ` Augusto Stoffel
2021-09-02 3:38 ` Richard Stallman
2021-09-02 6:56 ` Eli Zaretskii
2021-09-02 17:07 ` bug#21695: [External] : " Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97113ce8badac94c846f@heytings.org \
--to=gregory@heytings.org \
--cc=21695@debbugs.gnu.org \
--cc=hmelman@gmail.com \
--cc=larsi@gnus.org \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.