From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Jonathan Kyle Mitchell Newsgroups: gmane.emacs.bugs Subject: bug#30724: eshell: escaped tilde is not treated as such Date: Fri, 06 Jul 2018 02:24:20 -0500 Message-ID: <97031714eb3479b466bca0545b76114e4d40e898.camel@jonathanmitchell.org> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-Eh3fWDD7BlFLgkiogzID" X-Trace: blaine.gmane.org 1530861789 7800 195.159.176.226 (6 Jul 2018 07:23:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 6 Jul 2018 07:23:09 +0000 (UTC) Cc: Noam Postavsky , "; Yegor Timoshenko" To: 30724@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 06 09:23:05 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fbL56-0001wA-Iv for geb-bug-gnu-emacs@m.gmane.org; Fri, 06 Jul 2018 09:23:04 +0200 Original-Received: from localhost ([::1]:56175 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fbL7D-0006Dc-Ha for geb-bug-gnu-emacs@m.gmane.org; Fri, 06 Jul 2018 03:25:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48173) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fbL75-00069f-Vy for bug-gnu-emacs@gnu.org; Fri, 06 Jul 2018 03:25:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fbL70-00049F-Si for bug-gnu-emacs@gnu.org; Fri, 06 Jul 2018 03:25:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40295) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fbL70-00048Z-OO for bug-gnu-emacs@gnu.org; Fri, 06 Jul 2018 03:25:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fbL70-0005VA-ES for bug-gnu-emacs@gnu.org; Fri, 06 Jul 2018 03:25:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Jonathan Kyle Mitchell Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 06 Jul 2018 07:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30724 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 30724-submit@debbugs.gnu.org id=B30724.153086186921107 (code B ref 30724); Fri, 06 Jul 2018 07:25:02 +0000 Original-Received: (at 30724) by debbugs.gnu.org; 6 Jul 2018 07:24:29 +0000 Original-Received: from localhost ([127.0.0.1]:48192 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fbL6T-0005UN-Dt for submit@debbugs.gnu.org; Fri, 06 Jul 2018 03:24:29 -0400 Original-Received: from mail-oi0-f54.google.com ([209.85.218.54]:33371) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fbL6S-0005UB-HV for 30724@debbugs.gnu.org; Fri, 06 Jul 2018 03:24:28 -0400 Original-Received: by mail-oi0-f54.google.com with SMTP id c6-v6so21747129oiy.0 for <30724@debbugs.gnu.org>; Fri, 06 Jul 2018 00:24:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:mime-version; bh=MKQRh0ZCOw3Npu7ZM/A6+dS+U9kWB76b56fa9fiTWwY=; b=OwMmZ3KNl+/Tj6jYT+PAI8b/p2aicLo/YY9CEqS1vht4VDv6NAZKBNvXTt/ROuwVgv +0fVRagHBNZQUuhKZA4VDA8vTlW3GI+Z/XgPHGaT6ZYIYzo4qKF5EwEHWW7zJiCEbxiq 3P8e5KRKG+r4c5w8BhlCTuPzgJ0dAcfP8kj8NC1KoEkx2TFxxCgV/+2qWwWpjvphrw/d rXrUZnOpbJWrNGk32hcL7zMqdvEiRrUipeUymzbGlg5/r6BPVR6MmByle+8NXsZ3dSuN tWdUHsq06OjkG4YuBWnvb1D77jeEiTJHWhcjLheZxf0VAxM1BgjVV20qEJOhL+XaGlLx 5+QQ== X-Gm-Message-State: APt69E1O9IxiLm1SqnACptAOHowmJEihAEURTbe+ZwdjWbm3QxpKSWgr KlZ9gOKVUApVnM5dUYPAadcBNAiQSa4= X-Google-Smtp-Source: AAOMgpeHqLbpaEVXkMPEmZM0cV3VUqRLavMPWY2ttZ7bkfDPTMtsM9C6PCLj0Wa2OWHWI1CubZIk6A== X-Received: by 2002:aca:f007:: with SMTP id o7-v6mr9986329oih.193.1530861862429; Fri, 06 Jul 2018 00:24:22 -0700 (PDT) Original-Received: from fedora-laptop ([2601:2c3:8880:3cc9::4a69]) by smtp.gmail.com with ESMTPSA id o82-v6sm5510401oih.20.2018.07.06.00.24.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 06 Jul 2018 00:24:21 -0700 (PDT) X-Mailer: Evolution 3.28.3 (3.28.3-1.fc28) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:148240 Archived-At: --=-Eh3fWDD7BlFLgkiogzID Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit tags 30724 + patch quit I found a way to get eshell to escape special chars. It seems most of the eshell builtin commands that take file arguments are already tagged with the eshell-no-numeric-conversions property. By adding the true part of the if condition in eshell-lisp-command, it is possible to quote the arguments of special filenames. The attached patch checks for "~" and "*". ;; for reference, here's the set of eshell builtins with the ;; eshell-no-numeric-conversions property ./esh-proc.el\0202:(put 'eshell/kill 'eshell-no-numeric-conversions t) ./em-dirs.el\0409:(put 'eshell/cd 'eshell-no-numeric-conversions t) ./em-dirs.el\0472:(put 'eshell/pushd 'eshell-no-numeric-conversions t) ./em-dirs.el\0502:(put 'eshell/popd 'eshell-no-numeric-conversions t) ./esh-ext.el\0261:(put 'eshell/addpath 'eshell-no-numeric-conversions t ./esh-util.el\091: (put \\='find-file \\='eshell-no-numeric- ./em-script.el\0127:(put 'eshell/source 'eshell-no-numeric-conversions ./em-script.el\0140:(put 'eshell/. 'eshell-no-numeric-conversions t) ./em-unix.el\0167:(put 'eshell/man 'eshell-no-numeric-conversions t) ./em-unix.el\0309:(put 'eshell/rm 'eshell-no-numeric-conversions t) ./em-unix.el\0326:(put 'eshell/mkdir 'eshell-no-numeric-conversions t) ./em-unix.el\0342:(put 'eshell/rmdir 'eshell-no-numeric-conversions t) ./em-unix.el\0526:(put 'eshell/mv 'eshell-no-numeric-conversions t) ./em-unix.el\0563:(put 'eshell/cp 'eshell-no-numeric-conversions t) ./em-unix.el\0595:(put 'eshell/ln 'eshell-no-numeric-conversions t) ./em-unix.el\0647:(put 'eshell/cat 'eshell-no-numeric-conversions t) ./em-unix.el\0664:(put 'eshell/make 'eshell-no-numeric-conversions t) ./em-unix.el\01031:(put 'eshell/diff 'eshell-no-numeric-conversions t) ./em-unix.el\01050:(put 'eshell/locate 'eshell-no-numeric-conversions ./em-unix.el\01059:(put 'eshell/occur 'eshell-no-numeric-conversions t) ./esh-cmd.el\01185:(put 'eshell/which 'eshell-no-numeric-conversions t) ./em-ls.el\0336:(put 'eshell/ls 'eshell-no-numeric-conversions t) ./em-tramp.el\097:(put 'eshell/su 'eshell-no-numeric-conversions t) ./em-tramp.el\0139:(put 'eshell/sudo 'eshell-no-numeric-conversions t) -- Jonathan Kyle Mitchell --=-Eh3fWDD7BlFLgkiogzID Content-Disposition: attachment; filename*0=0001-Check-for-filenames-special-to-the-shell-before-runn.pat; filename*1=ch Content-Type: text/x-patch; name="0001-Check-for-filenames-special-to-the-shell-before-runn.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSAxYWFkOTYzYTcxZmNhMWFiZmZmNmQ0NTIyZGRmODNhMDczOTE3MTJhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb25hdGhhbiBLeWxlIE1pdGNoZWxsIDxreWxlQGpvbmF0aGFu bWl0Y2hlbGwub3JnPgpEYXRlOiBGcmksIDYgSnVsIDIwMTggMDE6NDA6MzIgLTA1MDAKU3ViamVj dDogW1BBVENIXSBDaGVjayBmb3IgZmlsZW5hbWVzIHNwZWNpYWwgdG8gdGhlIHNoZWxsIGJlZm9y ZSBydW5uaW5nIGEKIGNvbW1hbmQKCkZpeCBidWcjMzA3MjQgYnkgY2hlY2tpbmcgaWYgIioiIGFu ZCAifiIgYXJlIGFyZ3VtZW50cyB0byB0aGUgY3VycmVudCBjb21tYW5kCmFuZCBxdW90aW5nIHRo ZW0gcmVsYXRpdmUgdG8gYGRlZmF1bHQtZGlyZWN0b3J5JyBpZiBzby4gIFRoaXMgbGV2ZXJhZ2Vz IHRoZQp0aGUgZmFjdCB0aGF0IHRoZSBleGlzdGluZyBlc2hlbGwgYnVpbHRpbiBjb21tYW5kcyB0 aGF0IGFjY2VwdCBmaWxlIGFyZ3VtZW50cwphcmUgdGFnZ2VkIHdpdGggdGhlIGVzaGVsbC1uby1u dW1lcmljLWNvbnZlcnNpb25zIHByb3BlcnR5LiAgVGhlIGV4aXN0aW5nCmRldGFpbHMgb2YgZXNo ZWxsIGNvbW1hbmQgZXhlY3V0aW9uIGFyZSBsZWZ0IHVuY2hhbmdlZC4KCiogbGlzcC9lc2hlbGwv ZXNoLWNtZC5lbCAoZXNoZWxsLWxpc3AtY29tbWFuZCkKLS0tCiBsaXNwL2VzaGVsbC9lc2gtY21k LmVsIHwgMTcgKysrKysrKysrKysrKystLS0KIDEgZmlsZSBjaGFuZ2VkLCAxNCBpbnNlcnRpb25z KCspLCAzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3AvZXNoZWxsL2VzaC1jbWQuZWwg Yi9saXNwL2VzaGVsbC9lc2gtY21kLmVsCmluZGV4IDYxYzBlYmM3MWQuLmEyMjMwOWE4NWUgMTAw NjQ0Ci0tLSBhL2xpc3AvZXNoZWxsL2VzaC1jbWQuZWwKKysrIGIvbGlzcC9lc2hlbGwvZXNoLWNt ZC5lbApAQCAtMTMxMCw5ICsxMzEwLDIwIEBAIGVzaGVsbC1saXNwLWNvbW1hbmQKIAkJICAoc2V0 cSBlc2hlbGwtbGFzdC1hcmd1bWVudHMgYXJncwogCQkJZXNoZWxsLWxhc3QtY29tbWFuZC1uYW1l CiAJCQkoY29uY2F0ICIjPGZ1bmN0aW9uICIgKHN5bWJvbC1uYW1lIG9iamVjdCkgIj4iKSkKLQkJ ICA7OyBpZiBhbnkgb2YgdGhlIGFyZ3VtZW50cyBhcmUgZmxhZ2dlZCBhcyBudW1iZXJzCi0JCSAg Ozsgd2FpdGluZyBmb3IgY29udmVyc2lvbiwgY29udmVydCB0aGVtIG5vdwotCQkgICh1bmxlc3Mg KGdldCBvYmplY3QgJ2VzaGVsbC1uby1udW1lcmljLWNvbnZlcnNpb25zKQorCQkgIChpZiAoZ2V0 IG9iamVjdCAnZXNoZWxsLW5vLW51bWVyaWMtY29udmVyc2lvbnMpCisJCSAgICAgIDs7IGNoZWNr IGZvciBmaWxlbmFtZXMgc3BlY2lhbCB0byB0aGUgc2hlbGwgYW5kCisJCSAgICAgIDs7IHF1b3Rl IHRoZW0gcmVsYXRpdmUgdG8gYGRlZmF1bHQtZGlyZWN0b3J5JworCQkgICAgICAod2hpbGUgYXJn cworCQkJKGxldCAoKGFyZyAoY2FyIGFyZ3MpKSkKKwkJCSAgKGlmIChhbmQgKHN0cmluZ3AgYXJn KQorCQkJCSAgIChtZW1iZXIgYXJnICcoIn4iICIqIikpKQorCQkJICAgICAgKHNldGNhciBhcmdz IChjb25jYXQgKGZpbGUtbmFtZS1xdW90ZQorCQkJCQkJICAgIChleHBhbmQtZmlsZS1uYW1lCisJ CQkJCQkgICAgIGRlZmF1bHQtZGlyZWN0b3J5KSkKKwkJCQkJCSAgIGFyZykpKSkKKwkJCShzZXRx IGFyZ3MgKGNkciBhcmdzKSkpCisJCSAgICA7OyBpZiBhbnkgb2YgdGhlIGFyZ3VtZW50cyBhcmUg ZmxhZ2dlZCBhcyBudW1iZXJzCisJCSAgICA7OyB3YWl0aW5nIGZvciBjb252ZXJzaW9uLCBjb252 ZXJ0IHRoZW0gbm93CiAJCSAgICAod2hpbGUgYXJncwogCQkgICAgICAobGV0ICgoYXJnIChjYXIg YXJncykpKQogCQkJKGlmIChhbmQgKHN0cmluZ3AgYXJnKQotLSAKMi4xNy4xCgo= --=-Eh3fWDD7BlFLgkiogzID--