all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Phil Sainty <psainty@orcon.net.nz>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org, kaushal.modi@gmail.com
Subject: Re: Help using the right hook for loading theme on emacs daemon GUI
Date: Fri, 25 Jan 2019 14:42:53 +1300	[thread overview]
Message-ID: <96a9c5ec62a7325429555fe939392450@webmail.orcon.net.nz> (raw)
In-Reply-To: <d02170ec28cf9bbc2bfd9f9a50bdf269@webmail.orcon.net.nz>

On 2019-01-25 10:16, Phil Sainty wrote:
> I was already thinking that the `after-make-frame-functions' docstring
> could use some additional information (it seems to be a common point
> of confusion when people start using --daemon)

I forgot to add -- the point I originally thought this docstring needed
to make was that FRAME will not be selected when the hook runs, and it 
is
up to the function to select it if required.

I'd be inclined to have the docstring suggest that the following be used
in that scenario:

(with-selected-frame FRAME
   ...)

This is rather more apparent when one looks at the documentation for
`make-frame' itself, but people won't necessarily feel the need to do
that; and while one can *guess* that this may be the case from the fact
that FRAME is being passed to the hook at all, I think it would be 
better
to make it explicit in the hook documentation.


-Phil




  reply	other threads:[~2019-01-25  1:42 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-17 15:44 Help using the right hook for loading theme on emacs daemon GUI Kaushal Modi
2019-01-17 15:49 ` Kaushal Modi
2019-01-17 15:55   ` Eli Zaretskii
2019-01-17 16:04     ` Kaushal Modi
2019-01-17 19:28       ` Daniel Colascione
2019-01-17 18:33 ` martin rudalics
2019-01-17 20:02   ` Kaushal Modi
2019-01-17 21:50 ` Eli Zaretskii
2019-01-22 20:25   ` Kaushal Modi
2019-01-18  3:47 ` Phil Sainty
2019-01-22 20:27   ` Kaushal Modi
2019-01-23 22:00     ` Phil Sainty
2019-01-24  3:47     ` Phil Sainty
2019-01-24 14:11       ` Eli Zaretskii
2019-01-24 19:17         ` Phil Sainty
2019-01-24 19:44           ` Eli Zaretskii
2019-01-24 21:16             ` Phil Sainty
2019-01-25  1:42               ` Phil Sainty [this message]
2019-01-25  7:20                 ` Eli Zaretskii
2019-01-25  7:13               ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=96a9c5ec62a7325429555fe939392450@webmail.orcon.net.nz \
    --to=psainty@orcon.net.nz \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=kaushal.modi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.