landmark.el

landmark.el

[Brannon, Terrence]

[-- Attachment #1: Type: text/plain, Size: 1172 bytes --]

Hello, I am the original author of landmark.el -

I would like to provide some edits to the Full description we see at http://elpa.gnu.org/packages/landmark.html

Apparently this would be done by supplying a pull request to the actual source code - http://git.savannah.gnu.org/cgit/emacs/elpa.git/tree/packages/landmark/landmark.el

But I am not aware of how to initiate such a process. Please advise on how to proceed.


Terrence Brannon
(818) 359-0893 [mobile]
(303) 768-4275 [desk phone]
This sentence is false<https://en.wikipedia.org/wiki/G%C3%B6del,_Escher,_Bach>.

This e-mail transmission may contain information that is proprietary, privileged and/or confidential and is intended exclusively for the person(s) to whom it is addressed. Any use, copying, retention or disclosure by any person other than the intended recipient or the intended recipient's designees is strictly prohibited. If you are not the intended recipient or their designee, please notify the sender immediately by return e-mail and delete all copies. OppenheimerFunds may, at its sole discretion, monitor, review, retain and/or disclose the content of all email communications.

[-- Attachment #2: Type: text/html, Size: 4249 bytes --]

Re: landmark.el

[Stefan Monnier]

> I would like to provide some edits to the Full description we see at
> http://elpa.gnu.org/packages/landmark.html
>
> Apparently this would be done by supplying a pull request to the actual
> source code -

You can send a patch here or via M-x report-emacs-bug (or directly to me).


        Stefan

RE: landmark.el

[Brannon, Terrence]

-----Original Message-----
From: Emacs-devel [mailto:emacs-devel-bounces+tbrannon.contractor=ofiglobal.com@gnu.org] On Behalf Of Stefan Monnier
Sent: Thursday, December 6, 2018 5:38 PM
To: emacs-devel@gnu.org
Subject: Re: landmark.el [ EXTERNAL ]

> I would like to provide some edits to the Full description we see at 
> https://urldefense.proofpoint.com/v2/url?u=http-3A__elpa.gnu.org_packa
> ges_landmark.html&d=DwIBAg&c=huW-Z3760n7oNORvLCN2eBo-Ehm9Q_bNeNJaAMovB
> jQ&r=uvXYcBD4O7n5Ah7cexUTOH7HUSodf0nzeN28F7OKuAxMhDsehRnahd_yZf-XdItD&
> m=PmF4jAwV81WZV7zgW48Napnf_K7g2FkuV_y4AH8pVLU&s=M1uQx1mJCjOH-xScnPfxdz
> uhLZmHUDJjGiOJrfQLaIw&e=
>
> Apparently this would be done by supplying a pull request to the 
> actual source code -

>> You can send a patch here or via M-x report-emacs-bug (or directly to me).

c:\prg\landmark>git diff landmark.el 
git diff landmark.el 
diff --git a/landmark.el b/landmark.el
index 9b48901..b1ffd8a 100644
--- a/landmark.el
+++ b/landmark.el
@@ -2,7 +2,7 @@
 
 ;; Copyright (C) 1996-1997, 2000-2016 Free Software Foundation, Inc.
 
-;; Author: Terrence Brannon (was: <brannon@rana.usc.edu>)
+;; Author: Terrence Brannon <metaperl@gmail.com>
 ;; Created: December 16, 1996 - first release to usenet
 ;; Keywords: games, neural network, adaptive search, chemotaxis
 ;; Maintainer: emacs-devel@gnu.org
@@ -34,7 +34,7 @@
 ;; the smell of the tree increases, then the weights in the robot's
 ;; brain are adjusted to encourage this odor-driven behavior in the
 ;; future. If the smell of the tree decreases, the robots weights are
-;; adjusted to discourage a correct move.
+;; adjusted to discourage that odor-driven behavior.
 
 ;; In laymen's terms, the search space is initially flat. The point
 ;; of training is to "turn up the edges of the search space" so that
@@ -51,6 +51,13 @@
 ;; a single move, one moves east,west and south, then both east and
 ;; west will be improved when they shouldn't
 
+;; The source code was developed as part of a course on Brain Theory
+;; and Neural Networks at the University of Southern California. The
+;; original problem description and solution appeared in 1981 in the
+;; paper "Landmark Learning: An Illustration of Associative
+;; Search" authored by Andrew G. Barto and Richard S. Sutton and
+;; published to Biological Cybernetics.
+
 ;; Many thanks to Yuri Pryadkin <yuri@rana.usc.edu> for this
 ;; concise problem description.



This e-mail transmission may contain information that is proprietary, privileged and/or confidential and is intended exclusively for the person(s) to whom it is addressed. Any use, copying, retention or disclosure by any person other than the intended recipient or the intended recipient's designees is strictly prohibited. If you are not the intended recipient or their designee, please notify the sender immediately by return e-mail and delete all copies. OppenheimerFunds may, at its sole discretion, monitor, review, retain and/or disclose the content of all email communications.

Re: landmark.el

[Eli Zaretskii]

> From: "Brannon, Terrence" <tbrannon.contractor@ofiglobal.com>
> Date: Fri, 7 Dec 2018 22:02:54 +0000
> 
> -----Original Message-----
> From: Emacs-devel [mailto:emacs-devel-bounces+tbrannon.contractor=ofiglobal.com@gnu.org] On Behalf Of Stefan Monnier
> Sent: Thursday, December 6, 2018 5:38 PM
> To: emacs-devel@gnu.org
> Subject: Re: landmark.el [ EXTERNAL ]
> 
> > I would like to provide some edits to the Full description we see at 
> > https://urldefense.proofpoint.com/v2/url?u=http-3A__elpa.gnu.org_packa
> > ges_landmark.html&d=DwIBAg&c=huW-Z3760n7oNORvLCN2eBo-Ehm9Q_bNeNJaAMovB
> > jQ&r=uvXYcBD4O7n5Ah7cexUTOH7HUSodf0nzeN28F7OKuAxMhDsehRnahd_yZf-XdItD&
> > m=PmF4jAwV81WZV7zgW48Napnf_K7g2FkuV_y4AH8pVLU&s=M1uQx1mJCjOH-xScnPfxdz
> > uhLZmHUDJjGiOJrfQLaIw&e=
> >
> > Apparently this would be done by supplying a pull request to the 
> > actual source code -
> 
> >> You can send a patch here or via M-x report-emacs-bug (or directly to me).

Thanks, pushed.

landmark.el

[Stefan Monnier]

Can someone explain to me what does M-x landmark do?
Has someone used it?
The mode's docstring is a copy of gomoku's docstring, but the
"Commentary" indicates it's actually doing something very different.
Yet it seems, some of gomoku's code was not deactivated, so after
middle-clicking a few times I got a result that looked like I was
playing gomoku (with a diagonal drawn through 5 consecutive points, tho
that seemed to mess up the display at least to my untrained eye).

The history of the file looks like "initial install, then application of
global cosmetic changes".  Non-cosmetic changes have been extremely
rare.  I only found:

   revno: 18291
   committer: Karl Heuer <kwzh@gnu.org>
   timestamp: Wed 1997-06-18 04:23:02 +0000
   message:
     (lm-display-statistics): Display stats in mode line.
     (lm-number-of-trials, lm-sum-of-moves): New vars.
     Various doc fixes.


-- Stefan

Re: landmark.el

[Glenn Morris]

AFAICS, it works in 22.3, but has been broken since 23.1.
(So that tells you how much use it gets.)
I think I fixed it in emacs-24.
I have no idea what the point of this being in Emacs is, beyond
running it once and going "huh, that's vaguely neat".

Re: landmark.el

[Glenn Morris]

PS I think it uses the gomoku board to do its thing.
But has it just blindly copied a bunch of other stuff from gomoku.el
that makes no sense in the context of landmark (landmark-human-plays
etc)? Or does it somehow allow you to play gomoku against this learning
robot thing? This I have no idea...

Re: landmark.el

[Glenn Morris]

PPS it is MUCH slower in 24.3.91 than in 22.3.

time emacs-22.3 -Q --eval '(progn (lm-test-run) (kill-emacs))'

takes ~ 6 seconds.

In current Emacs, it takes ~ 4-5 x longer.

Re: landmark.el

[Glenn Morris]

Should it be obsoleted?
It's not a game you can play, it has nothing to do with text editing,
it was broken for 6+ years and no-one noticed.
AFAICS, it's a demonstration of a programming technique more than
anything else.

Re: landmark.el

[Leo Liu]

On 2014-06-29 19:41 -0400, Glenn Morris wrote:
> Should it be obsoleted?
> It's not a game you can play, it has nothing to do with text editing,
> it was broken for 6+ years and no-one noticed.

Indeed, I just ran it.

> AFAICS, it's a demonstration of a programming technique more than
> anything else.

I think it is worth keeping it even just to show off to friends or
colleagues, I mean showcase emacs features.

Leo

Re: landmark.el

[Glenn Morris]

Leo Liu wrote:

> I think it is worth keeping it even just to show off to friends or
> colleagues, I mean showcase emacs features.

"Emacs contains large amounts of old, irrelevant cruft that is often
poorly maintained, and can be broken for years before anyone notices" is
not the best advert IMO.

Re: landmark.el

[Stefan Monnier]

> Should it be obsoleted?

I was thinking of moving it straight to GNU ELPA.


        Stefan

Re: landmark.el

[Glenn Morris]

Stefan Monnier wrote:

>> Should it be obsoleted?
>
> I was thinking of moving it straight to GNU ELPA.

Sounds good.