From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#70068: [PATCH] Don't warn about lexical binding in lisp-interaction-mode Date: Tue, 9 Apr 2024 12:45:18 +0200 Message-ID: <963F9A52-9903-426A-A505-2CF7F7F315F8@gmail.com> References: <2FB192D4-40E7-4327-BC0E-62674C2C1A03@gmail.com> <8734s2cnv7.fsf@posteo.net> <6246FE18-7962-40F0-807F-1ABE8F9D2A25@gmail.com> <93A70615-823B-4369-BE17-128EEA430ADA@gmail.com> <87y19o2ubc.fsf@posteo.net> <8634rwytcq.fsf@gnu.org> <7FFED798-8839-43D4-9629-E087A6DFE0D0@gmail.com> <86msq2x3r4.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1210"; mail-complaints-to="usenet@ciao.gmane.io" Cc: philipk@posteo.net, monnier@iro.umontreal.ca, 70068@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Apr 09 12:46:20 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ru8zc-00005W-4t for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Apr 2024 12:46:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ru8zE-0006cJ-Qv; Tue, 09 Apr 2024 06:45:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ru8zD-0006c2-BW for bug-gnu-emacs@gnu.org; Tue, 09 Apr 2024 06:45:55 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ru8zC-0001VQ-Ra for bug-gnu-emacs@gnu.org; Tue, 09 Apr 2024 06:45:55 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ru8zK-0005dV-Pn for bug-gnu-emacs@gnu.org; Tue, 09 Apr 2024 06:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Apr 2024 10:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70068 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 70068-submit@debbugs.gnu.org id=B70068.171265953518944 (code B ref 70068); Tue, 09 Apr 2024 10:46:02 +0000 Original-Received: (at 70068) by debbugs.gnu.org; 9 Apr 2024 10:45:35 +0000 Original-Received: from localhost ([127.0.0.1]:48439 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ru8yt-0004uP-9A for submit@debbugs.gnu.org; Tue, 09 Apr 2024 06:45:35 -0400 Original-Received: from mail-lj1-x236.google.com ([2a00:1450:4864:20::236]:61711) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ru8yr-0004Zz-Lm for 70068@debbugs.gnu.org; Tue, 09 Apr 2024 06:45:34 -0400 Original-Received: by mail-lj1-x236.google.com with SMTP id 38308e7fff4ca-2d8b194341eso2193871fa.3 for <70068@debbugs.gnu.org>; Tue, 09 Apr 2024 03:45:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712659520; x=1713264320; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=LmfY2bDB7He7Rh9jZY63r/0myxl/13tU9bFEsanUWc0=; b=gm/fnsuBShktgTFQkC21dFCgy6NaKEoICmr2/cpcmawbNfGMbYs6BvPEqnNGrGOlzB EGp94l2NG/tld4NDp9J/eRZU2SyL3Rf8TS7+zQjvNAYBuzL+m5iQrGhnn43jRiMRTkwz cK4HDRCgfeVC1mPwQkNLUSmj+LGKI9YJL8M9pqxU1eonvdGSAGgIsctnsFjPP0easWuV OTtfnYGeczM2DveLA1o0fB0C4XbMvli4G3BnAlSUfP8YwPa9d9vPYKjD1pMf9PP2vqtR RXXfgkrhvDtJjQEetmS6dEuwEanSIohH0ARRsyuWx15QHp89Q2R4JjK7JSACjQ3wT4GW O1iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712659520; x=1713264320; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=LmfY2bDB7He7Rh9jZY63r/0myxl/13tU9bFEsanUWc0=; b=eVm7iS4/lTMUq2UdGg3MUlSUby87pJeJUMU/tsjCAXTkWl69LpOgXLHtxvX+gahQOJ u6DhhNy0TPPUwAhUa3pv5NYJoVwPwnkNKlZQ70eRTSN3Rap/RtFfYvxFUQ0MctlMC32Q 5VRl97ZneWH2Zy26+9eAzLgX/jGyui1rruqYx7RGa+6owxL1kgF/WjR1KeNBy4ukUxm4 lKHrIUutQqhX+bRtIYq0PuHt8ypKVlgdvTnsf1S0OLM3v9TSknRw8O+yyYBDnzEh/uo2 CvOlZzk/ZG5fQhpg6O6U6o3IB0bbODpYy1FmlCIWYEw2hU5SbbhzGVvKVKbZkalGJTTA Pbpw== X-Forwarded-Encrypted: i=1; AJvYcCVjIIccqsuClxFKj/bLOkCB/BdPdqHDTk27qJWbaP7Z7jqj1CgTdZ9YWKK91HjeZABcubAGk/OfU04KKmxvD2E9fj1QVCQ= X-Gm-Message-State: AOJu0YwxJayHAduuNzG1Y+1QbXf1AzRzsM5ANhtPdkLTXx0F4XQDS4Uz BhNd3rRM5KIAJK6evpb4By/iekNo+0rU9HnsScM9XwY6FRTIUZ1CCvV9NjKI X-Google-Smtp-Source: AGHT+IHENZP1Fp4W5Nx8Edsrh0jAy11wWeqe6hsFJxy7neHxgTrgE93O9zXm/RDq4uNt2Z/JxYhskg== X-Received: by 2002:a2e:330e:0:b0:2d8:7a75:9452 with SMTP id d14-20020a2e330e000000b002d87a759452mr5903744ljc.29.1712659519449; Tue, 09 Apr 2024 03:45:19 -0700 (PDT) Original-Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id z6-20020a2ebe06000000b002d865254e49sm1469386ljq.16.2024.04.09.03.45.18 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Apr 2024 03:45:18 -0700 (PDT) In-Reply-To: <86msq2x3r4.fsf@gnu.org> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:282985 Archived-At: 9 apr. 2024 kl. 11.51 skrev Eli Zaretskii : >> Looks like option 3 won. Actually I implemented option 3' which is = like 3 but checks the mode instead of lexical-binding, on the grounds = that a user who damages his lexical cookie by mistake wants to be = reminded of it as soon as possible. >=20 > That's not what I see in the changes you installed on master. Then I made a mistake, but I don't see where. The intent is to have = flymake add the argument --eval (setq bytecomp--inhibit-lexical-cookie-warning t) if (derived-mode-p 'lisp-interaction-mode) is true, and then make the = warning conditional on that variable. Doesn't it work? What I can see is an unrelated bug in flymake: if the first line of a = buffer (of an .el file) is empty, then the compiler emits a lexical = cookie warning but flymake doesn't show it. Stefan, is this because = there is no text to attach the warning to?