From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler Newsgroups: gmane.emacs.bugs Subject: bug#67034: 30.0.50; Make `derived-mode-p` take a single arg Date: Fri, 10 Nov 2023 13:18:32 +0100 Message-ID: <96367d39-4861-41e6-9383-a9a18efa0678@daniel-mendler.de> References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2656"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird To: 67034@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 10 13:19:38 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r1QU5-0000T2-MX for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 10 Nov 2023 13:19:37 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r1QTt-0008BP-7b; Fri, 10 Nov 2023 07:19:25 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r1QTr-0008BF-A8 for bug-gnu-emacs@gnu.org; Fri, 10 Nov 2023 07:19:23 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r1QTq-0002X2-V7 for bug-gnu-emacs@gnu.org; Fri, 10 Nov 2023 07:19:22 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r1QUU-0007qI-Cc for bug-gnu-emacs@gnu.org; Fri, 10 Nov 2023 07:20:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Daniel Mendler Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 Nov 2023 12:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67034 X-GNU-PR-Package: emacs Original-Received: via spool by 67034-submit@debbugs.gnu.org id=B67034.169961876530094 (code B ref 67034); Fri, 10 Nov 2023 12:20:02 +0000 Original-Received: (at 67034) by debbugs.gnu.org; 10 Nov 2023 12:19:25 +0000 Original-Received: from localhost ([127.0.0.1]:49660 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r1QTs-0007pK-OC for submit@debbugs.gnu.org; Fri, 10 Nov 2023 07:19:25 -0500 Original-Received: from server.qxqx.de ([2a01:4f8:121:346::180]:44033 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r1QTn-0007p1-E0 for 67034@debbugs.gnu.org; Fri, 10 Nov 2023 07:19:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:Subject:From:To: MIME-Version:Date:Message-ID:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ZUWJxixitztV1J6XYMZopn8mGrcGrggOvBnuuWHeikY=; b=Tv5lQg5FojG3KPqCfQnJkHGTjB RH9iCbeJrpPnZLHvEJe7+AgYPrZSpPpjxCKbIuwtJU8GUweE+Unt43+cz6Hs/vpOYZ7gpJymJbs2B e+TsmJmiwGOeE/QhvGVq1P7KP5q1F+W4D0UpX5eCXPvbGsKGfuY0sAmYVIQR1rjFRW5s=; Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274109 Archived-At: This change would affect many packages. I grepped through my elpa directory and found multiple uses of derived-mode-p and provided-mode-derived-p with multiple arguments as shortcuts: (derived-mode-p 'mode1 'mode2) instead of (or (derived-mode-p 'mode1) (derived-mode-p 'mode2) There are also multiple call sites with apply, but these would be arguably nicer if derived-mode-p takes a list argument as proposed. Still, do the benefits of this change outweigh the required changes?