From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#51215: Add a navigation feature to vc and diff mode: diff-goto-line Date: Mon, 18 Oct 2021 04:56:31 +0300 Message-ID: <9618968c-f3f4-da4f-4dba-e34a88036ced@yandex.ru> References: <87k0ifpcc2.fsf@mat.ucm.es> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8893"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 Cc: Davis Herring To: Uwe Brauer , 51215@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 18 03:57:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mcHtn-00027a-53 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 18 Oct 2021 03:57:11 +0200 Original-Received: from localhost ([::1]:33626 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mcHtk-0003Rc-JK for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 17 Oct 2021 21:57:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54038) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mcHte-0003RC-1y for bug-gnu-emacs@gnu.org; Sun, 17 Oct 2021 21:57:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33953) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mcHtd-0003ND-Pg for bug-gnu-emacs@gnu.org; Sun, 17 Oct 2021 21:57:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mcHtd-0005Vj-OP for bug-gnu-emacs@gnu.org; Sun, 17 Oct 2021 21:57:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Oct 2021 01:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51215 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51215-submit@debbugs.gnu.org id=B51215.163452220121147 (code B ref 51215); Mon, 18 Oct 2021 01:57:01 +0000 Original-Received: (at 51215) by debbugs.gnu.org; 18 Oct 2021 01:56:41 +0000 Original-Received: from localhost ([127.0.0.1]:45499 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcHtJ-0005V1-2I for submit@debbugs.gnu.org; Sun, 17 Oct 2021 21:56:41 -0400 Original-Received: from mail-lf1-f41.google.com ([209.85.167.41]:42619) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcHtG-0005Uj-F2 for 51215@debbugs.gnu.org; Sun, 17 Oct 2021 21:56:40 -0400 Original-Received: by mail-lf1-f41.google.com with SMTP id x27so63598653lfa.9 for <51215@debbugs.gnu.org>; Sun, 17 Oct 2021 18:56:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=yo1EtRHw/I5INnz9E6v3vemFhCQyfXNUJlRkgMAXcyg=; b=WzwF0pr425vL7wogtNXpUmNBceC3PBS13wz9phTI/KRe1Osi/Lw5Q1HxhHWWlxd658 buuqMyL7EirSQwUyr7qNS1djfRT+Z+/UcXbb3HyjCDS6L32VoybxQw/wrBh/EFoPvCd9 GrcvGVFwfYZMAjETyuFj4m8c2uITxcv6Dg8tB7Wn1v+LwMDyzYOruemrDPZX0B+v5bfg 5iQU6pvA2CFefS8lNtA574FgeTJkdzdb+I5DRYOB6MJWL3l65u9tsumD5iCqg3PNIzKk 2yaTBkFo1NJHU7Ntzj/7QpYYQRa12bg7GNicQFqk5XX7OsHBlbeeWxp0lOFYLJeTRvDz h63w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=yo1EtRHw/I5INnz9E6v3vemFhCQyfXNUJlRkgMAXcyg=; b=W3rn2rDdDNUE0rIYFWeM6qgFMN8O26QbHUDtHPj10q3fY9j5eg2bDBOSdrW32Xa1AX kNZW4sVrDGKWP5VQFEhZf+Oem3tUcuwiXlqXlkqaj/vGMz4IikIKvF+NHE07pNYuS9f5 24ge9tweNOy5e5NJ9HtM2fJWOiGfzdbp/U7YRGXSqSlGAWUKtJtG2+pjbwZgZxIP+1ur 8c6ZYJk5NNtjVoeWr0VbjveP9jFLKQY0hVd2CyjwqpyBdK3S9yodnXE82J9hlYuRX/ZV 33PgYBgdMRkRzDHPJIidKilmZK6WpRytw7OVWJ6HtBmaTETwizE15P7CTRw8N3K+hABW uL5g== X-Gm-Message-State: AOAM5300nMPQz6HZpVmz9VLUbhF8tedl2KMDFpgBBlh8iGOEPPIC5oqP UmuhbVtHwfBSglmW/PSEi/4= X-Google-Smtp-Source: ABdhPJySDe9pCgHpaUR+63Xyfx7Ze14P54azXduAHVedFHnw69wP3v908q6ht92BXoZJI0gTVq6hpg== X-Received: by 2002:a05:6512:108b:: with SMTP id j11mr26904308lfg.441.1634522192314; Sun, 17 Oct 2021 18:56:32 -0700 (PDT) Original-Received: from [192.168.0.103] ([5.18.248.29]) by smtp.googlemail.com with ESMTPSA id h1sm56699lfu.277.2021.10.17.18.56.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 17 Oct 2021 18:56:32 -0700 (PDT) In-Reply-To: <87k0ifpcc2.fsf@mat.ucm.es> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:217440 Archived-At: Hi Uwe, On 14.10.2021 23:42, Uwe Brauer wrote: > I became very interested in that feature and was not able to install > Davis's second patch (most likely to many changes in the last 5 years) > > His first patch, however, I could still apply and I tested it (using > mercurial) almost for a year and it worked flawlessly for me. > > That is why I strongly recommend to apply the patch, then > > 1. Either errors are found and these will be corrected or the patch removed > 2. Or even better the feature will enhanced > > But I think to reject the patch, again, would not be a bit of a shame. The most recent discussion regarding it can be found in bug#36526. To sum up: the patch(es) have merit, and they're waiting for someone to champion their inclusion: test them for bugs, compare the different available implementations of the "skip to" functionality, and generally examine how the new functionality affects the existing workflows (e.g. whether it should be enabled on root diffs).