From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: Development suggestions from an ENSIME developer Date: Fri, 22 Jul 2016 01:04:04 +0300 Message-ID: <95d8dbc7-7d54-0dbc-c640-ab0903307d71@yandex.ru> References: <87wpke3kdj.fsf@russet.org.uk> <83h9biyek4.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1469138663 1811 80.91.229.3 (21 Jul 2016 22:04:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 21 Jul 2016 22:04:23 +0000 (UTC) Cc: Phillip Lord , emacs-devel@gnu.org To: Stefan Monnier , Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jul 22 00:04:20 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bQM4p-0006Aq-Lj for ged-emacs-devel@m.gmane.org; Fri, 22 Jul 2016 00:04:19 +0200 Original-Received: from localhost ([::1]:43919 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQM4o-0000Kx-Ma for ged-emacs-devel@m.gmane.org; Thu, 21 Jul 2016 18:04:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39821) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQM4i-0000Kr-Se for emacs-devel@gnu.org; Thu, 21 Jul 2016 18:04:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bQM4e-0007WT-Hq for emacs-devel@gnu.org; Thu, 21 Jul 2016 18:04:12 -0400 Original-Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]:33341) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQM4e-0007WO-B1; Thu, 21 Jul 2016 18:04:08 -0400 Original-Received: by mail-wm0-x243.google.com with SMTP id o80so3883916wme.0; Thu, 21 Jul 2016 15:04:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=wpw4S6pcYxc2MwOIzrsPuCeo9nA5oiGYbydv33RdZOM=; b=d1q57FcEcus6Q+PA9TrHju8Hrb4mBdWQHMUDGA+GHonFkw1JrvrGfFMavvsXOKzXwG 3mRM2zovL9+0O5Aj9tk3PNE53aNtRQ5CCZvsQ/rkOE+ZST+0I0mrmvuxk2LrkpMJTyF9 /UYHO3H1jSABLGgFd5MYvO4UtBFss8ZpvR3qb6RX7Y5781otwBQclvk0JLwHmyJQ7NI7 pYFwxKe9ynB9iw/0qxZNuOk9lmYJoGiB7QLkCYGCT+LSrWV8cKH+qpmLIlB7HKciIFH3 +uL7guth7LjyOA6uphcEpJfcq0o/uIvRKKTP8kprX24KT9MhcoQgQf5iywTSPGvIudcV MKCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=wpw4S6pcYxc2MwOIzrsPuCeo9nA5oiGYbydv33RdZOM=; b=OimfA+PoXQW1jnzo9L6qo0TJlmUsWoHKFHkBKHdnT6sxU0XlN6d44LsaBvWOCb/5q2 Ygf19vdasalyPtQrv2TLkG703cPysUFnreo3JBQ4Abf2bDWTQp7jcyCezpsJjTIt4bz0 7DgaHCXsDJ6WXS2fKcxCHiEdpJEGv6XEPM7sHflIY8yLhKwUFxDOVNPehZmI1kSLPWIA BtWMQKi4UEYHfTYw9G2aGHI9cpEIM0HZO6Xqvbh6gGvyKrtKttLTYliVal+M4oJV6aF0 WtVS3izfpD17R1VM8GdJGnfI6OCL4wbMreIU4mzoGREyEahwTsW55Nm2DDVTnfTutmDM atjg== X-Gm-Message-State: AEkoouvZkGSJV7BIgrQkyXP9ygHKY3SCi+yT6TGNmcES3bPCoNMRlCAN1f/aRqohKMsQTA== X-Received: by 10.28.223.9 with SMTP id w9mr697822wmg.65.1469138647568; Thu, 21 Jul 2016 15:04:07 -0700 (PDT) Original-Received: from [192.168.1.2] ([185.105.173.135]) by smtp.googlemail.com with ESMTPSA id g184sm7564888wme.15.2016.07.21.15.04.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Jul 2016 15:04:06 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:47.0) Gecko/20100101 Thunderbird/47.0 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::243 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:206003 Archived-At: On 07/21/2016 11:22 PM, Stefan Monnier wrote: >> Also, I think the solution should support text-mode browsers, such as >> Lynx or Emacs's eww on TTY frames. IOW, anything that requires GUI >> and won't work otherwise is probably out of question to begin with. >> (This requirement is not for me personally.) > > Hopefully a pull-request can appear as a Git branch, so the maintainer > who can't or doesn't want to use a browser can use "git diff/merge" and > such to view and accept a pull-request. There is always a branch associated with the request, yes. And also, when you merge the branch using the command line and push, that closes the pull/merge request automatically. (BTW, in Gitlab parlance these are called "merge requests", not "pull requests", since, unlike on Github, the branch-to-merge is always in the same repository). > To review/comment on a pull-request, you'll need something else, and > typically this is a web UI. Most/all of those are pretty much unusable in > something like eww/lynx. But there's a good chance someone can code up > an ad-hoc Emacs interface to the system (something like sx.el). A brief search of existing projects points to https://github.com/nlamirault/emacs-gitlab. It doesn't seem to support commenting on pull requests so far, though, and we might have to add a "standard" UI instead of ones using Helm or Ivy.