From: Dmitry Gutov <dgutov@yandex.ru>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>, Eli Zaretskii <eliz@gnu.org>
Cc: Phillip Lord <phillip.lord@russet.org.uk>, emacs-devel@gnu.org
Subject: Re: Development suggestions from an ENSIME developer
Date: Fri, 22 Jul 2016 01:04:04 +0300 [thread overview]
Message-ID: <95d8dbc7-7d54-0dbc-c640-ab0903307d71@yandex.ru> (raw)
In-Reply-To: <jwvh9birbkb.fsf-monnier+Inbox@gnu.org>
On 07/21/2016 11:22 PM, Stefan Monnier wrote:
>> Also, I think the solution should support text-mode browsers, such as
>> Lynx or Emacs's eww on TTY frames. IOW, anything that requires GUI
>> and won't work otherwise is probably out of question to begin with.
>> (This requirement is not for me personally.)
>
> Hopefully a pull-request can appear as a Git branch, so the maintainer
> who can't or doesn't want to use a browser can use "git diff/merge" and
> such to view and accept a pull-request.
There is always a branch associated with the request, yes. And also,
when you merge the branch using the command line and push, that closes
the pull/merge request automatically.
(BTW, in Gitlab parlance these are called "merge requests", not "pull
requests", since, unlike on Github, the branch-to-merge is always in the
same repository).
> To review/comment on a pull-request, you'll need something else, and
> typically this is a web UI. Most/all of those are pretty much unusable in
> something like eww/lynx. But there's a good chance someone can code up
> an ad-hoc Emacs interface to the system (something like sx.el).
A brief search of existing projects points to
https://github.com/nlamirault/emacs-gitlab.
It doesn't seem to support commenting on pull requests so far, though,
and we might have to add a "standard" UI instead of ones using Helm or Ivy.
next prev parent reply other threads:[~2016-07-21 22:04 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-20 13:54 Development suggestions from an ENSIME developer Lars Ingebrigtsen
2016-07-20 14:02 ` Clément Pit--Claudel
2016-07-22 22:48 ` Robert Cochran
2016-07-23 7:30 ` Eli Zaretskii
2016-07-23 9:00 ` Lars Ingebrigtsen
2016-07-23 19:52 ` Richard Stallman
2016-07-23 13:50 ` Clément Pit--Claudel
2016-07-23 20:14 ` Phillip Lord
2016-07-25 18:34 ` Robert Cochran
2016-08-03 6:05 ` John Wiegley
2016-08-06 18:42 ` Alex Dunn
2016-07-20 14:03 ` Dmitry Gutov
2016-07-20 14:08 ` Lars Ingebrigtsen
2016-07-20 14:12 ` Dmitry Gutov
2016-07-20 14:23 ` Christian Kruse
2016-07-20 14:41 ` Dmitry Gutov
2016-07-20 14:30 ` Christian Kruse
2016-07-20 14:44 ` Lars Ingebrigtsen
2016-07-20 15:02 ` Clément Pit--Claudel
2016-07-20 15:07 ` Lars Ingebrigtsen
2016-07-20 15:31 ` Clément Pit--Claudel
2016-07-20 17:00 ` Stefan Monnier
2016-07-21 18:40 ` Phillip Lord
2016-07-21 19:30 ` Eli Zaretskii
2016-07-21 20:22 ` Stefan Monnier
2016-07-21 21:26 ` Christian Kruse
2016-07-21 22:04 ` Dmitry Gutov [this message]
2016-07-21 20:23 ` Phillip Lord
2016-07-21 20:50 ` joakim
2016-07-22 6:59 ` Eli Zaretskii
2016-07-22 10:46 ` Lars Ingebrigtsen
2016-07-22 11:48 ` Lars Ingebrigtsen
2016-07-22 13:00 ` Robert Weiner
2016-07-22 13:34 ` Eli Zaretskii
2016-07-22 14:28 ` Robert Weiner
2016-07-22 14:45 ` Ted Zlatanov
2016-07-22 13:35 ` Stefan Monnier
2016-07-22 14:38 ` Eli Zaretskii
2016-07-22 14:56 ` Stefan Monnier
2016-07-22 15:58 ` Phillip Lord
2016-07-22 15:47 ` Phillip Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95d8dbc7-7d54-0dbc-c640-ab0903307d71@yandex.ru \
--to=dgutov@yandex.ru \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@IRO.UMontreal.CA \
--cc=phillip.lord@russet.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.