From: Paul Eggert <eggert@cs.ucla.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Emacs development discussions <emacs-devel@gnu.org>
Subject: pdumper memory allocation (new FIXME)
Date: Thu, 31 Jan 2019 08:07:01 -0800 [thread overview]
Message-ID: <95d4aa4e-bf2f-d18a-9906-95ab5056f065@cs.ucla.edu> (raw)
While making minor simplifications to src/pdumper.c I noticed that
pdumper_load has a comment saying it should not call xmalloc, and yet it
calls xstrdup which works by calling xmalloc. I added a FIXME to point
out the inconsistency.
The call to xstrdup was added in 2019-01-26T10:08:56!eliz@gnu.org
(a7974933dd818194de3c9387b95dbd122bcf506c), whose commit message says
"Use xstrdup instead of strdup, as on MS-Windows the latter uses the
wrong heap." I thought that with pdumper we no longer have a hybrid
malloc with two heaps; we simply have the usual C heap. Is that not true
in MS-Windows for some reason? I'm asking because if there are still
multiple heaps with pdumper (either on MS-Windows or elsewhere), I
suspect there will be similar problems elsewhere in the code.
next reply other threads:[~2019-01-31 16:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 16:07 Paul Eggert [this message]
2019-01-31 16:58 ` pdumper memory allocation (new FIXME) Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95d4aa4e-bf2f-d18a-9906-95ab5056f065@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.