From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] `completing-read`: Add `group-function` support to completion metadata (REVISED PATCH VERSION 2) Date: Fri, 30 Apr 2021 20:13:00 +0200 Message-ID: <95ac7ef3-5e8c-fc58-b316-544096c82aa0@daniel-mendler.de> References: <0bbdeece-90d5-160c-07ec-2ad8edbf9872@daniel-mendler.de> <87czudm7bv.fsf@mail.linkov.net> <976056e8-3d46-db27-32c2-ddf3ca32d5a7@daniel-mendler.de> <878s5090e9.fsf@mail.linkov.net> <69fd42ed-a1a0-adcb-ac8b-caad80cb0967@daniel-mendler.de> <878s4zzpvc.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26547"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Gregory Heytings , Dmitry Gutov , Stefan Monnier , "emacs-devel@gnu.org" To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Apr 30 20:17:03 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lcXhH-0006my-Gg for ged-emacs-devel@m.gmane-mx.org; Fri, 30 Apr 2021 20:17:03 +0200 Original-Received: from localhost ([::1]:35664 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lcXhF-0006VG-W2 for ged-emacs-devel@m.gmane-mx.org; Fri, 30 Apr 2021 14:17:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52136) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lcXda-0004si-Td for emacs-devel@gnu.org; Fri, 30 Apr 2021 14:13:14 -0400 Original-Received: from server.qxqx.de ([2a01:4f8:121:346::180]:32857 helo=mail.qxqx.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lcXdQ-0005m3-E4 for emacs-devel@gnu.org; Fri, 30 Apr 2021 14:13:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=7DlvzDoz6X3N8SKojGcmb3LOOcvi8P3sIImfYhFhAZg=; b=nRr5VEcHzJENjxz3cADrfwvvLq CdVV831UPIUp0s94MViLKV41xsyTmXFLmqOU7DsrE2Ir7UyvgqtGEU5J+9ZS0KeglDIa+MlLR1cIv zoLH96ER6Rpe3NsD9blu+exr32f++P+yCxA8zZlxBNyI/S2WcU8XIMNK6rDDxI7oBT3U=; In-Reply-To: <878s4zzpvc.fsf@mail.linkov.net> Content-Language: en-US Received-SPF: pass client-ip=2a01:4f8:121:346::180; envelope-from=mail@daniel-mendler.de; helo=mail.qxqx.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268682 Archived-At: On 4/30/21 6:51 PM, Juri Linkov wrote: > Aren't affixations guarded by completions-detailed > and grouping guarded by completions-group orthogonal? > Then it should be fine to have separate options. Yes, they are orthogonal. I agree we can keep it as is. I still wanted to point it out. And note the difference - the completions-group guard variable is checked in minibuffer.el, while the completions-detailed variable is checked in the completion table in help-fns.el. Maybe completions-detailed should also be checked in the minibuffer.el instead? Daniel