From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#65491: [PATCH] Improve performance allocating vectors Date: Mon, 18 Sep 2023 18:10:47 +0200 Message-ID: <95C2D44B-BA1B-47F5-8279-B3A3B8F7EB39@gmail.com> References: <6B2EDD07-AAEB-40E8-B369-F634296BD3D9@gmail.com> <83v8cagkqv.fsf@gnu.org> <83ttrugkj2.fsf@gnu.org> <83r0mygi4y.fsf@gnu.org> <8af6fa1c-4873-bd6e-e896-ab5bb8d012a2@cs.ucla.edu> <83led5gyxa.fsf@gnu.org> <83o7i0g4i9.fsf@gnu.org> <83jzsog35g.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12102"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65491@debbugs.gnu.org, Paul Eggert , monnier@iro.umontreal.ca To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 18 18:12:09 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qiGr3-0002tr-Kh for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 18 Sep 2023 18:12:09 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qiGqv-00024a-0q; Mon, 18 Sep 2023 12:12:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qiGqo-00023b-St for bug-gnu-emacs@gnu.org; Mon, 18 Sep 2023 12:11:55 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qiGqo-00069r-KF for bug-gnu-emacs@gnu.org; Mon, 18 Sep 2023 12:11:54 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qiGqw-0004SZ-H5 for bug-gnu-emacs@gnu.org; Mon, 18 Sep 2023 12:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Sep 2023 16:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65491 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65491-submit@debbugs.gnu.org id=B65491.169505346817063 (code B ref 65491); Mon, 18 Sep 2023 16:12:02 +0000 Original-Received: (at 65491) by debbugs.gnu.org; 18 Sep 2023 16:11:08 +0000 Original-Received: from localhost ([127.0.0.1]:54214 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qiGq3-0004R9-NH for submit@debbugs.gnu.org; Mon, 18 Sep 2023 12:11:07 -0400 Original-Received: from mail-lf1-x132.google.com ([2a00:1450:4864:20::132]:44145) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qiGpz-0004QT-L4 for 65491@debbugs.gnu.org; Mon, 18 Sep 2023 12:11:06 -0400 Original-Received: by mail-lf1-x132.google.com with SMTP id 2adb3069b0e04-50300141a64so3672520e87.0 for <65491@debbugs.gnu.org>; Mon, 18 Sep 2023 09:10:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695053449; x=1695658249; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=fIbnGQM88diokKIgKiS+kV9pfHTC0uhmFoKqgeb3wUA=; b=KwZ7FJH5q1ETmHS/fc3lVaneGbBKdVRnG5SpswVHcWB8UWca3qjgAgcnvKma+jYjuH J2aAvY3EfmhuF2zHme+heBO0Xmes6MymF5HcBtuMJCgZlXK3c4941E/sGpc2qm/KhJqo 9jirgSExE5HvH+qVHH+beAWJT/6Xf/EBkOb+Th4MOpXJXBnygYaXsKpy0QznVWwqbt1S /tfd75TxEH6qpkBE3Wk2Q66TTJSr6AF40p54kSECcpJ0obTDq1xd0a2dvwKNoQYIV2jF l7HmlkZdYoiL8P4jXMvQvvypak2ByOwYXJOjEE8FrksckvdlM6MsEE97Yn0qb8t7nXbo 9zZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695053449; x=1695658249; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=fIbnGQM88diokKIgKiS+kV9pfHTC0uhmFoKqgeb3wUA=; b=R/tObmx3/EnvZnwZ3WGCyIrj7RMVdKp2CLm8C9OPqnPeyvwiDlrMPqGBrQXTFUAiq+ ErdQfzQed/1YknXLakO1E/HPpO51F69+82PTWgJKQlpkTJiINojzufdk7qrWXPeXH8fw 4KERfn7QZeaOEaX831+FFZMQJ62SV1K5ltY/rBCITR2Dr7Qy8DWV4sO5wZWgO1ubVZju IanpY/AKfgO0NyLaFOJQPDFx8RQ8X8ESDjWEz9ut80j2615jLdaTOXFSHzjknb9eE4Ll tCv0QC4egLEIYu/DRdH3uEjYRelUmK0/kKZ0pVmCag9/nkDMUrH/nYvV+fIMw65mM28P YOFw== X-Gm-Message-State: AOJu0Yx7myCoUmR4sJOEAxOqST9jjluTssv+EfnqXGGfwZXzuLW21GuJ r8fUgD1klvVKul2aj9XvWIA= X-Google-Smtp-Source: AGHT+IGeuxlyjJpIUbLO8R9BhB3HMtsSoChO8FwEk/WZ4XrRnF3aXPbBHazWplgTN2S765d4n6+1Sw== X-Received: by 2002:a19:655a:0:b0:503:985:92c4 with SMTP id c26-20020a19655a000000b00503098592c4mr3971220lfj.52.1695053448850; Mon, 18 Sep 2023 09:10:48 -0700 (PDT) Original-Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id a28-20020ac2521c000000b005008cd93961sm1861258lfl.192.2023.09.18.09.10.47 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Sep 2023 09:10:47 -0700 (PDT) In-Reply-To: <83jzsog35g.fsf@gnu.org> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:270819 Archived-At: 17 sep. 2023 kl. 18.44 skrev Eli Zaretskii : > Feel free to add any comments you find useful, that is always welcome. > But comments about complicated code have one downside: they need to be > updated when the code changes, and people forget to do that... Eli and Paul, thank you very much. I'm reapplying the patches (that we = now know shouldn't cause warnings), with added comments with respect to = the vanishing subtrahend in -with-wide-int builds. The conversion at the other end, TAG_PTR, suffers from the same = potential problem but in reverse, which is perhaps less obvious to the = casual C programmer but nevertheless a danger of the same kind, so we'd = better do something about it as well. I'll be back with a proposed = patch.